Re: Help with build changes for: 8214796: Create a jlink plugin for stripping debug info symbols from native libraries

2019-01-28 Thread Mandy Chung
On 1/28/19 1:26 AM, Severin Gehwolf wrote: Hi Alan, Mandy, On Sun, 2019-01-27 at 08:14 +, Alan Bateman wrote: On 26/01/2019 00:06, Mandy Chung wrote: Hi Severin, Another alternative would be to support per-jlink-plugin resource bundle to avoid merging .properties files at build time.

Re: Help with build changes for: 8214796: Create a jlink plugin for stripping debug info symbols from native libraries

2019-01-28 Thread Severin Gehwolf
On Mon, 2019-01-28 at 14:40 +, Alan Bateman wrote: > On 28/01/2019 09:26, Severin Gehwolf wrote: > > : > > > I skimmed the current patch and I see the usability has improved since > > > the original proposal. It would be nice to get to > > > `--strip-native-debug-symbols` without needing the

Re: Help with build changes for: 8214796: Create a jlink plugin for stripping debug info symbols from native libraries

2019-01-28 Thread Alan Bateman
On 28/01/2019 09:26, Severin Gehwolf wrote: : I skimmed the current patch and I see the usability has improved since the original proposal. It would be nice to get to `--strip-native-debug-symbols` without needing the "=defaults" suffix. There are details around the sub-options and naming that

Re: Help with build changes for: 8214796: Create a jlink plugin for stripping debug info symbols from native libraries

2019-01-28 Thread Severin Gehwolf
Hi Alan, Mandy, On Sun, 2019-01-27 at 08:14 +, Alan Bateman wrote: > On 26/01/2019 00:06, Mandy Chung wrote: > > Hi Severin, > > > > Another alternative would be to support per-jlink-plugin resource > > bundle to avoid merging .properties files at build time. The > > plugin-specific

Re: Help with build changes for: 8214796: Create a jlink plugin for stripping debug info symbols from native libraries

2019-01-28 Thread Severin Gehwolf
On Fri, 2019-01-25 at 09:17 -0800, Erik Joelsson wrote: > Hello Severin, > To get the conditional running of either MergeProperties or copy, I > would do something like this: > $$($1_TARGET): $$($1_DEPS) > $$(call MakeTargetDir) > ifneq ($$($1_NUM_INPUT_FILES),1) >

Re: Help with build changes for: 8214796: Create a jlink plugin for stripping debug info symbols from native libraries

2019-01-28 Thread Severin Gehwolf
On Fri, 2019-01-25 at 17:55 +0100, Magnus Ihse Bursie wrote: > > > On 2019-01-25 16:27, Severin Gehwolf wrote: > > Hi, > > > > I'm working on an enhancement for jlink. In particular a platform > > specific plugin. I.e. It would only get built on unix/linux > > platforms. > > My trouble is

Re: Help with build changes for: 8214796: Create a jlink plugin for stripping debug info symbols from native libraries

2019-01-27 Thread Alan Bateman
On 26/01/2019 00:06, Mandy Chung wrote: Hi Severin, Another alternative would be to support per-jlink-plugin resource bundle to avoid merging .properties files at build time.  The plugin-specific messages should only be used by the plugin itself and it would be cleaner for each plugin to manage

Re: Help with build changes for: 8214796: Create a jlink plugin for stripping debug info symbols from native libraries

2019-01-25 Thread Mandy Chung
Hi Severin, Another alternative would be to support per-jlink-plugin resource bundle to avoid merging .properties files at build time.  The plugin-specific messages should only be used by the plugin itself and it would be cleaner for each plugin to manage its resource bundle. Mandy On 1/25/19

Re: Help with build changes for: 8214796: Create a jlink plugin for stripping debug info symbols from native libraries

2019-01-25 Thread Erik Joelsson
Hello Severin, To get the conditional running of either MergeProperties or copy, I would do something like this: $$($1_TARGET): $$($1_DEPS) $$(call MakeTargetDir) ifneq ($$($1_NUM_INPUT_FILES),1) $$(call LogInfo, Merging $$(words $$($1_INPUT_FILES)) properties files into a

Re: Help with build changes for: 8214796: Create a jlink plugin for stripping debug info symbols from native libraries

2019-01-25 Thread Magnus Ihse Bursie
On 2019-01-25 16:27, Severin Gehwolf wrote: Hi, I'm working on an enhancement for jlink. In particular a platform specific plugin. I.e. It would only get built on unix/linux platforms. My trouble is getting some resouce properties set up properly. In my example there is two versions of

Help with build changes for: 8214796: Create a jlink plugin for stripping debug info symbols from native libraries

2019-01-25 Thread Severin Gehwolf
Hi, I'm working on an enhancement for jlink. In particular a platform specific plugin. I.e. It would only get built on unix/linux platforms. My trouble is getting some resouce properties set up properly. In my example there is two versions of plugins.properties: one in shared/classes one in