Hi Jiangli,
thanks for looking at the change. Unfortunately I've already pushed it
in order to fix our nightly builds.
I think the comment should only mention the variants which are
explicitly excluded by that function. All other cases are now handled
by the "ENABLE_CDS" flag which seems more nat
Hi Erik,
thanks for reviewing and sorry but I've already pushed this yesterday
evening before leaving because I wanted to fix our nightly builds.
I agree that the long line in jdk-options.m4 is ugly and I put it on
my TODO list. Taking into account the current cadence of AIX build
fixes I think i
Hi Volker,
Looks good. Thanks for fixing! It would be good to update the following
comment in jdk-options.m4 to add AIX, minimal and core.
609
610 #
611 # Disable the default CDS archive generation
612 # c
Hello,
Looks good. My only minor nit is the rather long line in jdk-options.m4
that I would appreciate if it was broken up (no need for respin if you do).
/Erik
On 2018-10-08 03:10, Volker Simonis wrote:
Hi Martin, Goetz,
thanks for reviewing my patch! As Aleksey posted a similar patch for
Looks good. Thanks for fixing this!
- Ioi
On 10/8/18 3:10 AM, Volker Simonis wrote:
Hi Martin, Goetz,
thanks for reviewing my patch! As Aleksey posted a similar patch for
fixing the Zero build I've extended my patch to handle
zero/minimal/core as well.
In fact the patch now disables CDS on A
On Mon, Oct 8, 2018 at 12:59 PM Aleksey Shipilev wrote:
>
> On 10/08/2018 12:10 PM, Volker Simonis wrote:
> > @Aleksey Shipilev : can you please check if this new version of my
> > patch also works for you?
> >
> > http://cr.openjdk.java.net/~simonis/webrevs/2018/8211837.v1/
>
> Checked Linux x86_
On 10/08/2018 12:10 PM, Volker Simonis wrote:
> @Aleksey Shipilev : can you please check if this new version of my
> patch also works for you?
>
> http://cr.openjdk.java.net/~simonis/webrevs/2018/8211837.v1/
Checked Linux x86_64 {server, minimal, zero}, all build fine with this patch!
Closed my
, 8. Oktober 2018 12:11
> To: Doerr, Martin
> Cc: build-dev ; hotspot-runtime-
> d...@openjdk.java.net runtime
> Subject: Re: RFR(XS): 8211837: Creation of the default CDS Archive should
> depend on ENABLE_CDS
>
> Hi Martin, Goetz,
>
> thanks for reviewing my patch
> Cc: build-dev ; hotspot-runtime-
> d...@openjdk.java.net runtime
> Subject: Re: RFR(XS): 8211837: Creation of the default CDS Archive should
> depend on ENABLE_CDS
>
> Hi Martin, Goetz,
>
> thanks for reviewing my patch! As Aleksey posted a similar patch for
> fixin
Hi Martin, Goetz,
thanks for reviewing my patch! As Aleksey posted a similar patch for
fixing the Zero build I've extended my patch to handle
zero/minimal/core as well.
In fact the patch now disables CDS on AIX, minimal, core and zero
unless the user explicitly requests it with the help of
`--wit
Hi Volker,
looks good. Thanks for fixing.
Of course, it would be great if this could be used to fix minimal/zero build,
too.
Best regards,
Martin
-Original Message-
From: hotspot-runtime-dev On
Behalf Of Volker Simonis
Sent: Montag, 8. Oktober 2018 10:19
To: build-dev ;
hotspot-runt
Hi Volker, Aleksey,
Voker, your change looks good.
I also think CDS should be turned off on minimal VM,
and also the case for zero a few lines below should
be removed in a similar manner. But I'll leave to you
whether you want to handle that in a separate fix.
Best regards,
Goetz.
> --
12 matches
Mail list logo
