Re: RFR: JDK-8202384: Introduce altserver jvm variant with speculative execution disabled

On 2018-06-11 22:42, Erik Joelsson wrote: Hello, Based on the discussion here, I have reverted back to something more similar to webrev.02, but with a few changes. Mainly fixing a bug that caused JVM_FEATURES_hardened to not actually be the same as for server (if you have custom additions

Re: RFR: JDK-8202384: Introduce altserver jvm variant with speculative execution disabled

Looks good to me. /Jesper > On 11 Jun 2018, at 22:42, Erik Joelsson wrote: > > Hello, > > Based on the discussion here, I have reverted back to something more similar > to webrev.02, but with a few changes. Mainly fixing a bug that caused > JVM_FEATURES_hardened to not actually be the same as

Re: RFR: JDK-8202384: Introduce altserver jvm variant with speculative execution disabled

Hello, Based on the discussion here, I have reverted back to something more similar to webrev.02, but with a few changes. Mainly fixing a bug that caused JVM_FEATURES_hardened to not actually be the same as for server (if you have custom additions in configure). I also added a check so that c

Re: RFR: JDK-8202384: Introduce altserver jvm variant with speculative execution disabled

Sorry this is making my head spin. Doh! jvm-features only apply to the JVM. So I retract my last email - sorry. And with that I'm going to just bow out. You and Erik can figure it out. Thanks, David On 11/06/2018 6:19 PM, Magnus Ihse Bursie wrote: On 2018-06-11 09:38, David Holmes wrote: H

Re: RFR: JDK-8202384: Introduce altserver jvm variant with speculative execution disabled

On 2018-06-11 09:38, David Holmes wrote: Hi Magnus, On 11/06/2018 5:10 PM, Magnus Ihse Bursie wrote: On 2018-06-08 23:50, Erik Joelsson wrote: On 2018-06-07 17:30, David Holmes wrote: On 8/06/2018 6:11 AM, Erik Joelsson wrote: I just don't think the extra work is warranted or should be pri

Re: RFR: JDK-8202384: Introduce altserver jvm variant with speculative execution disabled

Hi Magnus, On 11/06/2018 5:10 PM, Magnus Ihse Bursie wrote: On 2018-06-08 23:50, Erik Joelsson wrote: On 2018-06-07 17:30, David Holmes wrote: On 8/06/2018 6:11 AM, Erik Joelsson wrote: I just don't think the extra work is warranted or should be prioritized at this point. I also cannot think

Re: RFR: JDK-8202384: Introduce altserver jvm variant with speculative execution disabled

On 2018-06-10 15:28, David Holmes wrote: On 9/06/2018 7:50 AM, Erik Joelsson wrote: On 2018-06-07 17:30, David Holmes wrote: On 8/06/2018 6:11 AM, Erik Joelsson wrote: I just don't think the extra work is warranted or should be prioritized at this point. I also cannot think of a combination

Re: RFR: JDK-8202384: Introduce altserver jvm variant with speculative execution disabled

On 2018-06-08 23:50, Erik Joelsson wrote: On 2018-06-07 17:30, David Holmes wrote: On 8/06/2018 6:11 AM, Erik Joelsson wrote: I just don't think the extra work is warranted or should be prioritized at this point. I also cannot think of a combination of options required for what you are suggest

Re: RFR: JDK-8202384: Introduce altserver jvm variant with speculative execution disabled

On 9/06/2018 7:50 AM, Erik Joelsson wrote: On 2018-06-07 17:30, David Holmes wrote: On 8/06/2018 6:11 AM, Erik Joelsson wrote: I just don't think the extra work is warranted or should be prioritized at this point. I also cannot think of a combination of options required for what you are sugges

Re: RFR: JDK-8202384: Introduce altserver jvm variant with speculative execution disabled

Doh, thanks, updated in place. /Erik On 2018-06-08 14:53, Daniel D. Daugherty wrote: On 6/8/18 5:50 PM, Erik Joelsson wrote: On 2018-06-07 17:30, David Holmes wrote: On 8/06/2018 6:11 AM, Erik Joelsson wrote: I just don't think the extra work is warranted or should be prioritized at this po

Re: RFR: JDK-8202384: Introduce altserver jvm variant with speculative execution disabled

On 6/8/18 5:50 PM, Erik Joelsson wrote: On 2018-06-07 17:30, David Holmes wrote: On 8/06/2018 6:11 AM, Erik Joelsson wrote: I just don't think the extra work is warranted or should be prioritized at this point. I also cannot think of a combination of options required for what you are suggestin

Re: RFR: JDK-8202384: Introduce altserver jvm variant with speculative execution disabled

On 2018-06-07 17:30, David Holmes wrote: On 8/06/2018 6:11 AM, Erik Joelsson wrote: I just don't think the extra work is warranted or should be prioritized at this point. I also cannot think of a combination of options required for what you are suggesting that wouldn't be confusing to the user

Re: RFR: JDK-8202384: Introduce altserver jvm variant with speculative execution disabled

On 8/06/2018 6:11 AM, Erik Joelsson wrote: On 2018-06-07 11:56, jesper.wilhelms...@oracle.com wrote: On 6 Jun 2018, at 06:17, David Holmes > wrote: Hi Erik, Jesper, So "benevolent dictatorship"?  ;-) My main concern is that the updated toolchains that support

Re: RFR: JDK-8202384: Introduce altserver jvm variant with speculative execution disabled

On 2018-06-07 11:56, jesper.wilhelms...@oracle.com wrote: On 6 Jun 2018, at 06:17, David Holmes > wrote: Hi Erik, Jesper, So "benevolent dictatorship"?  ;-) My main concern is that the updated toolchains that support this have all been produced in a mad rus

Re: RFR: JDK-8202384: Introduce altserver jvm variant with speculative execution disabled

> On 6 Jun 2018, at 06:17, David Holmes wrote: > > Hi Erik, Jesper, > > On 6/06/2018 2:59 AM, jesper.wilhelms...@oracle.com > wrote: >>> On 5 Jun 2018, at 08:10, David Holmes wrote: >>> >>> Sorry to be late to this party ... >>> >>> On 5/06/2018 6:10 AM

RE: RFR: JDK-8202384: Introduce altserver jvm variant with

Thanks for the clarification ! From: Erik Joelsson [mailto:erik.joels...@oracle.com] Sent: Dienstag, 5. Juni 2018 17:51 To: Baesken, Matthias ; 'hotspot-...@openjdk.java.net' ; 'build-dev@openjdk.java.net' Cc: Zeller, Arno Subject: Re: RFR: JDK-8202384: Introduce altser

Re: RFR: JDK-8202384: Introduce altserver jvm variant with speculative execution disabled

Hi Erik, Jesper, On 6/06/2018 2:59 AM, jesper.wilhelms...@oracle.com wrote: On 5 Jun 2018, at 08:10, David Holmes wrote: Sorry to be late to this party ... On 5/06/2018 6:10 AM, Erik Joelsson wrote: New webrev: http://cr.openjdk.java.net/~erikj/8202384/webrev.02/ Renamed the new jvm variant

Re: RFR: JDK-8202384: Introduce altserver jvm variant with speculative execution disabled

> On 5 Jun 2018, at 08:10, David Holmes wrote: > > Sorry to be late to this party ... > > On 5/06/2018 6:10 AM, Erik Joelsson wrote: >> New webrev: http://cr.openjdk.java.net/~erikj/8202384/webrev.02/ >> Renamed the new jvm variant to "hardened". > > As it is a hardened server build I'd prefer

Re: RFR: JDK-8202384: Introduce altserver jvm variant with speculative execution disabled

On Tue, Jun 5, 2018 at 6:47 PM, Erik Joelsson wrote: > Hello Volker, > > On 2018-06-05 09:35, Volker Simonis wrote: >> >> Hi Erik, >> >> you wrote: "Note that this applies to the build time C++ flags, not >> the compiler in the JVM itself." So what about the code generated by >> the HotSpot (i.e.

Re: RFR: JDK-8202384: Introduce altserver jvm variant with

Hello again, Looks like Jesper updated the bug description with more info. /Erik On 2018-06-05 08:50, Erik Joelsson wrote: Hello Matthias, For GCC, you need 7.3.0 or later. For Microsoft you need VS2017 and I think some minimal update version (the option is called -Qspectre), we use 15.5.5

Re: RFR: JDK-8202384: Introduce altserver jvm variant with speculative execution disabled

Hello Volker, On 2018-06-05 09:35, Volker Simonis wrote: Hi Erik, you wrote: "Note that this applies to the build time C++ flags, not the compiler in the JVM itself." So what about the code generated by the HotSpot (i.e. stubs, template interpreter, c1, c2, Graal)? Is this code already "hardene

Re: RFR: JDK-8202384: Introduce altserver jvm variant with speculative execution disabled

Hi Erik, you wrote: "Note that this applies to the build time C++ flags, not the compiler in the JVM itself." So what about the code generated by the HotSpot (i.e. stubs, template interpreter, c1, c2, Graal)? Is this code already "hardened" against speculative execution? If yes, that's fine, if no

Re: RFR: JDK-8202384: Introduce altserver jvm variant with

Hello Matthias, For GCC, you need 7.3.0 or later. For Microsoft you need VS2017 and I think some minimal update version (the option is called -Qspectre), we use 15.5.5. I was not involved in the benchmarking so I don't know any details there, only the conclusion. /Erik On 2018-06-05 01:3

Re: RFR: JDK-8202384: Introduce altserver jvm variant with speculative execution disabled

Hello, On 2018-06-04 23:10, David Holmes wrote: Sorry to be late to this party ... On 5/06/2018 6:10 AM, Erik Joelsson wrote: New webrev: http://cr.openjdk.java.net/~erikj/8202384/webrev.02/ Renamed the new jvm variant to "hardened". As it is a hardened server build I'd prefer if that were

RE: RFR: JDK-8202384: Introduce altserver jvm variant with

Hi Erik , is there some info available about the performance impact when disabling disabling speculative execution ? And which compiler versions are needed for this ? Best regards, Matthias >We need to add compilation flags for disabling speculative execution to >our native librar

Re: RFR: JDK-8202384: Introduce altserver jvm variant with speculative execution disabled

Sorry to be late to this party ... On 5/06/2018 6:10 AM, Erik Joelsson wrote: New webrev: http://cr.openjdk.java.net/~erikj/8202384/webrev.02/ Renamed the new jvm variant to "hardened". As it is a hardened server build I'd prefer if that were somehow reflected in the name. Though really I do

Re: RFR: JDK-8202384: Introduce altserver jvm variant with speculative execution disabled

Looks good to me. /Jesper > On 4 Jun 2018, at 22:10, Erik Joelsson wrote: > > New webrev: http://cr.openjdk.java.net/~erikj/8202384/webrev.02/ > > Renamed the new jvm variant to "hardened". > > /Erik > > > On 2018-06-04 09:54, jesper.wilhelms...@oracle.com wrote: >>> On 4 Jun 2018, at 17:52,

Re: RFR: JDK-8202384: Introduce altserver jvm variant with speculative execution disabled

New webrev: http://cr.openjdk.java.net/~erikj/8202384/webrev.02/ Renamed the new jvm variant to "hardened". /Erik On 2018-06-04 09:54, jesper.wilhelms...@oracle.com wrote: On 4 Jun 2018, at 17:52, Erik Joelsson wrote: Hello, On 2018-06-01 14:00, Aleksey Shipilev wrote: On 06/01/2018 10:53

Re: RFR: JDK-8202384: Introduce altserver jvm variant with speculative execution disabled

> On 4 Jun 2018, at 17:52, Erik Joelsson wrote: > > Hello, > > On 2018-06-01 14:00, Aleksey Shipilev wrote: >> On 06/01/2018 10:53 PM, Erik Joelsson wrote: >>> This patch defines flags for disabling speculative execution for GCC and >>> Visual Studio and applies >>> them to all binaries except

Re: RFR: JDK-8202384: Introduce altserver jvm variant with speculative execution disabled

Hello, On 2018-06-01 14:00, Aleksey Shipilev wrote: On 06/01/2018 10:53 PM, Erik Joelsson wrote: This patch defines flags for disabling speculative execution for GCC and Visual Studio and applies them to all binaries except libjvm when available in the compiler. It defines a new jvm feature n

Re: RFR: JDK-8202384: Introduce altserver jvm variant with speculative execution disabled

> 1 juni 2018 kl. 23:53 skrev Erik Joelsson : > > We need to add compilation flags for disabling speculative execution to our > native libraries and executables. In order to allow for users not affected by > problems with speculative execution to run a JVM at full speed, we need to be > able

Re: RFR: JDK-8202384: Introduce altserver jvm variant with speculative execution disabled

/Magnus > 1 juni 2018 kl. 23:53 skrev Erik Joelsson : > > We need to add compilation flags for disabling speculative execution to our > native libraries and executables. In order to allow for users not affected by > problems with speculative execution to run a JVM at full speed, we need to b

Re: RFR: JDK-8202384: Introduce altserver jvm variant with speculative execution disabled

On 06/01/2018 10:53 PM, Erik Joelsson wrote: > This patch defines flags for disabling speculative execution for GCC and > Visual Studio and applies > them to all binaries except libjvm when available in the compiler. It defines > a new jvm feature > no-speculative-cti, which is used to control wh