Re: RFR(T) : 8219132 : switch to jtreg4.2-b14

Hi Alan, On 20/02/2019 5:08 pm, Alan Bateman wrote: On 20/02/2019 00:34, Igor Ignatyev wrote: http://cr.openjdk.java.net/~iignatyev//8219132/webrev.00/index.html 1 line changed: 0 ins; 0 del; 1 mod; Hi all, could you please review this one-liner which switch jtreg version to

Re: RFR(T) : 8219132 : switch to jtreg4.2-b14

On 20/02/2019 00:34, Igor Ignatyev wrote: http://cr.openjdk.java.net/~iignatyev//8219132/webrev.00/index.html 1 line changed: 0 ins; 0 del; 1 mod; Hi all, could you please review this one-liner which switch jtreg version to jtreg4.2-b14? webrev:

Re: RFR(T) : 8219132 : switch to jtreg4.2-b14

I've pushed the patch. for the reference, 8219408 [1] was filed to handle jdk tests which have ${; the only affected hotspot tests are vmTestbase tests, so 8219140 [2] covers all hotspot

Re: RFR(T) : 8219132 : switch to jtreg4.2-b14

Hi Igor, On 2/19/2019 5:54 PM, Igor Ignatyev wrote: Joe, allowSmartActionArgs is opt-in if requiredVersion < b14, and opt-out if requiredVersion >= b14, please see http://hg.openjdk.java.net/code-tools/jtreg/rev/36c592d2f544 . so you don't have to have allowSmartActionArgs=true in 8219254.

Re: RFR(T) : 8219132 : switch to jtreg4.2-b14

Joe, allowSmartActionArgs is opt-in if requiredVersion < b14, and opt-out if requiredVersion >= b14, please see http://hg.openjdk.java.net/code-tools/jtreg/rev/36c592d2f544 . so you don't have to have allowSmartActionArgs=true in

Re: RFR(T) : 8219132 : switch to jtreg4.2-b14

Hello, On 2/19/2019 5:06 PM, Igor Ignatyev wrote: Hi Erik, thanks for your review. we can't just bump the required version as it can introduce changes in tests' behavior. requiredVersion >= 4.2 b14 will enable allowSmartActionArgs[1], From what I understand from Jon, allowSmartActionArgs

Re: RFR(T) : 8219132 : switch to jtreg4.2-b14

Hi Erik, thanks for your review. we can't just bump the required version as it can introduce changes in tests' behavior. requiredVersion >= 4.2 b14 will enable allowSmartActionArgs[1], this will affect all the tests which have ${} in their @run directives, for example it will affect many

Re: RFR(T) : 8219132 : switch to jtreg4.2-b14

Looks good. Do we need to also bump the required version in the TEST.ROOT files? /Erik On 2019-02-19 16:34, Igor Ignatyev wrote: http://cr.openjdk.java.net/~iignatyev//8219132/webrev.00/index.html 1 line changed: 0 ins; 0 del; 1 mod; Hi all, could you please review this one-liner which

RFR(T) : 8219132 : switch to jtreg4.2-b14

http://cr.openjdk.java.net/~iignatyev//8219132/webrev.00/index.html > 1 line changed: 0 ins; 0 del; 1 mod; Hi all, could you please review this one-liner which switch jtreg version to jtreg4.2-b14? webrev: http://cr.openjdk.java.net/~iignatyev//8219132/webrev.00/index.html JBS: