On Wed, 30 Mar 2022 20:59:34 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-424 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] - https://openjd
> This PR contains the API and implementation changes for JEP-424 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.java.net/jeps/424
Maurizio Cimadamore has updated the pull request
> This PR contains the API and implementation changes for JEP-424 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.java.net/jeps/424
Maurizio Cimadamore has updated the pull request
> This PR contains the API and implementation changes for JEP-424 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.java.net/jeps/424
Maurizio Cimadamore has updated the pull request
On Wed, 30 Mar 2022 12:25:52 GMT, Aleksey Shipilev wrote:
> JMH 1.35 is released, so we can bump the devkit too.
>
> Additional testing:
> - [x] JMH devkit creation
> - [x] Sample benchmarks
Marked as reviewed by redestad (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/8
On Wed, 30 Mar 2022 12:25:52 GMT, Aleksey Shipilev wrote:
> JMH 1.35 is released, so we can bump the devkit too.
>
> Additional testing:
> - [x] JMH devkit creation
> - [x] Sample benchmarks
Marked as reviewed by erikj (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/8040
On Wed, 30 Mar 2022 01:05:08 GMT, Magnus Ihse Bursie wrote:
> When a user has problems with their build environment that trips up their
> builds, the cause is often one of just a few "popular" gotchas. For us
> working with the build system, we've seen them all before, but for the
> individual
JMH 1.35 is released, so we can bump the devkit too.
Additional testing:
- [x] JMH devkit creation
- [x] Sample benchmarks
-
Commit messages:
- Fix
Changes: https://git.openjdk.java.net/jdk/pull/8040/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=8040&range=00
Iss
Schedule approximation for building the _clustered sea-of-nodes_ and
_control-flow graph_ views is an expensive computation that can sometimes take
as much time as computing the layout of the graph itself. This change removes
the main bottleneck in schedule approximation by computing common domi
On Wed, 30 Mar 2022 06:35:27 GMT, Christian Hagedorn
wrote:
>> Hi Christian,
>>
>> this is impressive work. It's a big change, and I had a look at part of it.
>> I'll continue tomorrow.
>>
>> In general, I'm concerned with the use of both UL and ResourceArea in this
>> code. I know the use o
On Mon, 28 Mar 2022 13:14:50 GMT, Thomas Stuefe wrote:
> this is impressive work. It's a big change, and I had a look at part of it.
> I'll continue tomorrow.
Thanks a lot Thomas for your careful review! I'm in the process of working
through your comments and will come back with an update toda
On Mon, 28 Feb 2022 16:22:25 GMT, Christian Hagedorn
wrote:
>> When printing the native stack trace on Linux (mostly done for hs_err
>> files), it only prints the method with its parameters and a relative offset
>> in the method:
>>
>> Stack: [0x7f6e01739000,0x7f6e0183a000], sp=0x000
On Mon, 28 Feb 2022 16:22:25 GMT, Christian Hagedorn
wrote:
>> When printing the native stack trace on Linux (mostly done for hs_err
>> files), it only prints the method with its parameters and a relative offset
>> in the method:
>>
>> Stack: [0x7f6e01739000,0x7f6e0183a000], sp=0x000
When a user has problems with their build environment that trips up their
builds, the cause is often one of just a few "popular" gotchas. For us working
with the build system, we've seen them all before, but for the individual user,
it's often the first time, and it can be really frustrating to
> Oracle is updating the version of Visual Studio for building the JDK on
> Windows to Visual Studio 2022 17.1.0.
>
> This change adds support for building devkits based on VS 2022. Instead of
> creating a new script file for that I decided to combine it with the logic in
> createWindowsDevkit2
> This PR contains the API and implementation changes for JEP-424 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.java.net/jeps/424
Maurizio Cimadamore has updated the pull request
> This PR contains the API and implementation changes for JEP-424 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.java.net/jeps/424
Maurizio Cimadamore has updated the pull request
On Mon, 28 Mar 2022 16:43:30 GMT, Mikael Vidstedt wrote:
>> Oracle is updating the version of Visual Studio for building the JDK on
>> Windows to Visual Studio 2022 17.1.0.
>>
>> This change adds support for building devkits based on VS 2022. Instead of
>> creating a new script file for that I
On Mon, 28 Mar 2022 22:25:01 GMT, David Holmes wrote:
>> src/hotspot/share/utilities/elfFile.cpp line 450:
>>
>>> 448: if (buf == nullptr) {
>>> 449: return false;
>>> 450: }
>>
>> I'd move this close to and local to where it is used.
>>
>> Also, you seem to repeat the same pattern a l
On Mon, 28 Mar 2022 11:18:36 GMT, Christian Hagedorn
wrote:
>> As I said before, I think it would be nice to share DWARF parser between SA
>> and HotSpot. Can you expose these mechanisms? It may be another RFE, and may
>> need to think other platforms.
>
>> As I said before, I think it would b
On Mon, 28 Mar 2022 12:58:20 GMT, Thomas Stuefe wrote:
>> Christian Hagedorn has updated the pull request with a new target base due
>> to a merge or a rebase. The pull request now contains 54 commits:
>>
>> - Updating some comments
>> - Cleanup loading dwarf file and add summary
>> - Review
On Mon, 28 Mar 2022 16:05:03 GMT, Mikael Vidstedt wrote:
>> make/devkit/createWindowsDevkit.sh line 74:
>>
>>> 72: # Work around the insanely named ProgramFiles(x86) env variable
>>> 73: PROGRAMFILES_X86="$($WINDOWS_PATH_TO_UNIX_PATH "$(cmd.exe /c set | sed
>>> -n 's/^ProgramFiles(x86)=//p' | t
On Mon, 28 Mar 2022 16:40:31 GMT, Mikael Vidstedt wrote:
>> Oracle is updating the version of Visual Studio for building the JDK on
>> Windows to Visual Studio 2022 17.1.0.
>>
>> This change adds support for building devkits based on VS 2022. Instead of
>> creating a new script file for that I
> Oracle is updating the version of Visual Studio for building the JDK on
> Windows to Visual Studio 2022 17.1.0.
>
> This change adds support for building devkits based on VS 2022. Instead of
> creating a new script file for that I decided to combine it with the logic in
> createWindowsDevkit2
> Oracle is updating the version of Visual Studio for building the JDK on
> Windows to Visual Studio 2022 17.1.0.
>
> This change adds support for building devkits based on VS 2022. Instead of
> creating a new script file for that I decided to combine it with the logic in
> createWindowsDevkit2
On Mon, 28 Mar 2022 11:54:28 GMT, Magnus Ihse Bursie wrote:
>> Mikael Vidstedt has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove PROGRAMFILES workaround
>
> make/devkit/createWindowsDevkit.sh line 74:
>
>> 72: # Work around the ins
On Mon, 28 Mar 2022 12:20:44 GMT, Thomas Stuefe wrote:
>> Christian Hagedorn has updated the pull request with a new target base due
>> to a merge or a rebase. The pull request now contains 54 commits:
>>
>> - Updating some comments
>> - Cleanup loading dwarf file and add summary
>> - Review
On Thu, 24 Feb 2022 08:14:34 GMT, Thomas Stuefe wrote:
>> Christian Hagedorn has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Make dwarf tag NOT_PRODUCT
>
> src/hotspot/share/utilities/decoder_elf.cpp line 67:
>
>> 65: if (!os::dll_add
On Mon, 28 Feb 2022 16:22:25 GMT, Christian Hagedorn
wrote:
>> When printing the native stack trace on Linux (mostly done for hs_err
>> files), it only prints the method with its parameters and a relative offset
>> in the method:
>>
>> Stack: [0x7f6e01739000,0x7f6e0183a000], sp=0x000
On Tue, 8 Feb 2022 08:17:17 GMT, Christian Hagedorn
wrote:
>> When printing the native stack trace on Linux (mostly done for hs_err
>> files), it only prints the method with its parameters and a relative offset
>> in the method:
>>
>> Stack: [0x7f6e01739000,0x7f6e0183a000], sp=0x
On Sun, 27 Mar 2022 05:08:52 GMT, Mikael Vidstedt wrote:
> Oracle is updating the version of Visual Studio for building the JDK on
> Windows to Visual Studio 2022 17.1.0.
>
> This change adds support for building devkits based on VS 2022. Instead of
> creating a new script file for that I deci
On Mon, 28 Mar 2022 09:13:39 GMT, Yasumasa Suenaga wrote:
> As I said before, I think it would be nice to share DWARF parser between SA
> and HotSpot. Can you expose these mechanisms? It may be another RFE, and may
> need to think other platforms.
That would be good to have. However, I'm not f
On Mon, 28 Feb 2022 16:22:25 GMT, Christian Hagedorn
wrote:
>> When printing the native stack trace on Linux (mostly done for hs_err
>> files), it only prints the method with its parameters and a relative offset
>> in the method:
>>
>> Stack: [0x7f6e01739000,0x7f6e0183a000], sp=0x000
On Mon, 28 Mar 2022 08:44:10 GMT, Thomas Stuefe wrote:
> > Ping - may I get another review for this change?
>
> I'll take a look later today or tomorrow. This is nice stuff, I'm looking
> forward to having it upstream.
That's great, thanks Thomas!
-
PR: https://git.openjdk.java.n
On Mon, 28 Mar 2022 06:46:30 GMT, Christian Hagedorn
wrote:
> Ping - may I get another review for this change?
I'll take a look later today or tomorrow. This is nice stuff, I'm looking
forward to having it upstream.
-
PR: https://git.openjdk.java.net/jdk/pull/7126
On Mon, 28 Feb 2022 16:22:25 GMT, Christian Hagedorn
wrote:
>> When printing the native stack trace on Linux (mostly done for hs_err
>> files), it only prints the method with its parameters and a relative offset
>> in the method:
>>
>> Stack: [0x7f6e01739000,0x7f6e0183a000], sp=0x000
Oracle is updating the version of Visual Studio for building the JDK on Windows
to Visual Studio 2022 17.1.0.
This change adds support for building devkits based on VS 2022. Instead of
creating a new script file for that I decided to combine it with the logic in
createWindowsDevkit2019.sh and r
> This PR contains the API and implementation changes for JEP-424 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.java.net/jeps/424
Maurizio Cimadamore has updated the pull request
On Thu, 24 Mar 2022 19:17:40 GMT, Jorn Vernee wrote:
>> I'd suggest at least adding `--enable-preview` as an argument when running
>> benchmarks through the build system in that case. I think this should do the
>> trick:
>>
>>
>> diff --git a/make/RunTests.gmk b/make/RunTests.gmk
>> index 815
On Thu, 24 Mar 2022 18:35:12 GMT, Jorn Vernee wrote:
>> Sure, this is problematic - but at the same time I don't think there's a
>> better way to deal with this? I'd prefer to defer this to a separate issue
>> (and I think the build team is in a much better position to suggest a better
>> fix)
On Thu, 24 Mar 2022 19:19:34 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-424 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] - https://openjd
> This PR contains the API and implementation changes for JEP-424 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.java.net/jeps/424
Maurizio Cimadamore has updated the pull request
> This PR contains the API and implementation changes for JEP-424 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.java.net/jeps/424
Maurizio Cimadamore has updated the pull request
> This PR contains the API and implementation changes for JEP-424 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.java.net/jeps/424
Maurizio Cimadamore has updated the pull request
On Thu, 24 Mar 2022 17:48:23 GMT, Maurizio Cimadamore
wrote:
>> make/test/BuildMicrobenchmark.gmk line 97:
>>
>>> 95: SRC := $(MICROBENCHMARK_SRC), \
>>> 96: BIN := $(MICROBENCHMARK_CLASSES), \
>>> 97: JAVAC_FLAGS := --add-exports
>>> java.base/sun.security.util=ALL-UNNAMED --enabl
On Thu, 24 Mar 2022 13:00:12 GMT, Jorn Vernee wrote:
>> Maurizio Cimadamore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Drop redundant javadoc statements re. handling of nulls
>> (handling of nulls is specified once and for all in
> This PR contains the API and implementation changes for JEP-424 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.java.net/jeps/424
Maurizio Cimadamore has updated the pull request
On Thu, 24 Mar 2022 13:10:20 GMT, Jorn Vernee wrote:
>> Maurizio Cimadamore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Drop redundant javadoc statements re. handling of nulls
>> (handling of nulls is specified once and for all in
> This PR contains the API and implementation changes for JEP-424 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.java.net/jeps/424
Maurizio Cimadamore has updated the pull request
On Wed, 23 Mar 2022 14:06:56 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-424 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] - https://openjd
On Wed, 23 Mar 2022 22:06:49 GMT, Erik Joelsson wrote:
>> The version output of GNU time changed from "GNU time" to "GNU Time" in
>> version 1.8. We need to update our check for identifying GNU time to handle
>> this.
>
> Erik Joelsson has updated the pull request incrementally with one additio
On Thu, 24 Mar 2022 07:38:34 GMT, Sergey Bylokhov wrote:
>>> @mrserb Phil said that we don't even use the subset part of harfbuzz.
>>>
>>> And unless you're backing up your claim that this patch is changing runtime
>>> characteristic with data, that's just a guess, just like the initial
>>> op
On Thu, 24 Mar 2022 03:53:52 GMT, Phil Race wrote:
> And unless you're backing up your claim that this patch is changing runtime
> characteristic with data, that's just a guess, just like the initial
> optimization level of this library (and as most of the native libraries in
> the JDK... :-()
On Wed, 23 Mar 2022 02:17:22 GMT, Vladimir Kozlov wrote:
>> Fei Yang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix copyright header
>
> Update looks good.
> Testing results are also good.
@vnkozlov @shipilev : Thanks for reviewing
> This PR implements JEP 422: Linux/RISC-V Port [1].
> The PR starts as a squashed merge of the
> https://openjdk.java.net/projects/riscv-port branch.
>
> This has been tested with jtreg tier{1,2,3,4} and jcstress on HiFive
> Unmatched board. Dacapo, SPECjbb2015 and SPECjvm2008 benchmark tests a
On Wed, 23 Mar 2022 23:38:52 GMT, Sergey Bylokhov wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update comment to show we don't care about these files.
>
> Do we really want to change the product performanc
On Wed, 23 Mar 2022 23:38:52 GMT, Sergey Bylokhov wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update comment to show we don't care about these files.
>
> Do we really want to change the product performanc
On Wed, 23 Mar 2022 23:17:38 GMT, Magnus Ihse Bursie wrote:
>> [JDK-8247872](https://bugs.openjdk.java.net/browse/JDK-8247872) (upgrade
>> HarfBuzz to 2.7.2) caused build time to go up with 24 seconds on my
>> reference linux machine. This was one of the four culprits that caused a
>> 25-30% b
On Wed, 23 Mar 2022 23:13:04 GMT, Magnus Ihse Bursie wrote:
>> make/modules/java.desktop/lib/Awt2dLibraries.gmk line 487:
>>
>>> 485: LIBFONTMANAGER_OPTIMIZATION := HIGHEST
>>> 486:
>>> 487: ifneq ($(filter $(TOOLCHAIN_TYPE), gcc clang), )
>>
>> Can we have a note here that the de-opt is possi
On Wed, 23 Mar 2022 23:17:38 GMT, Magnus Ihse Bursie wrote:
>> [JDK-8247872](https://bugs.openjdk.java.net/browse/JDK-8247872) (upgrade
>> HarfBuzz to 2.7.2) caused build time to go up with 24 seconds on my
>> reference linux machine. This was one of the four culprits that caused a
>> 25-30% b
> [JDK-8247872](https://bugs.openjdk.java.net/browse/JDK-8247872) (upgrade
> HarfBuzz to 2.7.2) caused build time to go up with 24 seconds on my reference
> linux machine. This was one of the four culprits that caused a 25-30% build
> time regression over the last two years.
>
> The problem her
On Wed, 23 Mar 2022 22:37:55 GMT, Phil Race wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Restore HIGHEST for entire lib, just set SIZE to two files
>
> make/modules/java.desktop/lib/Awt2dLibraries.gmk line
On Wed, 23 Mar 2022 21:13:30 GMT, Magnus Ihse Bursie wrote:
>> [JDK-8247872](https://bugs.openjdk.java.net/browse/JDK-8247872) (upgrade
>> HarfBuzz to 2.7.2) caused build time to go up with 24 seconds on my
>> reference linux machine. This was one of the four culprits that caused a
>> 25-30% b
> The version output of GNU time changed from "GNU time" to "GNU Time" in
> version 1.8. We need to update our check for identifying GNU time to handle
> this.
Erik Joelsson has updated the pull request incrementally with one additional
commit since the last revision:
Update make/autoconf/ba
On Wed, 23 Mar 2022 21:13:30 GMT, Magnus Ihse Bursie wrote:
>> [JDK-8247872](https://bugs.openjdk.java.net/browse/JDK-8247872) (upgrade
>> HarfBuzz to 2.7.2) caused build time to go up with 24 seconds on my
>> reference linux machine. This was one of the four culprits that caused a
>> 25-30% b
On Wed, 23 Mar 2022 15:35:44 GMT, Erik Joelsson wrote:
> The version output of GNU time changed from "GNU time" to "GNU Time" in
> version 1.8. We need to update our check for identifying GNU time to handle
> this.
I usually handle cases like this by prefixing with a comment:
# Additional
> [JDK-8247872](https://bugs.openjdk.java.net/browse/JDK-8247872) (upgrade
> HarfBuzz to 2.7.2) caused build time to go up with 24 seconds on my reference
> linux machine. This was one of the four culprits that caused a 25-30% build
> time regression over the last two years.
>
> The problem her
On Wed, 23 Mar 2022 12:25:08 GMT, Magnus Ihse Bursie wrote:
> [JDK-8247872](https://bugs.openjdk.java.net/browse/JDK-8247872) (upgrade
> HarfBuzz to 2.7.2) caused build time to go up with 24 seconds on my reference
> linux machine. This was one of the four culprits that caused a 25-30% build
>
On Wed, 23 Mar 2022 19:35:22 GMT, Phil Race wrote:
>> [JDK-8247872](https://bugs.openjdk.java.net/browse/JDK-8247872) (upgrade
>> HarfBuzz to 2.7.2) caused build time to go up with 24 seconds on my
>> reference linux machine. This was one of the four culprits that caused a
>> 25-30% build time
On Wed, 23 Mar 2022 12:25:08 GMT, Magnus Ihse Bursie wrote:
> [JDK-8247872](https://bugs.openjdk.java.net/browse/JDK-8247872) (upgrade
> HarfBuzz to 2.7.2) caused build time to go up with 24 seconds on my reference
> linux machine. This was one of the four culprits that caused a 25-30% build
>
On Wed, 23 Mar 2022 12:25:08 GMT, Magnus Ihse Bursie wrote:
> [JDK-8247872](https://bugs.openjdk.java.net/browse/JDK-8247872) (upgrade
> HarfBuzz to 2.7.2) caused build time to go up with 24 seconds on my reference
> linux machine. This was one of the four culprits that caused a 25-30% build
>
On Wed, 23 Mar 2022 12:25:08 GMT, Magnus Ihse Bursie wrote:
> [JDK-8247872](https://bugs.openjdk.java.net/browse/JDK-8247872) (upgrade
> HarfBuzz to 2.7.2) caused build time to go up with 24 seconds on my reference
> linux machine. This was one of the four culprits that caused a 25-30% build
>
On Wed, 23 Mar 2022 16:22:55 GMT, Aleksey Shipilev wrote:
> Looks okay, provided you tested with some version of GNU [Tt]ime.
Thanks! I hit this while trying to use GNU time on my mac to get LOG=profile to
work, to profile compilation times of individual compilation units. I built
latest (1.9)
On Wed, 23 Mar 2022 15:35:44 GMT, Erik Joelsson wrote:
> The version output of GNU time changed from "GNU time" to "GNU Time" in
> version 1.8. We need to update our check for identifying GNU time to handle
> this.
Looks okay, provided you tested with some version of GNU [Tt]ime.
Is double sq
On Wed, 23 Mar 2022 12:25:08 GMT, Magnus Ihse Bursie wrote:
> [JDK-8247872](https://bugs.openjdk.java.net/browse/JDK-8247872) (upgrade
> HarfBuzz to 2.7.2) caused build time to go up with 24 seconds on my reference
> linux machine. This was one of the four culprits that caused a 25-30% build
>
The version output of GNU time changed from "GNU time" to "GNU Time" in version
1.8. We need to update our check for identifying GNU time to handle this.
-
Commit messages:
- JDK-8283575
Changes: https://git.openjdk.java.net/jdk/pull/7925/files
Webrev: https://webrevs.openjdk.java
> This PR contains the API and implementation changes for JEP-424 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.java.net/jeps/424
Maurizio Cimadamore has updated the pull request
On Wed, 23 Mar 2022 12:25:08 GMT, Magnus Ihse Bursie wrote:
> [JDK-8247872](https://bugs.openjdk.java.net/browse/JDK-8247872) (upgrade
> HarfBuzz to 2.7.2) caused build time to go up with 24 seconds on my reference
> linux machine. This was one of the four culprits that caused a 25-30% build
>
[JDK-8247872](https://bugs.openjdk.java.net/browse/JDK-8247872) (upgrade
HarfBuzz to 2.7.2) caused build time to go up with 24 seconds on my reference
linux machine. This was one of the four culprits that caused a 25-30% build
time regression over the last two years.
The problem here was that t
On Wed, 23 Mar 2022 02:03:26 GMT, Fei Yang wrote:
>> This PR implements JEP 422: Linux/RISC-V Port [1].
>> The PR starts as a squashed merge of the
>> https://openjdk.java.net/projects/riscv-port branch.
>>
>> This has been tested with jtreg tier{1,2,3,4} and jcstress on HiFive
>> Unmatched bo
On Wed, 23 Mar 2022 02:03:26 GMT, Fei Yang wrote:
>> This PR implements JEP 422: Linux/RISC-V Port [1].
>> The PR starts as a squashed merge of the
>> https://openjdk.java.net/projects/riscv-port branch.
>>
>> This has been tested with jtreg tier{1,2,3,4} and jcstress on HiFive
>> Unmatched bo
On Tue, 22 Mar 2022 17:34:18 GMT, Vladimir Kozlov wrote:
>> Fei Yang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Address review comments
>
> src/hotspot/cpu/riscv/disassembler_riscv.hpp line 18:
>
>> 16: *
>> 17: * You should have
On Wed, 23 Mar 2022 01:57:25 GMT, Fei Yang wrote:
>> src/hotspot/cpu/riscv/disassembler_riscv.hpp line 18:
>>
>>> 16: *
>>> 17: * You should have received a copy of the GNU General Public License
>>> version
>>> 18: * 2 along with this work; if not, write to the Free Software
>>> Foundation
On Tue, 22 Mar 2022 14:01:28 GMT, Roger Riggs wrote:
> The test/jdk files look ok. (I didn't look at the rest)
Thank you for looking at that part.
-
PR: https://git.openjdk.java.net/jdk/pull/6294
> This PR implements JEP 422: Linux/RISC-V Port [1].
> The PR starts as a squashed merge of the
> https://openjdk.java.net/projects/riscv-port branch.
>
> This has been tested with jtreg tier{1,2,3,4} and jcstress on HiFive
> Unmatched board. Dacapo, SPECjbb2015 and SPECjvm2008 benchmark tests a
On Tue, 22 Mar 2022 19:07:12 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-424 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] - https://openjd
On Tue, 22 Mar 2022 18:53:20 GMT, Phil Race wrote:
> Disable a warning from the Xcode 13.3 clang compiler when compiling libpng,
> which is used by libsplashscreen.
>
> Policy is not to change the upstream code locally unless it is also changed
> in the same way upstream.
> We could consider r
On Tue, 22 Mar 2022 15:20:38 GMT, Daniel Jeliński wrote:
> Sample output after the changes:
>
> [Stub Code]
> 0x01cd0a937e20: nopl (%rax, %rax); {no_reloc}
> 0x01cd0a937e25: movabsq $0x0, %rbx ;
> {static_stub}
> 0x01cd0a937e2f:
> This PR contains the API and implementation changes for JEP-424 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.java.net/jeps/424
Maurizio Cimadamore has updated the pull request
Disable a warning from the Xcode 13.3 clang compiler when compiling libpng,
which is used by libsplashscreen.
Policy is not to change the upstream code locally unless it is also changed in
the same way upstream.
We could consider reporting it upstream but libpng releases are very infrequent.
--
On Tue, 22 Mar 2022 11:50:13 GMT, Fei Yang wrote:
>> This PR implements JEP 422: Linux/RISC-V Port [1].
>> The PR starts as a squashed merge of the
>> https://openjdk.java.net/projects/riscv-port branch.
>>
>> This has been tested with jtreg tier{1,2,3,4} and jcstress on HiFive
>> Unmatched bo
On Tue, 22 Mar 2022 11:50:13 GMT, Fei Yang wrote:
>> This PR implements JEP 422: Linux/RISC-V Port [1].
>> The PR starts as a squashed merge of the
>> https://openjdk.java.net/projects/riscv-port branch.
>>
>> This has been tested with jtreg tier{1,2,3,4} and jcstress on HiFive
>> Unmatched bo
On Tue, 22 Mar 2022 14:04:07 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-424 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] - https://openjd
Sample output after the changes:
[Stub Code]
0x01cd0a937e20: nopl(%rax, %rax); {no_reloc}
0x01cd0a937e25: movabsq $0x0, %rbx ; {static_stub}
0x01cd0a937e2f: jmp 0x1cd0a937e2f ; {runtime_call}
[Exception Handler]
> This PR contains the API and implementation changes for JEP-424 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.java.net/jeps/424
Maurizio Cimadamore has updated the pull request
On Tue, 22 Mar 2022 11:50:13 GMT, Fei Yang wrote:
>> This PR implements JEP 422: Linux/RISC-V Port [1].
>> The PR starts as a squashed merge of the
>> https://openjdk.java.net/projects/riscv-port branch.
>>
>> This has been tested with jtreg tier{1,2,3,4} and jcstress on HiFive
>> Unmatched bo
On Mon, 21 Mar 2022 17:36:53 GMT, Maurizio Cimadamore
wrote:
>> make/modules/java.base/Lib.gmk line 217:
>>
>>> 215: CXXFLAGS := $(CXXFLAGS_JDKLIB), \
>>> 216: LDFLAGS := $(LDFLAGS_JDKLIB) -Wl$(COMMA)--no-as-needed, \
>>> 217: LIBS := $(LIBCXX) -lc -lm -ldl, \
>>
>> Instead o
On Tue, 22 Mar 2022 12:08:01 GMT, Fei Yang wrote:
>> make/autoconf/libraries.m4 line 152:
>>
>>> 150: fi
>>> 151:
>>> 152: # Programs which use C11 or C++11 atomics, like #include ,
>>
>> Use of C++ atomics is not allowed in hotspot code base. See the style guide:
>> https://github.com/ope
On Tue, 22 Mar 2022 11:50:13 GMT, Fei Yang wrote:
>> This PR implements JEP 422: Linux/RISC-V Port [1].
>> The PR starts as a squashed merge of the
>> https://openjdk.java.net/projects/riscv-port branch.
>>
>> This has been tested with jtreg tier{1,2,3,4} and jcstress on HiFive
>> Unmatched bo
On Tue, 22 Mar 2022 04:13:17 GMT, David Holmes wrote:
>> Fei Yang has updated the pull request with a new target base due to a merge
>> or a rebase. The incremental webrev excludes the unrelated changes brought
>> in by the merge/rebase. The pull request contains two additional commits
>> sinc
701 - 800 of 5319 matches
Mail list logo
