Re: JDK9: RFR: 8019470: Changes needed to compile JDK8 on MacOS with clang compiler

2014-03-06 Thread Henry Jen
I cannot find doc regarding to -fPIC in clang, thus I leave it empty after googled a little bit. There is a code generation option for lli, -relocation-model=pic, which seems to be default for clang[1]. [1] http://clang.llvm.org/doxygen/CodeGenOptions_8h_source.html Cheers, Henry On 03/06/2

Re: JDK9: RFR: 8019470: Changes needed to compile JDK8 on MacOS with clang compiler

2014-03-06 Thread Magnus Ihse Bursie
Looks good to me. Just one question, since clang otherwise duplicates the gcc flags: is it correct to drop -fPIC in clang? /Magnus > On 6 mar 2014, at 09:36, Erik Joelsson wrote: > > Hello, > > I was waiting for Magnus to look at this since he is more involved in this > code at the moment. I

Re: JDK9: RFR: 8019470: Changes needed to compile JDK8 on MacOS with clang compiler

2014-03-06 Thread Erik Joelsson
Hello, I was waiting for Magnus to look at this since he is more involved in this code at the moment. I think it looks good ok, but would prefer if he got the chance to look at it too. /Erik On 2014-03-06 01:11, Henry Jen wrote: Ping! Is three any concern on this patch? I got JPRT reports no

Re: JDK9: RFR: 8019470: Changes needed to compile JDK8 on MacOS with clang compiler

2014-03-05 Thread Henry Jen
Ping! Is three any concern on this patch? I got JPRT reports no problem and other reports success. I hope we can get this in as early as we can because build is evloving quickly, and I think it only can get better after pushed for more tests. Cheers, Henry On 02/26/2014 12:23 AM, Henry Jen w

JDK9: RFR: 8019470: Changes needed to compile JDK8 on MacOS with clang compiler

2014-02-26 Thread Henry Jen
Hi, Please review a webrev to enable XCode5 build on Mac OS X, this webrev add basic clang flags and detect Xcode version to set default toolchain to clang for Xcode5 and after, otherwise set to gcc for Mac OS X. http://cr.openjdk.java.net/~henryjen/jdk9/8019470/1/webrev/ This patch build on

Re: RFR: 8019470 "Changes needed to compile JDK8 on MacOS with clang compiler"

2013-08-13 Thread Christian Thalinger
On Aug 13, 2013, at 3:00 PM, Tim Bell wrote: > I wrote: > >> Thanks in advance - we would like to get these changes checked in this week. > > Let me clarify this a bit - there are some bugs open against the MacOS/clang > hotspot build that need to be resolved before considering a change-over

Re: RFR: 8019470 "Changes needed to compile JDK8 on MacOS with clang compiler"

2013-08-13 Thread Tim Bell
I wrote: Thanks in advance - we would like to get these changes checked in this week. Let me clarify this a bit - there are some bugs open against the MacOS/clang hotspot build that need to be resolved before considering a change-over to clang: http://bugs.sun.com/view_bug.do?bug_id=80219

Re: RFR: 8019470 "Changes needed to compile JDK8 on MacOS with clang compiler"

2013-08-13 Thread Tim Bell
On 07/24/13 09:44 PM, David Holmes wrote: On 25/07/2013 8:48 AM, Tim Bell wrote: Christian: That's not true. I've added Mac OS X support with the same change. For building hotspot only, perhaps. I want to build the entire product, start to finish, using clang. That's why I needed to touch

Re: RFR: 8019470 "Changes needed to compile JDK8 on MacOS with clang compiler"

2013-07-24 Thread David Holmes
On 25/07/2013 8:48 AM, Tim Bell wrote: Christian: That's not true. I've added Mac OS X support with the same change. For building hotspot only, perhaps. I want to build the entire product, start to finish, using clang. That's why I needed to touch these files: common/autoconf/hotspot-spec

Re: RFR: 8019470 "Changes needed to compile JDK8 on MacOS with clang compiler"

2013-07-24 Thread Tim Bell
Christian: That's not true. I've added Mac OS X support with the same change. For building hotspot only, perhaps. I want to build the entire product, start to finish, using clang. That's why I needed to touch these files: common/autoconf/hotspot-spec.gmk.in common/autoconf/toolchain.m4 m

Re: RFR: 8019470 "Changes needed to compile JDK8 on MacOS with clang compiler"

2013-07-24 Thread Christian Thalinger
On Jul 24, 2013, at 5:15 AM, Tim Bell wrote: > On 07/24/13 04:43 AM, David Holmes wrote: >> Hi Tim, >> >> On 24/07/2013 8:15 AM, Tim Bell wrote: >>> Hello everyone- >>> >>> This is a small set of changes to switch from gcc to clang when building >> >> So we already added support for clang as

Re: RFR: 8019470 "Changes needed to compile JDK8 on MacOS with clang compiler"

2013-07-24 Thread Leonid Romanov
On Jul 24, 2013, at 5:12 PM, David Chase wrote: > > On 2013-07-23, at 7:38 PM, Tim Bell wrote: > >> Hello Leonid: >> >>> Just to satisfy my curiosity: what are advantages of using clang instead of >>> gcc? >> >> I am a mere messenger here, but I am told that clang/clang++: >> >> - is comm

Re: RFR: 8019470 "Changes needed to compile JDK8 on MacOS with clang compiler"

2013-07-24 Thread David Chase
On 2013-07-23, at 7:38 PM, Tim Bell wrote: > Hello Leonid: > >> Just to satisfy my curiosity: what are advantages of using clang instead of >> gcc? > > I am a mere messenger here, but I am told that clang/clang++: > > - is command line compatible with gcc > - is faster > - produces better di

Re: RFR: 8019470 "Changes needed to compile JDK8 on MacOS with clang compiler"

2013-07-24 Thread Tim Bell
On 07/24/13 04:43 AM, David Holmes wrote: Hi Tim, On 24/07/2013 8:15 AM, Tim Bell wrote: Hello everyone- This is a small set of changes to switch from gcc to clang when building So we already added support for clang as the compiler for hotspot - is this just extending things to allow config

Re: RFR: 8019470 "Changes needed to compile JDK8 on MacOS with clang compiler"

2013-07-24 Thread David Holmes
Hi Tim, On 24/07/2013 8:15 AM, Tim Bell wrote: Hello everyone- This is a small set of changes to switch from gcc to clang when building So we already added support for clang as the compiler for hotspot - is this just extending things to allow configure to select clang? on MacOS, and also

Re: RFR: 8019470 "Changes needed to compile JDK8 on MacOS with clang compiler"

2013-07-23 Thread Helio Frota
Hi great all, I found this article: http://www.phoronix.com/scan.php?page=article&item=llvm_clang33_3way&num=2 http://www.phoronix.com/scan.php?page=article&item=llvm_clang33_3way&num=3 http://www.phoronix.com/scan.php?page=article&item=llvm_clang33_3way&num=4 And GCC wins all on performance issu

Re: RFR: 8019470 "Changes needed to compile JDK8 on MacOS with clang compiler"

2013-07-23 Thread David Katleman
In toolchain.m4 267 elif test "x$OPENJDK_TARGET_OS" = "xmacosx"; then 268 COMPILER_CHECK_LIST="clang gcc cc" Aren't clang & cc the same? (/usr/bin/cc -> clang) Or are there instances of macosx that do not have the symlink? That's the only question I could find. Pretty simple change.

Re: RFR: 8019470 "Changes needed to compile JDK8 on MacOS with clang compiler"

2013-07-23 Thread Tim Bell
Hello Leonid: Just to satisfy my curiosity: what are advantages of using clang instead of gcc? I am a mere messenger here, but I am told that clang/clang++: - is command line compatible with gcc - is faster - produces better diagnostic messages - clang on MacOS is under active development whi

Re: RFR: 8019470 "Changes needed to compile JDK8 on MacOS with clang compiler"

2013-07-23 Thread Mike Duigou
Nice work! toolchain.m4:: - Wouldn't COMPILER_NAME=clang now be dependent upon which compiler is used? - It also seems to require that gcc still be present for the containing conditional; 509 if test "x$GCC" = xyes; then Mike On Jul 23 2013, at 15:15 , Tim Bell wrote: > Hello everyone- > >

Re: RFR: 8019470 "Changes needed to compile JDK8 on MacOS with clang compiler"

2013-07-23 Thread Leonid Romanov
Just to satisfy my curiosity: what are advantages of using clang instead of gcc? On Jul 24, 2013, at 2:15 AM, Tim Bell wrote: > Hello everyone- > > This is a small set of changes to switch from gcc to clang when building on > MacOS, and also enable building on MacOS 8.x > > Here is the bug

RFR: 8019470 "Changes needed to compile JDK8 on MacOS with clang compiler"

2013-07-23 Thread Tim Bell
Hello everyone- This is a small set of changes to switch from gcc to clang when building on MacOS, and also enable building on MacOS 8.x Here is the bug report: http://bugs.sun.com/view_bug.do?bug_id=8019470 Here are the webrevs: Hotspot only: http://cr.openjdk.java.net/~tbell/8019470/ho