Re: RFR: 8023216: Feedback on README-builds.html

2013-08-21 Thread Tim Bell
Looks good to me as well. Tim On 08/21/13 05:55 AM, Dalibor Topic wrote: Nice, thanks. On 8/21/13 2:53 PM, Erik Joelsson wrote: Thanks, updated webrev: http://cr.openjdk.java.net/~erikj/8023216/webrev.root.02/ /Erik On 2013-08-19 16:38, Dalibor Topic wrote: On 8/19/13 2:43 PM, Erik Joelss

Re: RFR: 8023216: Feedback on README-builds.html

2013-08-21 Thread Dalibor Topic
Nice, thanks. On 8/21/13 2:53 PM, Erik Joelsson wrote: > Thanks, updated webrev: > > http://cr.openjdk.java.net/~erikj/8023216/webrev.root.02/ > > /Erik > > On 2013-08-19 16:38, Dalibor Topic wrote: >> On 8/19/13 2:43 PM, Erik Joelsson wrote: >>> And again, here we go: >>> >>> http://cr.openjdk

Re: RFR: 8023216: Feedback on README-builds.html

2013-08-21 Thread Erik Joelsson
Thanks, updated webrev: http://cr.openjdk.java.net/~erikj/8023216/webrev.root.02/ /Erik On 2013-08-19 16:38, Dalibor Topic wrote: On 8/19/13 2:43 PM, Erik Joelsson wrote: And again, here we go: http://cr.openjdk.java.net/~erikj/8023216/webrev.root.01/ A few typos: javascript -> JavaScript

Re: RFR: 8023216: Feedback on README-builds.html

2013-08-19 Thread Dalibor Topic
On 8/19/13 2:43 PM, Erik Joelsson wrote: > And again, here we go: > > http://cr.openjdk.java.net/~erikj/8023216/webrev.root.01/ A few typos: javascript -> JavaScript sourses -> sources cheers, dalibor topic > > /Erik > > On 2013-08-19 11:05, Erik Joelsson wrote: >> Thanks for the feedback!

Re: RFR: 8023216: Feedback on README-builds.html

2013-08-19 Thread Anthony Petrov
Hi Erik, The fix looks fine to me. -- best regards, Anthony On 08/19/13 16:43, Erik Joelsson wrote: And again, here we go: http://cr.openjdk.java.net/~erikj/8023216/webrev.root.01/ /Erik On 2013-08-19 11:05, Erik Joelsson wrote: Thanks for the feedback! I took most of it and made into a c

Re: RFR: 8023216: Feedback on README-builds.html

2013-08-19 Thread Erik Joelsson
And again, here we go: http://cr.openjdk.java.net/~erikj/8023216/webrev.root.01/ /Erik On 2013-08-19 11:05, Erik Joelsson wrote: Thanks for the feedback! I took most of it and made into a change. Also removed some obsolete parts that I stumbled over. Warn is supposed to be quiet, but at le

RFR: 8023216: Feedback on README-builds.html

2013-08-19 Thread Erik Joelsson
Thanks for the feedback! I took most of it and made into a change. Also removed some obsolete parts that I stumbled over. Warn is supposed to be quiet, but at least hotspot is still being quite noisy. /Erik On 2013-08-06 01:18, Dan Smith wrote: I'm building for the first time under the ne