Re: RFR: 8173607: JMX RMI connector should be in its own module

2017-02-02 Thread Mandy Chung
> On Feb 2, 2017, at 4:37 AM, Daniel Fuchs wrote: > > Hi Mandy, > > On 02/02/17 02:41, Mandy Chung wrote: >>> http://cr.openjdk.java.net/~dfuchs/webrev_8173607/webrev.06 >> >> Does java.management still depend on java.base/jdk.internal.module? > > Well spotted! It doesn't. I have updated modu

Re: RFR: 8173607: JMX RMI connector should be in its own module

2017-02-02 Thread Daniel Fuchs
Hi Mandy, On 02/02/17 02:41, Mandy Chung wrote: http://cr.openjdk.java.net/~dfuchs/webrev_8173607/webrev.06 Does java.management still depend on java.base/jdk.internal.module? Well spotted! It doesn't. I have updated module-info.java for java.base. http://cr.openjdk.java.net/~dfuchs/webrev_

Re: RFR: 8173607: JMX RMI connector should be in its own module

2017-02-01 Thread Mandy Chung
> On Feb 1, 2017, at 7:29 AM, Daniel Fuchs wrote: > > Here is the updated webrev, rebased after pulling JDK-8173608, and with > your feedback below integrated. > > I am pleased to report that java.management no longer requires > java.rmi or java.naming :-) > This is great! > Compared to prev

Re: RFR: 8173607: JMX RMI connector should be in its own module

2017-02-01 Thread Daniel Fuchs
Hi Mandy, On 01/02/17 05:11, Mandy Chung wrote: On Jan 31, 2017, at 10:26 AM, Daniel Fuchs wrote: Hi, Please find below a patch for: 8173607: JMX RMI connector should be in its own module https://bugs.openjdk.java.net/browse/JDK-8173607 webrev: http://cr.openjdk.java.net/~dfuchs/webrev_81

Re: RFR: 8173607: JMX RMI connector should be in its own module

2017-02-01 Thread Erik Joelsson
Build changes look ok. /Erik On 2017-01-31 19:26, Daniel Fuchs wrote: Hi, Please find below a patch for: 8173607: JMX RMI connector should be in its own module https://bugs.openjdk.java.net/browse/JDK-8173607 webrev: http://cr.openjdk.java.net/~dfuchs/webrev_8173607/webrev.05 This patch ma

Re: RFR: 8173607: JMX RMI connector should be in its own module

2017-01-31 Thread Mandy Chung
> On Jan 31, 2017, at 10:26 AM, Daniel Fuchs wrote: > > Hi, > > Please find below a patch for: > > 8173607: JMX RMI connector should be in its own module > https://bugs.openjdk.java.net/browse/JDK-8173607 > > webrev: > http://cr.openjdk.java.net/~dfuchs/webrev_8173607/webrev.05 > This mostl

RFR: 8173607: JMX RMI connector should be in its own module

2017-01-31 Thread Daniel Fuchs
Hi, Please find below a patch for: 8173607: JMX RMI connector should be in its own module https://bugs.openjdk.java.net/browse/JDK-8173607 webrev: http://cr.openjdk.java.net/~dfuchs/webrev_8173607/webrev.05 This patch makes it possible to remove the requires transitive java.rmi from the java.m