On 02/11/2020 18:37, Bernhard Urban-Forster wrote:
> @theRealAph what gcc version?
>
> I can reproduce with
> $ gcc --version
> gcc (Ubuntu 9.2.1-9ubuntu2) 9.2.1 20191008
> which ships in Ubuntu 19.10 as default
My mistake: I think it only triggers with a debug build, because assert
is a macro.
On Mon, 2 Nov 2020 17:43:31 GMT, Andrew Haley wrote:
>> https://github.com/openjdk/jdk/pull/1013
>
>> @lewurm
>> This patch seems to break on linux-aarch64 with gcc:
>
> Builds cleanly on Linux/GCC or me.
@theRealAph what gcc version?
I can reproduce with
$ gcc --version
gcc (Ubuntu
On Mon, 2 Nov 2020 17:05:19 GMT, Bernhard Urban-Forster
wrote:
>> @lewurm Open a new JBS issue with the bug. If you can find a fix in a short
>> amount of time (which I would believe should be possible; probably just need
>> a proper cast) it's acceptable to fix it directly. What amounts to a
On Mon, 2 Nov 2020 16:16:25 GMT, Magnus Ihse Bursie wrote:
>> @magicus I did test the initial version of this PR on linux+arm64, but not
>> the latest iteration. sorry about that
>>
>> What is the policy here? Submit a revert right away or investigate a fix?
>
> @lewurm Open a new JBS issue
On Mon, 2 Nov 2020 16:06:15 GMT, Bernhard Urban-Forster
wrote:
>> @lewurm
>> This patch seems to break on linux-aarch64 with gcc:
>> open/src/hotspot/cpu/aarch64/sharedRuntime_aarch64.cpp:1501:52: error:
>> comparison of integer expressions of different signedness: 'size_t' {aka
>> 'long
On Mon, 2 Nov 2020 15:41:06 GMT, Magnus Ihse Bursie wrote:
>> Thank you Andrew.
>
> @lewurm
> This patch seems to break on linux-aarch64 with gcc:
> open/src/hotspot/cpu/aarch64/sharedRuntime_aarch64.cpp:1501:52: error:
> comparison of integer expressions of different signedness: 'size_t' {aka
On Mon, 2 Nov 2020 14:00:33 GMT, Bernhard Urban-Forster
wrote:
>>> Would you mind to sponsor it @theRealAph or @magicus?
>>
>> Hmm, I think you have to integrate it first.
>> https://wiki.openjdk.java.net/display/SKARA/Pull+Request+Commands#PullRequestCommands-/sponsor
>
> Thank you Andrew.
On Mon, 2 Nov 2020 13:41:53 GMT, Andrew Haley wrote:
>> Marked as reviewed by aph (Reviewer).
>
>> Would you mind to sponsor it @theRealAph or @magicus?
>
> Hmm, I think you have to integrate it first.
>
On Tue, 27 Oct 2020 14:04:04 GMT, Andrew Haley wrote:
>> Bernhard Urban-Forster has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - uppercase suffix
>> - add assert
>
> Marked as reviewed by aph (Reviewer).
> Would you mind to sponsor
On Tue, 27 Oct 2020 14:04:04 GMT, Andrew Haley wrote:
>> Bernhard Urban-Forster has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - uppercase suffix
>> - add assert
>
> Marked as reviewed by aph (Reviewer).
Would you mind sponsor it
On Tue, 27 Oct 2020 14:04:04 GMT, Andrew Haley wrote:
>> Bernhard Urban-Forster has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - uppercase suffix
>> - add assert
>
> Marked as reviewed by aph (Reviewer).
Thank you for the reviews,
On Thu, 15 Oct 2020 18:35:30 GMT, Bernhard Urban-Forster
wrote:
>> I organized this PR so that each commit contains the warning emitted by MSVC
>> as commit message and its relevant fix.
>>
>> Verified on
>> * Linux+ARM64: `{hotspot,jdk,langtools}:tier1`, no failures.
>> * Windows+ARM64:
On Sun, 18 Oct 2020 09:07:17 GMT, Magnus Ihse Bursie wrote:
>> Bernhard Urban-Forster has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - uppercase suffix
>> - add assert
>
> Build changes look fine now.
@theRealAph does the PR look
On Thu, 15 Oct 2020 18:35:30 GMT, Bernhard Urban-Forster
wrote:
>> I organized this PR so that each commit contains the warning emitted by MSVC
>> as commit message and its relevant fix.
>>
>> Verified on
>> * Linux+ARM64: `{hotspot,jdk,langtools}:tier1`, no failures.
>> * Windows+ARM64:
On Thu, 15 Oct 2020 17:24:56 GMT, Stuart Monteith wrote:
>> Bernhard Urban-Forster has updated the pull request with a new target base
>> due to a merge or a rebase. The pull request
>> now contains 20 commits:
>> - disable warning only for hotspot
>> - Merge remote-tracking branch
On Thu, 15 Oct 2020 09:57:14 GMT, Andrew Haley wrote:
> Fine, but please assert JavaThread::stack_shadow_zone_size() ==
> (int)JavaThread::stack_shadow_zone_size().
Done.
> Adding casts to shut up compilers is a very risky business, because often (if
> not in this case) the programmer
> I organized this PR so that each commit contains the warning emitted by MSVC
> as commit message and its relevant fix.
>
> Verified on
> * Linux+ARM64: `{hotspot,jdk,langtools}:tier1`, no failures.
> * Windows+ARM64: `{hotspot,jdk,langtools}:tier1`, no (new) failures.
> * internal macOS+ARM64
On Thu, 15 Oct 2020 08:57:27 GMT, Bernhard Urban-Forster
wrote:
>> I organized this PR so that each commit contains the warning emitted by MSVC
>> as commit message and its relevant fix.
>>
>> Verified on
>> * Linux+ARM64: `{hotspot,jdk,langtools}:tier1`, no failures.
>> * Windows+ARM64:
On Thu, 15 Oct 2020 09:02:35 GMT, Bernhard Urban-Forster
wrote:
>> Changes requested by ihse (Reviewer).
>
> @theRealAph I prototyped changing the argument of `bang_stack_with_offset()`
> from `int` to `size_t` here:
>
On Mon, 12 Oct 2020 10:29:23 GMT, Magnus Ihse Bursie wrote:
>> Bernhard Urban-Forster has updated the pull request with a new target base
>> due to a merge or a rebase. The pull request
>> now contains 18 commits:
>> - Merge remote-tracking branch 'upstream/master' into
>>
On Mon, 12 Oct 2020 10:29:11 GMT, Magnus Ihse Bursie wrote:
>> Bernhard Urban-Forster has updated the pull request with a new target base
>> due to a merge or a rebase. The pull request
>> now contains 18 commits:
>> - Merge remote-tracking branch 'upstream/master' into
>>
> I organized this PR so that each commit contains the warning emitted by MSVC
> as commit message and its relevant fix.
>
> Verified on
> * Linux+ARM64: `{hotspot,jdk,langtools}:tier1`, no failures.
> * Windows+ARM64: `{hotspot,jdk,langtools}:tier1`, no (new) failures.
> * internal macOS+ARM64
On Thu, 8 Oct 2020 20:28:33 GMT, Bernhard Urban-Forster
wrote:
>> I organized this PR so that each commit contains the warning emitted by MSVC
>> as commit message and its relevant fix.
>>
>> Verified on
>> * Linux+ARM64: `{hotspot,jdk,langtools}:tier1`, no failures.
>> * Windows+ARM64:
On 08/10/2020 21:28, Bernhard Urban-Forster wrote:
> On Tue, 6 Oct 2020 18:09:05 GMT, Bernhard Urban-Forster
> wrote:
>
>> I organized this PR so that each commit contains the warning emitted by MSVC
>> as commit message and its relevant fix.
>>
>> Verified on
>> * Linux+ARM64:
> I organized this PR so that each commit contains the warning emitted by MSVC
> as commit message and its relevant fix.
>
> Verified on
> * Linux+ARM64: `{hotspot,jdk,langtools}:tier1`, no failures.
> * Windows+ARM64: `{hotspot,jdk,langtools}:tier1`, no (new) failures.
> * internal macOS+ARM64
On Tue, 6 Oct 2020 18:09:05 GMT, Bernhard Urban-Forster
wrote:
> I organized this PR so that each commit contains the warning emitted by MSVC
> as commit message and its relevant fix.
>
> Verified on
> * Linux+ARM64: `{hotspot,jdk,langtools}:tier1`, no failures.
> * Windows+ARM64:
26 matches
Mail list logo
