On Tue, 5 Jan 2021 03:44:10 GMT, Hao Sun
wrote:
>> 1. '-Wdeprecated-copy'
>> As specified in C++11 [1], "the generation of the implicitly-defined
>> copy constructor is deprecated if T has a user-defined destructor or
>> user-defined copy assignment operator". The rationale behind is the
>> well
On Mon, 4 Jan 2021 19:33:45 GMT, Xin Liu wrote:
>>> _Mailing list message from [Kim Barrett](mailto:kim.barr...@oracle.com) on
>>> [build-dev](mailto:build-dev@openjdk.java.net):_
>>>
>>> > On Dec 29, 2020, at 10:33 PM, Hao Sun >> > openjdk.java.net> wrote:
>>> > > _Mailing list message from [K
> 1. '-Wdeprecated-copy'
> As specified in C++11 [1], "the generation of the implicitly-defined
> copy constructor is deprecated if T has a user-defined destructor or
> user-defined copy assignment operator". The rationale behind is the
> well-known Rule of Three [2].
>
> Introduced since gcc-9 [3
On Mon, 4 Jan 2021 04:31:02 GMT, Hao Sun
wrote:
>>> _Mailing list message from [Kim Barrett](mailto:kim.barr...@oracle.com) on
>>> [build-dev](mailto:build-dev@openjdk.java.net):_
>>>
>>> > On Dec 24, 2020, at 3:44 PM, Xin Liu wrote:
>>> > On Thu, 24 Dec 2020 17:27:39 GMT, Kim Barrett
>>> >
On Mon, 4 Jan 2021 09:41:01 GMT, Kim Barrett wrote:
>> I suppose the constructor would be invoked before the copy assignment
>> operator. That is `_vdui` gets initialized already in the ctor
>> `DUIterator_Fast()` for `operator=` case. Right?
>> Take the following code snippet as an example.
>>
On Mon, 4 Jan 2021 06:59:54 GMT, Hao Sun
wrote:
>> src/hotspot/share/opto/node.hpp line 1396:
>>
>>> 1394:
>>> 1395: DUIterator_Fast(const DUIterator_Fast& that)
>>> 1396: { _outp = that._outp; debug_only(reset(that)); }
>>
>> `reset` tests `_vdui`, but nothing here has se
On Mon, 4 Jan 2021 06:22:46 GMT, Kim Barrett wrote:
>> Hao Sun has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove the unused assignment operator for DUIterator_Last
>>
>> Instead of adding the copy constructor, remove the assign
> On Jan 3, 2021, at 11:33 PM, Hao Sun
> wrote:
>
> On Mon, 4 Jan 2021 01:18:47 GMT, Hao Sun
> wrote:
>
_Mailing list message from [Kim Barrett](mailto:kim.barr...@oracle.com) on
[build-dev](mailto:build-dev@openjdk.java.net):_
>>
>> It appears that either clang is different from
On Mon, 28 Dec 2020 10:28:09 GMT, Hao Sun
wrote:
>> 1. '-Wdeprecated-copy'
>> As specified in C++11 [1], "the generation of the implicitly-defined
>> copy constructor is deprecated if T has a user-defined destructor or
>> user-defined copy assignment operator". The rationale behind is the
>> wel
On Mon, 4 Jan 2021 01:18:47 GMT, Hao Sun
wrote:
>>> _Mailing list message from [Kim Barrett](mailto:kim.barr...@oracle.com) on
>>> [build-dev](mailto:build-dev@openjdk.java.net):_
>>>
>>> > On Dec 22, 2020, at 8:52 PM, Hao Sun >> > openjdk.java.net> wrote:
>>> > 1. '-Wdeprecated-copy'
>>> > As
On Wed, 30 Dec 2020 03:31:38 GMT, Hao Sun
wrote:
>> LGTM. It still needs other's approval.
>
>> _Mailing list message from [Kim Barrett](mailto:kim.barr...@oracle.com) on
>> [build-dev](mailto:build-dev@openjdk.java.net):_
>>
>> > On Dec 22, 2020, at 8:52 PM, Hao Sun > > openjdk.java.net> wrot
> On Jan 2, 2021, at 11:17 PM, Kim Barrett wrote:
>
>> On Dec 29, 2020, at 10:33 PM, Hao Sun
>> wrote:
>>
>>> _Mailing list message from [Kim Barrett](mailto:kim.barr...@oracle.com) on
>>> [build-dev](mailto:build-dev@openjdk.java.net):_
>>> But I discovered something alarming while experimen
> On Dec 29, 2020, at 10:33 PM, Hao Sun
> wrote:
>
>> _Mailing list message from [Kim Barrett](mailto:kim.barr...@oracle.com) on
>> [build-dev](mailto:build-dev@openjdk.java.net):_
>>
>>
>> C++17 "guaranteed copy elision" is implemented in gcc7.
>> http://www.open-std.org/jtc1/sc22/wg21/docs/
> On Dec 24, 2020, at 3:44 PM, Xin Liu wrote:
>
> On Thu, 24 Dec 2020 17:27:39 GMT, Kim Barrett wrote:
>> […]
>> Since DUIterator_Last is just delegating both the copy constructor and
>> assignment operator to the base class, their copy constructor and
>> assignment operator would be better as t
On Mon, 28 Dec 2020 19:23:34 GMT, Xin Liu wrote:
>> Hao Sun has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove the unused assignment operator for DUIterator_Last
>>
>> Instead of adding the copy constructor, remove the assignmen
On Mon, 28 Dec 2020 10:28:09 GMT, Hao Sun
wrote:
>> 1. '-Wdeprecated-copy'
>> As specified in C++11 [1], "the generation of the implicitly-defined
>> copy constructor is deprecated if T has a user-defined destructor or
>> user-defined copy assignment operator". The rationale behind is the
>> wel
> 1. '-Wdeprecated-copy'
> As specified in C++11 [1], "the generation of the implicitly-defined
> copy constructor is deprecated if T has a user-defined destructor or
> user-defined copy assignment operator". The rationale behind is the
> well-known Rule of Three [2].
>
> Introduced since gcc-9 [3
On Thu, 24 Dec 2020 13:27:33 GMT, Kim Barrett wrote:
> I think the two issues described here are distinct and should be dealt
> with in separate bugs and PRs. Their only relation is that both arise
> with using clang-10. But they are very different problems, in very
> different parts of the code,
On Thu, 24 Dec 2020 20:42:01 GMT, Xin Liu wrote:
>> src/hotspot/share/opto/node.hpp line 1458:
>>
>>> 1456: // initialize to garbage
>>> 1457:
>>> 1458: DUIterator_Last (const DUIterator_Last& that) :
>>> DUIterator_Fast(that) {}
>>
>> Since DUIterator_Last is just delegating both the cop
On Thu, 24 Dec 2020 17:27:39 GMT, Kim Barrett wrote:
>> 1. '-Wdeprecated-copy'
>> As specified in C++11 [1], "the generation of the implicitly-defined
>> copy constructor is deprecated if T has a user-defined destructor or
>> user-defined copy assignment operator". The rationale behind is the
>>
> On Dec 22, 2020, at 8:52 PM, Hao Sun
> wrote:
>
> 1. '-Wdeprecated-copy'
> As specified in C++11 [1], "the generation of the implicitly-defined
> copy constructor is deprecated if T has a user-defined destructor or
> user-defined copy assignment operator". The rationale behind is the
> well-kn
On Wed, 23 Dec 2020 01:45:58 GMT, Hao Sun
wrote:
> 1. '-Wdeprecated-copy'
> As specified in C++11 [1], "the generation of the implicitly-defined
> copy constructor is deprecated if T has a user-defined destructor or
> user-defined copy assignment operator". The rationale behind is the
> well-kno
On Wed, 23 Dec 2020 01:45:58 GMT, Hao Sun
wrote:
> 1. '-Wdeprecated-copy'
> As specified in C++11 [1], "the generation of the implicitly-defined
> copy constructor is deprecated if T has a user-defined destructor or
> user-defined copy assignment operator". The rationale behind is the
> well-kno
1. '-Wdeprecated-copy'
As specified in C++11 [1], "the generation of the implicitly-defined
copy constructor is deprecated if T has a user-defined destructor or
user-defined copy assignment operator". The rationale behind is the
well-known Rule of Three [2].
Introduced since gcc-9 [3] and clang-10
24 matches
Mail list logo
