Re: RFR: 8264779: Fix doclint warnings in java/nio [v2]

2021-04-07 Thread Conor Cleary
On Wed, 7 Apr 2021 18:11:43 GMT, Naoto Sato wrote: >> or just "The length of the input" so that it is consistent with the >> description of the getInputLength method. > > That sounds good. Changed to "The length of the input." in the [most recent commit](https://github.com/openjdk/jdk/pull/337

Re: RFR: 8264779: Fix doclint warnings in java/nio [v2]

2021-04-07 Thread Conor Cleary
On Wed, 7 Apr 2021 18:12:20 GMT, Naoto Sato wrote: >> This makes changes to the copyright headers of of the generated source files >> `UnsupportedCharsetException.java` and `IllegalCharsetNameException.java`. >> These can be found under a jdk build in `support/gensrc` and the headers >> update

Re: RFR: 8264779: Fix doclint warnings in java/nio [v2]

2021-04-07 Thread Naoto Sato
On Wed, 7 Apr 2021 18:04:48 GMT, Alan Bateman wrote: >> It could, maybe something like "The length of the input byte (or character) >> sequence." would work? > > or just "The length of the input" so that it is consistent with the > description of the getInputLength method. That sounds good. -

Re: RFR: 8264779: Fix doclint warnings in java/nio [v2]

2021-04-07 Thread Naoto Sato
On Wed, 7 Apr 2021 17:58:58 GMT, Conor Cleary wrote: >> src/java.base/share/classes/java/nio/exceptions line 31: >> >>> 29: PACKAGE=java.nio >>> 30: # This year should only change if the generated source is modified. >>> 31: COPYRIGHT_YEARS="2000, 2021," >> >> Does not seem necessary, as I don'

Re: RFR: 8264779: Fix doclint warnings in java/nio [v2]

2021-04-07 Thread Alan Bateman
On Wed, 7 Apr 2021 14:40:48 GMT, Conor Cleary wrote: >> This fix addresses the following warnings which were generated by building >> JDK API documentation with the `-Xdoclint:all` option enabled: >> >> ./build/linux-x64/support/gensrc/java.base/java/nio/charset/IllegalCharsetNameException.java

Re: RFR: 8264779: Fix doclint warnings in java/nio [v2]

2021-04-07 Thread Alan Bateman
On Wed, 7 Apr 2021 18:01:25 GMT, Conor Cleary wrote: >> src/java.base/share/classes/java/nio/charset/MalformedInputException.java >> line 45: >> >>> 43: >>> 44: /** >>> 45: * The length of the input byte sequence. >> >> Should this comment also refer to the character sequence? > > It

Re: RFR: 8264779: Fix doclint warnings in java/nio [v2]

2021-04-07 Thread Conor Cleary
On Wed, 7 Apr 2021 16:09:22 GMT, Naoto Sato wrote: >> Conor Cleary has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8264779: Simplified comments > > src/java.base/share/classes/java/nio/charset/MalformedInputException.java > line 45: >

Re: RFR: 8264779: Fix doclint warnings in java/nio [v2]

2021-04-07 Thread Naoto Sato
On Wed, 7 Apr 2021 14:40:48 GMT, Conor Cleary wrote: >> This fix addresses the following warnings which were generated by building >> JDK API documentation with the `-Xdoclint:all` option enabled: >> >> ./build/linux-x64/support/gensrc/java.base/java/nio/charset/IllegalCharsetNameException.java

Re: RFR: 8264779: Fix doclint warnings in java/nio [v2]

2021-04-07 Thread Iris Clark
On Wed, 7 Apr 2021 14:40:48 GMT, Conor Cleary wrote: >> This fix addresses the following warnings which were generated by building >> JDK API documentation with the `-Xdoclint:all` option enabled: >> >> ./build/linux-x64/support/gensrc/java.base/java/nio/charset/IllegalCharsetNameException.java

Re: RFR: 8264779: Fix doclint warnings in java/nio [v2]

2021-04-07 Thread Conor Cleary
> This fix addresses the following warnings which were generated by building > JDK API documentation with the `-Xdoclint:all` option enabled: > > ./build/linux-x64/support/gensrc/java.base/java/nio/charset/IllegalCharsetNameException.java:47: > warning: no comment > private String charsetNam