Re: RFR: 8282567: Improve source-date handling in build system [v6]

2022-03-07 Thread Erik Joelsson
On Mon, 7 Mar 2022 17:23:40 GMT, Magnus Ihse Bursie wrote: >> When doing reproducible builds, controlling the build time is imperative. To >> make this as easy as possible, some changes are needed in the build system. >> >> * If source-date is set to anything other than "updated" (meaning that

Re: RFR: 8282567: Improve source-date handling in build system [v5]

2022-03-07 Thread Magnus Ihse Bursie
On Mon, 7 Mar 2022 14:20:04 GMT, Erik Joelsson wrote: >> Magnus Ihse Bursie has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Test for updated, not current > > doc/building.md line 1546: > >> 1544: You must also make sure your build does

Re: RFR: 8282567: Improve source-date handling in build system [v6]

2022-03-07 Thread Magnus Ihse Bursie
> When doing reproducible builds, controlling the build time is imperative. To > make this as easy as possible, some changes are needed in the build system. > > * If source-date is set to anything other than "updated" (meaning that it > should be determined at build time), then the default valu

Re: RFR: 8282567: Improve source-date handling in build system [v5]

2022-03-07 Thread Erik Joelsson
On Sat, 5 Mar 2022 08:57:45 GMT, Magnus Ihse Bursie wrote: >> When doing reproducible builds, controlling the build time is imperative. To >> make this as easy as possible, some changes are needed in the build system. >> >> * If source-date is set to anything other than "updated" (meaning that

Re: RFR: 8282567: Improve source-date handling in build system [v5]

2022-03-07 Thread Severin Gehwolf
On Sat, 5 Mar 2022 08:57:45 GMT, Magnus Ihse Bursie wrote: >> When doing reproducible builds, controlling the build time is imperative. To >> make this as easy as possible, some changes are needed in the build system. >> >> * If source-date is set to anything other than "updated" (meaning that

Re: RFR: 8282567: Improve source-date handling in build system [v4]

2022-03-07 Thread Severin Gehwolf
On Fri, 4 Mar 2022 23:43:12 GMT, Magnus Ihse Bursie wrote: > As for RPM builds (by whom?) We, Red Hat, build OpenJDK in Fedora and RHEL via `rpmbuild` :) > suddenly being build with --enable-reproducible-build, I would not think it > is a matter of concern. For linux, the only real difference

Re: RFR: 8282567: Improve source-date handling in build system [v5]

2022-03-05 Thread Magnus Ihse Bursie
> When doing reproducible builds, controlling the build time is imperative. To > make this as easy as possible, some changes are needed in the build system. > > * If source-date is set to anything other than "updated" (meaning that it > should be determined at build time), then the default valu

Re: RFR: 8282567: Improve source-date handling in build system

2022-03-04 Thread Magnus Ihse Bursie
On Wed, 2 Mar 2022 18:22:29 GMT, Erik Joelsson wrote: >> When doing reproducible builds, controlling the build time is imperative. To >> make this as easy as possible, some changes are needed in the build system. >> >> * If source-date is set to anything other than "updated" (meaning that it

Re: RFR: 8282567: Improve source-date handling in build system [v4]

2022-03-04 Thread Magnus Ihse Bursie
On Fri, 4 Mar 2022 23:33:46 GMT, Magnus Ihse Bursie wrote: >> When doing reproducible builds, controlling the build time is imperative. To >> make this as easy as possible, some changes are needed in the build system. >> >> * If source-date is set to anything other than "updated" (meaning that

Re: RFR: 8282567: Improve source-date handling in build system

2022-03-04 Thread Magnus Ihse Bursie
On Wed, 2 Mar 2022 18:09:58 GMT, Severin Gehwolf wrote: >> To clarify, the end effect of these changes is that building OpenJDK will >> basically be compliant with the method of just setting SOURCE_DATE_EPOCH. >> (The caveat is that it must be set at configure time, not build time.) So >> >> $

Re: RFR: 8282567: Improve source-date handling in build system [v4]

2022-03-04 Thread Magnus Ihse Bursie
> When doing reproducible builds, controlling the build time is imperative. To > make this as easy as possible, some changes are needed in the build system. > > * If source-date is set to anything other than "updated" (meaning that it > should be determined at build time), then the default valu

Re: RFR: 8282567: Improve source-date handling in build system [v3]

2022-03-04 Thread Magnus Ihse Bursie
> When doing reproducible builds, controlling the build time is imperative. To > make this as easy as possible, some changes are needed in the build system. > > * If source-date is set to anything other than "updated" (meaning that it > should be determined at build time), then the default valu

Re: RFR: 8282567: Improve source-date handling in build system [v2]

2022-03-04 Thread Magnus Ihse Bursie
> When doing reproducible builds, controlling the build time is imperative. To > make this as easy as possible, some changes are needed in the build system. > > * If source-date is set to anything other than "updated" (meaning that it > should be determined at build time), then the default valu

Re: RFR: 8282567: Improve source-date handling in build system

2022-03-02 Thread Erik Joelsson
On Wed, 2 Mar 2022 16:52:12 GMT, Magnus Ihse Bursie wrote: > When doing reproducible builds, controlling the build time is imperative. To > make this as easy as possible, some changes are needed in the build system. > > * If source-date is set to anything other than "updated" (meaning that it

Re: RFR: 8282567: Improve source-date handling in build system

2022-03-02 Thread Severin Gehwolf
On Wed, 2 Mar 2022 16:54:21 GMT, Magnus Ihse Bursie wrote: > To clarify, the end effect of these changes is that building OpenJDK will > basically be compliant with the method of just setting SOURCE_DATE_EPOCH. > (The caveat is that it must be set at configure time, not build time.) So > > ```

Re: RFR: 8282567: Improve source-date handling in build system

2022-03-02 Thread Erik Joelsson
On Wed, 2 Mar 2022 16:52:12 GMT, Magnus Ihse Bursie wrote: > When doing reproducible builds, controlling the build time is imperative. To > make this as easy as possible, some changes are needed in the build system. > > * If source-date is set to anything other than "updated" (meaning that it

RFR: 8282567: Improve source-date handling in build system

2022-03-02 Thread Magnus Ihse Bursie
When doing reproducible builds, controlling the build time is imperative. To make this as easy as possible, some changes are needed in the build system. * If source-date is set to anything other than "updated" (meaning that it should be determined at build time), then the default value of --wi

Re: RFR: 8282567: Improve source-date handling in build system

2022-03-02 Thread Magnus Ihse Bursie
On Wed, 2 Mar 2022 16:52:12 GMT, Magnus Ihse Bursie wrote: > When doing reproducible builds, controlling the build time is imperative. To > make this as easy as possible, some changes are needed in the build system. > > * If source-date is set to anything other than "updated" (meaning that it