Re: RFR: JDK-8072106 Properly handle dependencies for deleted header files

2015-02-06 Thread Erik Joelsson
Thanks, looks much better to me at least. /Erik On 2015-02-06 11:57, Magnus Ihse Bursie wrote: On 2015-02-05 12:44, Erik Joelsson wrote: Looks good to me, but if it's possible, please split that huge echo line. Adding a $$(strip ) will likely remove any extra white space introduced by the spl

Re: RFR: JDK-8072106 Properly handle dependencies for deleted header files

2015-02-06 Thread Magnus Ihse Bursie
On 2015-02-05 12:44, Erik Joelsson wrote: Looks good to me, but if it's possible, please split that huge echo line. Adding a $$(strip ) will likely remove any extra white space introduced by the split and indentation. I'm not sure it's much clearer. :-) However, the lines are indeed shorter,

Re: RFR: JDK-8072106 Properly handle dependencies for deleted header files

2015-02-05 Thread Erik Joelsson
Looks good to me, but if it's possible, please split that huge echo line. Adding a $$(strip ) will likely remove any extra white space introduced by the split and indentation. /Erik On 2015-02-04 13:23, Magnus Ihse Bursie wrote: On 2015-02-04 02:28, David Holmes wrote: On 3/02/2015 11:25 PM,

Re: RFR: JDK-8072106 Properly handle dependencies for deleted header files

2015-02-04 Thread David Holmes
On 4/02/2015 10:23 PM, Magnus Ihse Bursie wrote: On 2015-02-04 02:28, David Holmes wrote: On 3/02/2015 11:25 PM, Magnus Ihse Bursie wrote: On 2015-02-02 23:14, David Holmes wrote: Hi Magnus, On 3/02/2015 1:51 AM, Magnus Ihse Bursie wrote: When a header file is deleted, make will complain "No

Re: RFR: JDK-8072106 Properly handle dependencies for deleted header files

2015-02-04 Thread Magnus Ihse Bursie
On 2015-02-04 02:28, David Holmes wrote: On 3/02/2015 11:25 PM, Magnus Ihse Bursie wrote: On 2015-02-02 23:14, David Holmes wrote: Hi Magnus, On 3/02/2015 1:51 AM, Magnus Ihse Bursie wrote: When a header file is deleted, make will complain "No rule to make target ". This often breaks incremen

Re: RFR: JDK-8072106 Properly handle dependencies for deleted header files

2015-02-03 Thread David Holmes
On 3/02/2015 11:25 PM, Magnus Ihse Bursie wrote: On 2015-02-02 23:14, David Holmes wrote: Hi Magnus, On 3/02/2015 1:51 AM, Magnus Ihse Bursie wrote: When a header file is deleted, make will complain "No rule to make target ". This often breaks incremental build completely unnecessary. When/w

Re: RFR: JDK-8072106 Properly handle dependencies for deleted header files

2015-02-03 Thread Magnus Ihse Bursie
On 2015-02-02 23:14, David Holmes wrote: Hi Magnus, On 3/02/2015 1:51 AM, Magnus Ihse Bursie wrote: When a header file is deleted, make will complain "No rule to make target ". This often breaks incremental build completely unnecessary. When/why would a header file be deleted? Because it is

Re: RFR: JDK-8072106 Properly handle dependencies for deleted header files

2015-02-03 Thread Dave Pointon
Hiya David , Like you, I don't understand why a header file might be deleted following compilation but I can 'sort of' understand why it might not actually be needed following that compilation. Having said that, it makes no sense that a header file required for the initial compilation would not be

Re: RFR: JDK-8072106 Properly handle dependencies for deleted header files

2015-02-02 Thread David Holmes
Hi Magnus, On 3/02/2015 1:51 AM, Magnus Ihse Bursie wrote: When a header file is deleted, make will complain "No rule to make target ". This often breaks incremental build completely unnecessary. When/why would a header file be deleted? There's one typo "dependeny" but I can't comment on the

RFR: JDK-8072106 Properly handle dependencies for deleted header files

2015-02-02 Thread Magnus Ihse Bursie
When a header file is deleted, make will complain "No rule to make target ". This often breaks incremental build completely unnecessary. This can be fixed by adding dummy rules for all header files like this: : gcc can create such rules by itself by using -MP in the generated make dependency