Re: RFR: JDK-8189607 Remove duplicated jvmticmlr.h

2017-10-18 Thread mandy chung
On 10/18/17 1:26 AM, Erik Joelsson wrote: On 2017-10-18 10:04, Magnus Ihse Bursie wrote: The file jvmticmlr.h is stored twice in the repo, both in hotspot and in java.base. They are both identical, and only the java.base version is included in the final product. This might arguably have been

Re: RFR: JDK-8189607 Remove duplicated jvmticmlr.h

2017-10-18 Thread Erik Joelsson
Hello David, On 2017-10-18 11:29, David Holmes wrote: Sanity check: the various -Ixxx will be processed in order and the first file found will be used - right? ie we won't unintentionally pick up the java.base jni.h. Correct, the search order is the order in which the -I parameters are li

Re: RFR: JDK-8189607 Remove duplicated jvmticmlr.h

2017-10-18 Thread David Holmes
Hi Magnus, This seems fine to me. Sanity check: the various -Ixxx will be processed in order and the first file found will be used - right? ie we won't unintentionally pick up the java.base jni.h. Thanks, David On 18/10/2017 6:04 PM, Magnus Ihse Bursie wrote: The file jvmticmlr.h is stored

Re: RFR: JDK-8189607 Remove duplicated jvmticmlr.h

2017-10-18 Thread serguei.spit...@oracle.com
Hi Magnus, The fix looks good to me. Thank you for doing this cleanup. Thanks, Serguei On 10/18/17 01:04, Magnus Ihse Bursie wrote: The file jvmticmlr.h is stored twice in the repo, both in hotspot and in java.base. They are both identical, and only the java.base version is included in the f

Re: RFR: JDK-8189607 Remove duplicated jvmticmlr.h

2017-10-18 Thread Magnus Ihse Bursie
On 2017-10-18 10:26, Erik Joelsson wrote: On 2017-10-18 10:04, Magnus Ihse Bursie wrote: The file jvmticmlr.h is stored twice in the repo, both in hotspot and in java.base. They are both identical, and only the java.base version is included in the final product. This might arguably have been u

Re: RFR: JDK-8189607 Remove duplicated jvmticmlr.h

2017-10-18 Thread Erik Joelsson
On 2017-10-18 10:04, Magnus Ihse Bursie wrote: The file jvmticmlr.h is stored twice in the repo, both in hotspot and in java.base. They are both identical, and only the java.base version is included in the final product. This might arguably have been useful in a pre-consolidated world, but make

RFR: JDK-8189607 Remove duplicated jvmticmlr.h

2017-10-18 Thread Magnus Ihse Bursie
The file jvmticmlr.h is stored twice in the repo, both in hotspot and in java.base. They are both identical, and only the java.base version is included in the final product. This might arguably have been useful in a pre-consolidated world, but makes absolutely no sense now. Bug: https://bugs.o