An internal test at Oracle is failing because of a faulty shell
expression in a makefile for calculating the value for MaxRAMPercentage.
We already have such a calculation in TestCommon.gmk so we should just
use that, but it needs to be exported in a separate variable to be able
to do so.
Bug
Looks good to me! Thanks for fixing Erik.
One pre-existing query:
! # Make sure MaxRAMPercentage is high enough to not cause OOM or
swapping since
Surely "high" should be "low" ??
Thanks,
David
On 1/02/2018 9:52 AM, Erik Joelsson wrote:
An internal test at Oracle is failing because of a fa
Erik:
An internal test at Oracle is failing because of a faulty shell
expression in a makefile for calculating the value for MaxRAMPercentage.
We already have such a calculation in TestCommon.gmk so we should just
use that, but it needs to be exported in a separate variable to be able
to do so.
Yes, that would make more sense, will fix.
/Erik
On 2018-01-31 16:14, David Holmes wrote:
Looks good to me! Thanks for fixing Erik.
One pre-existing query:
! # Make sure MaxRAMPercentage is high enough to not cause OOM or
swapping since
Surely "high" should be "low" ??
Thanks,
David
On
Good point, it really should.
/Erik
On 2018-01-31 16:15, Tim Bell wrote:
Erik:
An internal test at Oracle is failing because of a faulty shell
expression in a makefile for calculating the value for MaxRAMPercentage.
We already have such a calculation in TestCommon.gmk so we should just
use t
New webrev addressing concerns from both Tim and David.
http://cr.openjdk.java.net/~erikj/8196524/webrev.02/
/Erik
On 2018-01-31 15:52, Erik Joelsson wrote:
An internal test at Oracle is failing because of a faulty shell
expression in a makefile for calculating the value for
MaxRAMPercentage.
Looks fine.
Thanks,
David
On 1/02/2018 10:29 AM, Erik Joelsson wrote:
New webrev addressing concerns from both Tim and David.
http://cr.openjdk.java.net/~erikj/8196524/webrev.02/
/Erik
On 2018-01-31 15:52, Erik Joelsson wrote:
An internal test at Oracle is failing because of a faulty shell
Erik:
Looks good to me as well. Thanks.
/Tim
Looks fine.
Thanks,
David
On 1/02/2018 10:29 AM, Erik Joelsson wrote:
New webrev addressing concerns from both Tim and David.
http://cr.openjdk.java.net/~erikj/8196524/webrev.02/
/Erik
On 2018-01-31 15:52, Erik Joelsson wrote:
An internal te