Hello,
I could reproduce this and found the issue. There is a typo in the
conditional. Posting review.
/Erik
On 2020-04-30 10:43, Florian Weimer wrote:
* Magnus Ihse Bursie:
On 2020-04-30 15:50, Florian Weimer wrote:
* Magnus Ihse Bursie:
I made sure that no build performances were
* Magnus Ihse Bursie:
> On 2020-04-30 15:50, Florian Weimer wrote:
>> * Magnus Ihse Bursie:
>>
>>> I made sure that no build performances were measured on my system, and
>>> since I saw no such indication, I did not make any more systematic analysis.
>>>
>>> What is the difference if you run with
On 2020-04-30 15:50, Florian Weimer wrote:
* Magnus Ihse Bursie:
I made sure that no build performances were measured on my system, and
since I saw no such indication, I did not make any more systematic analysis.
What is the difference if you run with or without the javac server?
Thanks.
* Magnus Ihse Bursie:
> I made sure that no build performances were measured on my system, and
> since I saw no such indication, I did not make any more systematic analysis.
>
> What is the difference if you run with or without the javac server?
Thanks. Which configure flags do you want me to
On 2020-04-30 15:07, Magnus Ihse Bursie wrote:
On 2020-04-30 14:55, Florian Weimer wrote:
* Magnus Ihse Bursie:
The code for setting up Java compilation has long been quite hard to
understand, and has a tricky API. Part of this is due to the support
for
the sjavac ("smart javac") system.
On 2020-04-30 14:55, Florian Weimer wrote:
* Magnus Ihse Bursie:
The code for setting up Java compilation has long been quite hard to
understand, and has a tricky API. Part of this is due to the support for
the sjavac ("smart javac") system. We do not use sjavac anymore, and it
has not been
* Magnus Ihse Bursie:
> The code for setting up Java compilation has long been quite hard to
> understand, and has a tricky API. Part of this is due to the support for
> the sjavac ("smart javac") system. We do not use sjavac anymore, and it
> has not been tested for long. Part of the sjavac
On 2020-04-29 00:35, Erik Joelsson wrote:
Hello Magnus,
Nice job! Looks good.
Is the disabling of the warning "options" actually needed in that many
places or did you just add it everywhere where GENERATE_OLDBYTECODE
was used?
It is really needed -- I started out without it, and added it
Hello Magnus,
Nice job! Looks good.
Is the disabling of the warning "options" actually needed in that many
places or did you just add it everywhere where GENERATE_OLDBYTECODE was
used?
Minor notes:
JavaCompilation.gmk
39: spelling
206: do -> does
/Erik
On 2020-04-28 13:37, Magnus Ihse
The code for setting up Java compilation has long been quite hard to
understand, and has a tricky API. Part of this is due to the support for
the sjavac ("smart javac") system. We do not use sjavac anymore, and it
has not been tested for long. Part of the sjavac effort was extracted
into the
10 matches
Mail list logo
