Re: RFR 8043138: Attach API should not require jvmstat rmi protocol

2015-11-30 Thread Magnus Ihse Bursie
On 2015-11-25 17:53, Jaroslav Bachorik wrote: On 25.11.2015 11:36, Magnus Ihse Bursie wrote: On 2015-11-25 10:39, Alan Bateman wrote: On 25/11/2015 09:25, Jaroslav Bachorik wrote: I don't think we can just repackage these interfaces - they are remote API and we would break compatibility (

Re: RFR 8043138: Attach API should not require jvmstat rmi protocol

2015-11-26 Thread Mandy Chung
> On Nov 26, 2015, at 2:12 AM, Jaroslav Bachorik > wrote: > > Mandy, > > On 25.11.2015 18:22, Mandy Chung wrote: >> >>> On Nov 25, 2015, at 8:53 AM, Jaroslav Bachorik >>> wrote: >>> >>> Updated webrevs: >>> >>> http://cr.openjdk.java.net/~jbachorik/8043138/webrev.01/top >>> http://cr.open

Re: RFR 8043138: Attach API should not require jvmstat rmi protocol

2015-11-26 Thread Alan Bateman
On 25/11/2015 16:53, Jaroslav Bachorik wrote: Updated webrevs: http://cr.openjdk.java.net/~jbachorik/8043138/webrev.01/top http://cr.openjdk.java.net/~jbachorik/8043138/webrev.01/jdk Thanks to Erik J. for helping me with the build script! Updated version looks good to me. -Alan

Re: RFR 8043138: Attach API should not require jvmstat rmi protocol

2015-11-26 Thread Jaroslav Bachorik
Mandy, On 25.11.2015 18:22, Mandy Chung wrote: On Nov 25, 2015, at 8:53 AM, Jaroslav Bachorik wrote: Updated webrevs: http://cr.openjdk.java.net/~jbachorik/8043138/webrev.01/top http://cr.openjdk.java.net/~jbachorik/8043138/webrev.01/jdk This looks fine to me. Is there any test referen

Re: RFR 8043138: Attach API should not require jvmstat rmi protocol

2015-11-25 Thread Mandy Chung
> On Nov 25, 2015, at 8:53 AM, Jaroslav Bachorik > wrote: > > Updated webrevs: > > http://cr.openjdk.java.net/~jbachorik/8043138/webrev.01/top > http://cr.openjdk.java.net/~jbachorik/8043138/webrev.01/jdk > This looks fine to me. Is there any test referencing the packages in jdk.jvmstat.rm

Re: RFR 8043138: Attach API should not require jvmstat rmi protocol

2015-11-25 Thread Erik Joelsson
Build changes look good to me now. /Erik On 2015-11-25 17:53, Jaroslav Bachorik wrote: On 25.11.2015 11:36, Magnus Ihse Bursie wrote: On 2015-11-25 10:39, Alan Bateman wrote: On 25/11/2015 09:25, Jaroslav Bachorik wrote: I don't think we can just repackage these interfaces - they are remo

Re: RFR 8043138: Attach API should not require jvmstat rmi protocol

2015-11-25 Thread Alan Bateman
On 25/11/2015 09:25, Jaroslav Bachorik wrote: I don't think we can just repackage these interfaces - they are remote API and we would break compatibility (eg. JDK 8 jvmstat would not be able to query JVM exposed via JDK 9 jstatd). You're right. there might be an expectation on interop althou

Re: RFR 8043138: Attach API should not require jvmstat rmi protocol

2015-11-25 Thread Jaroslav Bachorik
On 25.11.2015 09:37, Erik Joelsson wrote: On 2015-11-25 09:11, Staffan Larsen wrote: On 24 nov. 2015, at 17:03, Jaroslav Bachorik wrote: Please, review the following change Issue : https://bugs.openjdk.java.net/browse/JDK-8043138 Webrevs: * top level: http://cr.openjdk.java.net/~jbachorik/8

Re: RFR 8043138: Attach API should not require jvmstat rmi protocol

2015-11-25 Thread Jaroslav Bachorik
On 25.11.2015 11:36, Magnus Ihse Bursie wrote: On 2015-11-25 10:39, Alan Bateman wrote: On 25/11/2015 09:25, Jaroslav Bachorik wrote: I don't think we can just repackage these interfaces - they are remote API and we would break compatibility (eg. JDK 8 jvmstat would not be able to query JVM

Re: RFR 8043138: Attach API should not require jvmstat rmi protocol

2015-11-25 Thread Erik Joelsson
On 2015-11-25 09:11, Staffan Larsen wrote: On 24 nov. 2015, at 17:03, Jaroslav Bachorik wrote: Please, review the following change Issue : https://bugs.openjdk.java.net/browse/JDK-8043138 Webrevs: * top level: http://cr.openjdk.java.net/~jbachorik/8043138/webrev.00/top * jdk: http://cr.open

Re: RFR 8043138: Attach API should not require jvmstat rmi protocol

2015-11-25 Thread Magnus Ihse Bursie
On 2015-11-25 10:39, Alan Bateman wrote: On 25/11/2015 09:25, Jaroslav Bachorik wrote: I don't think we can just repackage these interfaces - they are remote API and we would break compatibility (eg. JDK 8 jvmstat would not be able to query JVM exposed via JDK 9 jstatd). You're right. there

Re: RFR 8043138: Attach API should not require jvmstat rmi protocol

2015-11-25 Thread Erik Joelsson
On 2015-11-25 10:28, Jaroslav Bachorik wrote: On 25.11.2015 09:37, Erik Joelsson wrote: On 2015-11-25 09:11, Staffan Larsen wrote: On 24 nov. 2015, at 17:03, Jaroslav Bachorik wrote: Please, review the following change Issue : https://bugs.openjdk.java.net/browse/JDK-8043138 Webrevs: * t

Re: RFR 8043138: Attach API should not require jvmstat rmi protocol

2015-11-25 Thread Jaroslav Bachorik
On 25.11.2015 10:02, Alan Bateman wrote: On 24/11/2015 16:03, Jaroslav Bachorik wrote: Please, review the following change Issue : https://bugs.openjdk.java.net/browse/JDK-8043138 Webrevs: * top level: http://cr.openjdk.java.net/~jbachorik/8043138/webrev.00/top * jdk: http://cr.openjdk.java.ne

Re: RFR 8043138: Attach API should not require jvmstat rmi protocol

2015-11-25 Thread Alan Bateman
On 24/11/2015 16:03, Jaroslav Bachorik wrote: Please, review the following change Issue : https://bugs.openjdk.java.net/browse/JDK-8043138 Webrevs: * top level: http://cr.openjdk.java.net/~jbachorik/8043138/webrev.00/top * jdk: http://cr.openjdk.java.net/~jbachorik/8043138/webrev.00/jdk This p

Re: RFR 8043138: Attach API should not require jvmstat rmi protocol

2015-11-25 Thread Alan Bateman
On 25/11/2015 08:11, Staffan Larsen wrote: On 24 nov. 2015, at 17:03, Jaroslav Bachorik wrote: Please, review the following change Issue : https://bugs.openjdk.java.net/browse/JDK-8043138 Webrevs: * top level: http://cr.openjdk.java.net/~jbachorik/8043138/webrev.00/top * jdk: http://cr.openjd

Re: RFR 8043138: Attach API should not require jvmstat rmi protocol

2015-11-25 Thread Staffan Larsen
> On 24 nov. 2015, at 17:03, Jaroslav Bachorik > wrote: > > Please, review the following change > > Issue : https://bugs.openjdk.java.net/browse/JDK-8043138 > Webrevs: > * top level: http://cr.openjdk.java.net/~jbachorik/8043138/webrev.00/top > * jdk: http://cr.openjdk.java.net/~jbachorik/8043

RFR 8043138: Attach API should not require jvmstat rmi protocol

2015-11-24 Thread Jaroslav Bachorik
Please, review the following change Issue : https://bugs.openjdk.java.net/browse/JDK-8043138 Webrevs: * top level: http://cr.openjdk.java.net/~jbachorik/8043138/webrev.00/top * jdk: http://cr.openjdk.java.net/~jbachorik/8043138/webrev.00/jdk This patch splits up the jdk.jvmstat module to jdk.jvm