Re: RFR 8202210: jlink uses little-endian for big-endian cross-compilation targets

2018-04-25 Thread Aleksey Shipilev
On 04/25/2018 12:08 PM, Alan Bateman wrote: > On 25/04/2018 10:06, Aleksey Shipilev wrote: >> I was doing the exercise of cross-compiling from x86_64 to most OpenJDK >> arches, and we have >> discovered the bug with endianness. Right now, compiling big-endian s390x >> target on little-endian >> x

Re: RFR 8202210: jlink uses little-endian for big-endian cross-compilation targets

2018-04-25 Thread Thomas Stüfe
Hi Aleksey, the fix looks good. Best Regards, Thomas On Wed, Apr 25, 2018 at 11:29 AM, Aleksey Shipilev wrote: > On 04/25/2018 11:14 AM, Magnus Ihse Bursie wrote: >>> diff -r 5d2da44780ac make/Images.gmk >>> --- a/make/Images.gmkWed Apr 25 10:38:07 2018 +0200 >>> +++ b/make/Images.gmkWe

Re: RFR 8202210: jlink uses little-endian for big-endian cross-compilation targets

2018-04-25 Thread Alan Bateman
On 25/04/2018 10:06, Aleksey Shipilev wrote: Hi, I was doing the exercise of cross-compiling from x86_64 to most OpenJDK arches, and we have discovered the bug with endianness. Right now, compiling big-endian s390x target on little-endian x86_64 host produces the modules blob that cannot be

Re: RFR 8202210: jlink uses little-endian for big-endian cross-compilation targets

2018-04-25 Thread Aleksey Shipilev
On 04/25/2018 11:14 AM, Magnus Ihse Bursie wrote: >> diff -r 5d2da44780ac make/Images.gmk >> --- a/make/Images.gmk    Wed Apr 25 10:38:07 2018 +0200 >> +++ b/make/Images.gmk    Wed Apr 25 10:55:04 2018 +0200 >> @@ -117,7 +117,7 @@ >> >>   JLINK_TOOL := $(JLINK) -J-Djlink.debug=true \ >>   --mod

Re: RFR 8202210: jlink uses little-endian for big-endian cross-compilation targets

2018-04-25 Thread Magnus Ihse Bursie
On 2018-04-25 11:06, Aleksey Shipilev wrote: Hi, I was doing the exercise of cross-compiling from x86_64 to most OpenJDK arches, and we have discovered the bug with endianness. Right now, compiling big-endian s390x target on little-endian x86_64 host produces the modules blob that cannot be re

RFR 8202210: jlink uses little-endian for big-endian cross-compilation targets

2018-04-25 Thread Aleksey Shipilev
Hi, I was doing the exercise of cross-compiling from x86_64 to most OpenJDK arches, and we have discovered the bug with endianness. Right now, compiling big-endian s390x target on little-endian x86_64 host produces the modules blob that cannot be read on real s390x. It seems to be a simple over