Re: Build support for JDK-8044627

2014-10-16 Thread Chris Hegarty
Erik, Pavel has already pushed the JNDI changes, and will follow up with the service configuration files later, so this issue is less pressing. If you like lets defer addressing the general problem of concatenating service configuration files until jigsaw/m2 is in the JDK 9 mainline. There is

Re: Build support for JDK-8044627

2014-10-16 Thread Erik Joelsson
Hello, The main problem is that we now will have Gensrc-$m.gmk for the same module in multiple repos. Now, that just happened again with my patch to split GensrcProperties.gmk (jdk.dev has gensrc in both langtools and jdk), so I took the time to solve it in M2. What I mean by this is that M2

Re: Build support for JDK-8044627

2014-10-16 Thread Chris Hegarty
On 16 Oct 2014, at 15:58, Erik Joelsson erik.joels...@oracle.com wrote: Hello, The main problem is that we now will have Gensrc-$m.gmk for the same module in multiple repos. Now, that just happened again with my patch to split GensrcProperties.gmk (jdk.dev has gensrc in both langtools and

Re: Build support for JDK-8044627

2014-10-15 Thread Erik Joelsson
Hello, I have managed to come up with this solution for jdk9/dev. http://cr.openjdk.java.net/~erikj/8044627/webrev.01/ I added a gensrc step for each of the affected modules that simply concatenates the files into the gensrc output dir. The version found there will automatically override the

Re: Build support for JDK-8044627

2014-10-15 Thread Pavel Rappo
Thanks Erik! -Pavel On 15 Oct 2014, at 11:40, Erik Joelsson erik.joels...@oracle.com wrote: Hello, I have managed to come up with this solution for jdk9/dev. http://cr.openjdk.java.net/~erikj/8044627/webrev.01/ I added a gensrc step for each of the affected modules that simply

Re: Build support for JDK-8044627

2014-10-14 Thread Erik Joelsson
Hello Pavel, This will be a bit tricky. Give me a day or two and I will try to come up with something. /Erik On 2014-10-14 15:27, Pavel Rappo wrote: Hi, I can't build jdk9/dev repo after I introduced 4 'META-INF/service/javax.naming.spi.InitialContextFactory' files to support JNDI