Looks good.
/Erik
On 2019-10-04 04:52, Magnus Ihse Bursie wrote:
On 2019-10-02 17:45, Martin Buchholz wrote:
I recall years ago running into troubles with regex character ranges,
e.g.
https://unix.stackexchange.com/questions/15980/does-should-lc-collate-affect-character-ranges
but my build
On 2019-10-04 15:16, Erik Joelsson wrote:
On 2019-10-04 04:37, Magnus Ihse Bursie wrote:
On 2019-10-02 17:40, Erik Joelsson wrote:
Hello Magnus,
The change looks good, but should perhaps also include removal of
the few scattered specific instances of LANG=C and LC_ALL=C in the
makefiles:
m
On 2019-10-04 04:37, Magnus Ihse Bursie wrote:
On 2019-10-02 17:40, Erik Joelsson wrote:
Hello Magnus,
The change looks good, but should perhaps also include removal of the
few scattered specific instances of LANG=C and LC_ALL=C in the
makefiles:
make/common/JavaCompilation.gmk: export L
On 2019-10-02 17:45, Martin Buchholz wrote:
I recall years ago running into troubles with regex character ranges,
e.g.
https://unix.stackexchange.com/questions/15980/does-should-lc-collate-affect-character-ranges
but my build script wrapper has been setting LC_ALL=C for a long time,
and I set LC
On 2019-10-02 17:40, Erik Joelsson wrote:
Hello Magnus,
The change looks good, but should perhaps also include removal of the
few scattered specific instances of LANG=C and LC_ALL=C in the makefiles:
make/common/JavaCompilation.gmk: export LC_ALL=C ; ( $(CAT) $$< &&
$(ECHO) "" ) \
make/
I recall years ago running into troubles with regex character ranges, e.g.
https://unix.stackexchange.com/questions/15980/does-should-lc-collate-affect-character-ranges
but my build script wrapper has been setting LC_ALL=C for a long time,
and I set LC_COLLATE=C in my normal use shell environment
(
Hello Magnus,
The change looks good, but should perhaps also include removal of the
few scattered specific instances of LANG=C and LC_ALL=C in the makefiles:
make/common/JavaCompilation.gmk: export LC_ALL=C ; ( $(CAT) $$< &&
$(ECHO) "" ) \
make/autoconf/basics.m4: DATE_WHEN_CONFIGURED=`
Hi Magnus,
Looks good to me. Although I cannot provide any reproducible problematic
instance, there have been instances where native tools, such as `date`
command had produced localized date, and the build failed to parse it in
US format. Anyways, it is a good preventive measure to me.
Naoto
