Re: Review request: 8055230: Rename attach provider implementation class

2014-08-26 Thread Mandy Chung
On 8/26/2014 3:59 AM, Staffan Larsen wrote: There are some differences in the AttachProvideImpl files. Most notably the windows version is very different. Linux, Bsd and Aix are the same. The Solaris version has a minor difference in the “public String type()” implementation. The Linux, Bsd,

Re: Review request: 8055230: Rename attach provider implementation class

2014-08-26 Thread Daniel Fuchs
On 8/26/14 12:59 PM, Staffan Larsen wrote: There are some differences in the AttachProvideImpl files. Most notably the windows version is very different. Linux, Bsd and Aix are the same. The Solaris version has a minor difference in the “public String type()” implementation. The Linux, Bsd, A

Re: Review request: 8055230: Rename attach provider implementation class

2014-08-26 Thread Staffan Larsen
There are some differences in the AttachProvideImpl files. Most notably the windows version is very different. Linux, Bsd and Aix are the same. The Solaris version has a minor difference in the “public String type()” implementation. The Linux, Bsd, Aix and Solaris versions could probably be uni

Re: Review request: 8055230: Rename attach provider implementation class

2014-08-26 Thread Daniel Fuchs
Hi Mandy, I'm seeing some small differences in the various VirtualMachineImpl.java files, but if I'm not mistaken, all the new AttachProviderImpl.java look all the same. I wonder if the patch could be further simplified by moving AttachProviderImpl.java to jdk.attach/share/classes (unless there's

Re: Review request: 8055230: Rename attach provider implementation class

2014-08-26 Thread Erik Joelsson
Nice! /Erik On 2014-08-26 06:29, Mandy Chung wrote: Webrev: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8055230/ This patch renames the class name of attach provider implementation class to be the same for all platforms. This simplifies the build logic and removes the need for generati

Re: Review request: 8055230: Rename attach provider implementation class

2014-08-26 Thread Chris Hegarty
On 26 Aug 2014, at 08:26, Alan Bateman wrote: > On 26/08/2014 05:29, Mandy Chung wrote: >> Webrev: >> http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8055230/ >> >> This patch renames the class name of attach provider implementation class >> to be the same for all platforms. This simplifies

Re: Review request: 8055230: Rename attach provider implementation class

2014-08-26 Thread Alan Bateman
On 26/08/2014 05:29, Mandy Chung wrote: Webrev: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8055230/ This patch renames the class name of attach provider implementation class to be the same for all platforms. This simplifies the build logic and removes the need for generating the service

Re: Review request: 8055230: Rename attach provider implementation class

2014-08-25 Thread Staffan Larsen
Ahh. The simplicity! Looks good! Thanks, /Staffan On 26 aug 2014, at 06:29, Mandy Chung wrote: > Webrev: > http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8055230/ > > This patch renames the class name of attach provider implementation class > to be the same for all platforms. This simplif

Re: Review request: 8055230: Rename attach provider implementation class

2014-08-25 Thread David Holmes
I like this change! :) Looks good to me. Thanks Mandy! David - On 26/08/2014 2:29 PM, Mandy Chung wrote: Webrev: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8055230/ This patch renames the class name of attach provider implementation class to be the same for all platforms. This

Review request: 8055230: Rename attach provider implementation class

2014-08-25 Thread Mandy Chung
Webrev: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8055230/ This patch renames the class name of attach provider implementation class to be the same for all platforms. This simplifies the build logic and removes the need for generating the service config file at build time. The files re