Re: jmx-dev RFR 8060692 Delete com/sun/jmx/snmp and sun/management/snmp from OpenJDK

2014-10-16 Thread Mandy Chung
On 10/16/14 3:20 AM, shanliang wrote: Hi, Here is the new version: http://cr.openjdk.java.net/~sjiang/JDK-8060692/02/ Looks fine to me. thanks Mandy

Re: jmx-dev RFR 8060692 Delete com/sun/jmx/snmp and sun/management/snmp from OpenJDK

2014-10-16 Thread Erik Joelsson
Looks good now. /Erik On 2014-10-16 12:20, shanliang wrote: Hi, Here is the new version: http://cr.openjdk.java.net/~sjiang/JDK-8060692/02/ ./02/jdk9-open/ has 2 more deleted files than in ./01/jdk9-jdk-src/ test/com/sun/jmx/snmp/ SnmpOidHashCode.java, TimeTicksWrapping.java ./

Re: jmx-dev RFR 8060692 Delete com/sun/jmx/snmp and sun/management/snmp from OpenJDK

2014-10-16 Thread shanliang
Hi, Here is the new version: http://cr.openjdk.java.net/~sjiang/JDK-8060692/02/ ./02/jdk9-open/ has 2 more deleted files than in ./01/jdk9-jdk-src/ test/com/sun/jmx/snmp/ SnmpOidHashCode.java, TimeTicksWrapping.java ./02/jdk9-make/ has one more modified: make/common/Modules.gmk

Re: jmx-dev RFR 8060692 Delete com/sun/jmx/snmp and sun/management/snmp from OpenJDK

2014-10-15 Thread Erik Joelsson
Nice catch Mandy, I forgot about that one. /Erik On 2014-10-15 18:04, Mandy Chung wrote: Hi Shanliang, On 10/15/2014 8:19 AM, shanliang wrote: Here is the new version: http://cr.openjdk.java.net/~sjiang/JDK-8060692/01/ Thanks for taking this on. The fix looks okay. I think you should

Re: jmx-dev RFR 8060692 Delete com/sun/jmx/snmp and sun/management/snmp from OpenJDK

2014-10-15 Thread shanliang
Here is the new version: http://cr.openjdk.java.net/~sjiang/JDK-8060692/01/ I add: ./01/jdk9-make/ for updating ./make/CompileJavaModules.gmk ./01/jdk9-jdk-src/ is same to ./00 Thanks, Shanliang Erik Joelsson wrote: Hello, Removing the excludes would be appreciated. Here is a patch:

Re: jmx-dev RFR 8060692 Delete com/sun/jmx/snmp and sun/management/snmp from OpenJDK

2014-10-15 Thread Mandy Chung
On 10/15/2014 9:04 AM, Mandy Chung wrote: Hi Shanliang, On 10/15/2014 8:19 AM, shanliang wrote: Here is the new version: http://cr.openjdk.java.net/~sjiang/JDK-8060692/01/ Thanks for taking this on. The fix looks okay. I think you should also take out: make/common/Modules.gmk line 45

Re: jmx-dev RFR 8060692 Delete com/sun/jmx/snmp and sun/management/snmp from OpenJDK

2014-10-15 Thread Mandy Chung
Hi Shanliang, On 10/15/2014 8:19 AM, shanliang wrote: Here is the new version: http://cr.openjdk.java.net/~sjiang/JDK-8060692/01/ Thanks for taking this on. The fix looks okay. I think you should also take out: make/common/Modules.gmk line 45: JAVA_MODULES_FILTER := jdk.snmp Mandy

Re: jmx-dev RFR 8060692 Delete com/sun/jmx/snmp and sun/management/snmp from OpenJDK

2014-10-15 Thread Daniel Fuchs
On 15/10/14 17:19, shanliang wrote: Here is the new version: http://cr.openjdk.java.net/~sjiang/JDK-8060692/01/ The new version looks fine :-) -- daniel I add: ./01/jdk9-make/ for updating ./make/CompileJavaModules.gmk ./01/jdk9-jdk-src/ is same to ./00 Thanks, Shanliang Erik Jo

Re: jmx-dev RFR 8060692 Delete com/sun/jmx/snmp and sun/management/snmp from OpenJDK

2014-10-15 Thread Alan Bateman
On 15/10/2014 16:19, shanliang wrote: Here is the new version: http://cr.openjdk.java.net/~sjiang/JDK-8060692/01/ I add: ./01/jdk9-make/ for updating ./make/CompileJavaModules.gmk ./01/jdk9-jdk-src/ is same to ./00 Thanks, Shanliang This looks good. -Alan

Re: jmx-dev RFR 8060692 Delete com/sun/jmx/snmp and sun/management/snmp from OpenJDK

2014-10-15 Thread Erik Joelsson
Hello, Removing the excludes would be appreciated. Here is a patch: diff -r c173ba994245 make/CompileJavaModules.gmk --- a/make/CompileJavaModules.gmk +++ b/make/CompileJavaModules.gmk @@ -247,14 +247,6 @@ # Exclude building of IIOP transport for RMI Connector java.management_EXCLUDES := com/s

Re: jmx-dev RFR 8060692 Delete com/sun/jmx/snmp and sun/management/snmp from OpenJDK

2014-10-15 Thread Alan Bateman
On 15/10/2014 14:35, shanliang wrote: Hi, SNMP is not part of OpenJDK and SNMP packages are not compiled in OpenJDK, so the SNMP sources should be deleted from the OpenJDK Bug: https://bugs.openjdk.java.net/browse/JDK-8060692 Webrev: http://cr.openjdk.java.net/~sjiang/JDK-8060692/00/ The code