Re: Request for guidance on using possible future sets of javac options

2015-02-06 Thread Erik Joelsson
Hello Joe, The simplest way of accomplishing this currently would be to add lines like this to make/CompileJavaModules.gmk: java.base_ADD_JAVAC_FLAGS := -Xdoclint:all/protected "-XdoclintPackage:java.*;javax.*" java.desktop_ADD_JAVAC_FLAGS := -Xdoclint:all,-missing/protected "-XdoclintPackag

Re: RFR JDK-8071338: Move policytool from JRE to JDK

2015-02-06 Thread Magnus Ihse Bursie
On 2015-02-06 03:18, Weijun Wang wrote: Hi All Please review this change at root: http://cr.openjdk.java.net/~weijun/8071338/root/webrev.00/ jdk: http://cr.openjdk.java.net/~weijun/8071338/jdk/webrev.00/ No actual java code change, just move everything inside the s.s.t.policytool into anothe

Re: RFR: JDK-8072106 Properly handle dependencies for deleted header files

2015-02-06 Thread Magnus Ihse Bursie
On 2015-02-05 12:44, Erik Joelsson wrote: Looks good to me, but if it's possible, please split that huge echo line. Adding a $$(strip ) will likely remove any extra white space introduced by the split and indentation. I'm not sure it's much clearer. :-) However, the lines are indeed shorter,

Re: RFR: JDK-8072106 Properly handle dependencies for deleted header files

2015-02-06 Thread Erik Joelsson
Thanks, looks much better to me at least. /Erik On 2015-02-06 11:57, Magnus Ihse Bursie wrote: On 2015-02-05 12:44, Erik Joelsson wrote: Looks good to me, but if it's possible, please split that huge echo line. Adding a $$(strip ) will likely remove any extra white space introduced by the spl

Re: RFR: JDK-8071767 Improve names and dependencies for image targets

2015-02-06 Thread Magnus Ihse Bursie
On 2015-02-05 08:12, David Holmes wrote: Hi Magnus, Thanks for the detailed background - makes things a lot clearer! It would be useful for a synopsis to be included in the makefile along with the functional changes. So I joined forces with Ingemar and extended his patch with some comments

Re: RFR: JDK-8071767 Improve names and dependencies for image targets

2015-02-06 Thread Erik Joelsson
Looks good if you fix "alias" -> "aliases". No need for new review. /Erik On 2015-02-06 12:16, Magnus Ihse Bursie wrote: On 2015-02-05 08:12, David Holmes wrote: Hi Magnus, Thanks for the detailed background - makes things a lot clearer! It would be useful for a synopsis to be included in th

Re: RFR: JDK-8071767 Improve names and dependencies for image targets

2015-02-06 Thread Magnus Ihse Bursie
On 2015-02-06 12:16, Magnus Ihse Bursie wrote: On 2015-02-05 08:12, David Holmes wrote: Hi Magnus, Thanks for the detailed background - makes things a lot clearer! It would be useful for a synopsis to be included in the makefile along with the functional changes. So I joined forces with Ing

Build error with javac Main not being found when building java.transaction module on Mac OS X

2015-02-06 Thread Martijn Verburg
Hi all, Apologies if this has already been reported before! Build from HEAD (jdk9) today I get the following error running make clean images: make clean images Cleaning hotspot build artifacts ... done Cleaning jdk build artifacts ... done Cleaning bootcycle-build build artifacts ... done Cleani

Re: RFR: JDK-8071767 Improve names and dependencies for image targets

2015-02-06 Thread Erik Joelsson
OK from me. /Erik On 2015-02-06 12:29, Magnus Ihse Bursie wrote: On 2015-02-06 12:16, Magnus Ihse Bursie wrote: On 2015-02-05 08:12, David Holmes wrote: Hi Magnus, Thanks for the detailed background - makes things a lot clearer! It would be useful for a synopsis to be included in the makefi

Re: Build error with javac Main not being found when building java.transaction module on Mac OS X

2015-02-06 Thread Erik Joelsson
This looks like a mismatch between the modules make finds and the dependencies calculated between them. Make sure all your repos are up to date and try dist-clean and rerun configure. /Erik On 2015-02-06 12:32, Martijn Verburg wrote: Hi all, Apologies if this has already been reported before

Re: Build error with javac Main not being found when building java.transaction module on Mac OS X

2015-02-06 Thread Alan Bateman
On 06/02/2015 11:32, Martijn Verburg wrote: Hi all, Apologies if this has already been reported before! Build from HEAD (jdk9) today I get the following error running make clean images: make clean images Cleaning hotspot build artifacts ... done Cleaning jdk build artifacts ... done Cleaning b

Re: RFR: JDK-8071767 Improve names and dependencies for image targets

2015-02-06 Thread David Holmes
On 6/02/2015 9:16 PM, Magnus Ihse Bursie wrote: On 2015-02-05 08:12, David Holmes wrote: Hi Magnus, Thanks for the detailed background - makes things a lot clearer! It would be useful for a synopsis to be included in the makefile along with the functional changes. So I joined forces with Inge

Re: Build error with javac Main not being found when building java.transaction module on Mac OS X

2015-02-06 Thread Martijn Verburg
Hi Erik, Thanks for the quick response! I ran: make dist-clean bash configure make clean images Slightly different message this time, no error for missing javac.Main, but a warning on missing interim_langtools.jar (could be unrelated to the real issue). Will also try Alan's suggestion next. ==

Re: Build error with javac Main not being found when building java.transaction module on Mac OS X

2015-02-06 Thread Martijn Verburg
Hi Alan, Thanks for the quick response! I've executed: rm -rf build bash configure make clean images == Unfortunately the same error comes up: Cleaned all build artifacts. Building OpenJDK for target 'clean images' in configuration 'macosx-x86_64-normal-server-release' Compi

Re: Build error with javac Main not being found when building java.transaction module on Mac OS X

2015-02-06 Thread Martijn Verburg
Hi Erik/Alan, Not sure if this information is useful at all but the following tmp file was left behind: /Users/karianna/Documents/workspace/AdoptOpenJDK_projects/jdk9/build/macosx- x86_64-normal-server-release/jdk/modules/java.transaction/_ the.java.transaction_batch.tmp It contains: /Users/kar

Re: Build error with javac Main not being found when building java.transaction module on Mac OS X

2015-02-06 Thread Alan Bateman
On 06/02/2015 15:42, Martijn Verburg wrote: Hi Alan, Thanks for the quick response! I've executed: rm -rf build bash configure make clean images == Unfortunately the same error comes up: Cleaned all build artifacts. Building OpenJDK for target 'clean images' in configuration '

Re: Build error with javac Main not being found when building java.transaction module on Mac OS X

2015-02-06 Thread Martijn Verburg
Hi Alan, On 6 February 2015 at 16:06, Alan Bateman wrote: > On 06/02/2015 15:42, Martijn Verburg wrote: > > Hi Alan, > > Thanks for the quick response! I've executed: > > rm -rf build > bash configure > make clean images > > == > > Unfortunately the same error comes up: > > >

Re: Build error with javac Main not being found when building java.transaction module on Mac OS X

2015-02-06 Thread Andrew Haley
On 02/06/2015 04:20 PM, Martijn Verburg wrote: > Is there a way of printing out the absolute path to the javac it might be > trying to execute? I wonder if it goes looking elsewhere during the > build... Are you not building with LOG=debug ? Andrew.

Re: Build error with javac Main not being found when building java.transaction module on Mac OS X

2015-02-06 Thread Martijn Verburg
Hi Andrew, Thanks, that was dense of me not to do that first. Using debug output I discover that there are more than just one javac involved, one from interim_langtools.jar ... SetupJavaCompiler(BOOT_JAVAC) [2] JAVAC := /Library/Java/JavaVirtualMachines/jdk1.8.0_31.jdk/Contents/Home/b

Re: Build error with javac Main not being found when building java.transaction module on Mac OS X

2015-02-06 Thread Jonathan Gibbons
Martijn, Welcome to the world of bootstrapping the build. The BOOTJDK is only guaranteed to understand -source 8 (when building 9) so we use the BOOTJDK javac to compile an interim javac from the latest source code, which can understand -source 9. (This requires and implies that javac is w

Re: README-builds.html update

2015-02-06 Thread Martijn Verburg
Hi all, So I started digging into this (just the HTML path to start with) and the diff got pretty ridiculous. So I'm going to split the work into several parts: 1.) Fix HTML warnings and convert HTML styling to CSS styling (using internal stylesheet) 2.) Cosmetic changes to improve readability (

Re: Request for guidance on using possible future sets of javac options

2015-02-06 Thread Jonathan Gibbons
Nothing about the option syntax is currently set in stone. I suggest that using a comma ',' would be preferable to using a semi-colon ';', or using repeated options. -- Jon On 02/06/2015 12:03 AM, Erik Joelsson wrote: Hello Joe, The simplest way of accomplishing this currently would be to

Re: Request for guidance on using possible future sets of javac options

2015-02-06 Thread joe darcy
Hi Erik, On 2/6/2015 12:03 AM, Erik Joelsson wrote: Hello Joe, The simplest way of accomplishing this currently would be to add lines like this to make/CompileJavaModules.gmk: java.base_ADD_JAVAC_FLAGS := -Xdoclint:all/protected "-XdoclintPackage:java.*;javax.*" java.desktop_ADD_JAVAC_FLAGS

Re: Build error with javac Main not being found when building java.transaction module on Mac OS X

2015-02-06 Thread Magnus Ihse Bursie
On 2015-02-06 17:46, Martijn Verburg wrote: /Users/karianna/Documents/workspace/AdoptOpenJDK_projects/jdk9/build/macosx-x86_64-normal-server-release/buildtools/interim_langtools.jar does not exist! So it's not being built correctly or moved to the right place. I'm not seeing any other clues (e

Re: Request for guidance on using possible future sets of javac options

2015-02-06 Thread Magnus Ihse Bursie
On 2015-02-06 23:43, joe darcy wrote: Hi Erik, On 2/6/2015 12:03 AM, Erik Joelsson wrote: Hello Joe, The simplest way of accomplishing this currently would be to add lines like this to make/CompileJavaModules.gmk: java.base_ADD_JAVAC_FLAGS := -Xdoclint:all/protected "-XdoclintPackage:java.

Re: README-builds.html update

2015-02-06 Thread Magnus Ihse Bursie
On 2015-02-06 18:18, Martijn Verburg wrote: Hi all, So I started digging into this (just the HTML path to start with) and the diff got pretty ridiculous. So I'm going to split the work into several parts: 1.) Fix HTML warnings and convert HTML styling to CSS styling (using internal styleshe

Re: Request for guidance on using possible future sets of javac options

2015-02-06 Thread joe darcy
Hi Magnus, On 2/6/2015 3:45 PM, Magnus Ihse Bursie wrote: On 2015-02-06 23:43, joe darcy wrote: Hi Erik, On 2/6/2015 12:03 AM, Erik Joelsson wrote: Hello Joe, The simplest way of accomplishing this currently would be to add lines like this to make/CompileJavaModules.gmk: java.base_ADD_JAV

Re: Build error with javac Main not being found when building java.transaction module on Mac OS X

2015-02-06 Thread Mani Sarkar
@Martijn - as Magnus suggests, I would do the same, zap all the forests then clone and run get_source.sh. I have had similar instances in the past and the above helped although the cause of the problem may sometimes elude us. Cheers, Mani On Fri, Feb 6, 2015 at 11:16 PM, Magnus Ihse Bursie < mag

CFV: Nomination of Volker Simonis to OpenJDK Build Group

2015-02-06 Thread Magnus Ihse Bursie
I hereby nominate Volker Simonis to Membership in the OpenJDK Build Group. Volker Simonis is an OpenJDK Member, Project Lead of the PowerPC/AIX Port Project and a JDK 9 Project Reviewer. Volker has been an active and helpful contributor to the Build Group mailing list (build-dev) for more tha

Re: README-builds.html update

2015-02-06 Thread Mani Sarkar
I have come across a couple of online html to markdown converters which might help - I hope it makes the process easier: http://domchristie.github.io/to-markdown/ http://markable.in/editor/ This one has multiple format to multiple format conversion facility: http://johnmacfarlane.net/pandoc/try/

Re: CFV: Nomination of Volker Simonis to OpenJDK Build Group

2015-02-06 Thread Magnus Ihse Bursie
Vote: yes /Magnus On 2015-02-07 01:53, Magnus Ihse Bursie wrote: I hereby nominate Volker Simonis to Membership in the OpenJDK Build Group. Volker Simonis is an OpenJDK Member, Project Lead of the PowerPC/AIX Port Project and a JDK 9 Project Reviewer. Volker has been an active and helpful