Re: RFR: 8290059: Do not use std::thread in panama tests [v2]

2022-07-25 Thread Erik Joelsson
On Fri, 22 Jul 2022 16:45:55 GMT, Jorn Vernee wrote: >> This patch removes the use of std::thread from the `java.lang.foreign` >> tests, and switches to the OS specific thread APIs, in order to change >> things such as the stack size on some platforms where this is required in >> the future (s

Re: RFR: 8289755: Remove --enable-reproducible-build from jib profile

2022-07-25 Thread Erik Joelsson
On Tue, 5 Jul 2022 16:01:50 GMT, Magnus Ihse Bursie wrote: > Since [JDK-8288396](https://bugs.openjdk.org/browse/JDK-8288396), the flag ` > --enable-reproducible-build` is deprecated, and does nothing but print a > warning. It is still included in the jib profiles, which make they output a > w

Re: RFR: 8285792: Posix signal handler modification checking issues.

2022-07-25 Thread David Holmes
On Mon, 25 Jul 2022 17:21:27 GMT, Harold Seigel wrote: > Please review this fix for JDK-8285792. The fix removes print statements > from check_signal_handler() so that it doesn't print all the handlers every > time it finds one that is modified. Instead, it returns true if the handler > is m

Re: RFR: 8285792: Posix signal handler modification checking issues.

2022-07-25 Thread David Holmes
On Mon, 25 Jul 2022 17:21:27 GMT, Harold Seigel wrote: > Please review this fix for JDK-8285792. The fix removes print statements > from check_signal_handler() so that it doesn't print all the handlers every > time it finds one that is modified. Instead, it returns true if the handler > is m

Re: RFR: 8285792: Posix signal handler modification checking issues.

2022-07-25 Thread Phil Race
On Mon, 25 Jul 2022 19:29:52 GMT, Harold Seigel wrote: > I ran the test for JDK-8279878 after removing both this fix and the fix for > JDK-8279878 and the test still passed. So I don't think its failure was > related to this issue. This fix prevents the output from occurring more than > once.

Re: RFR: 8285792: Posix signal handler modification checking issues.

2022-07-25 Thread Harold Seigel
On Mon, 25 Jul 2022 17:21:27 GMT, Harold Seigel wrote: > Please review this fix for JDK-8285792. The fix removes print statements > from check_signal_handler() so that it doesn't print all the handlers every > time it finds one that is modified. Instead, it returns true if the handler > is m

Re: RFR: 8285792: Posix signal handler modification checking issues.

2022-07-25 Thread Phil Race
On Mon, 25 Jul 2022 17:21:27 GMT, Harold Seigel wrote: > Please review this fix for JDK-8285792. The fix removes print statements > from check_signal_handler() so that it doesn't print all the handlers every > time it finds one that is modified. Instead, it returns true if the handler > is m

RFR: 8285792: Posix signal handler modification checking issues.

2022-07-25 Thread Harold Seigel
Please review this fix for JDK-8285792. The fix removes print statements from check_signal_handler() so that it doesn't print all the handlers every time it finds one that is modified. Instead, it returns true if the handler is modified, false otherwise. Its caller, user_handler(), then print

Re: RFR: 8290154: [JVMCI] Implement JVMCI for RISC-V

2022-07-25 Thread Sacha Coppey
On Mon, 25 Jul 2022 07:30:08 GMT, Fei Yang wrote: > Hi, I see some JVM crash when I try the following test with fastdebug build > with your patch: > test/hotspot/jtreg/compiler/jvmci/jdk.vm.ci.code.test/src/jdk/vm/ci/code/test/SimpleDebugInfoTest.java Thank you for pointing this out, I did not

Re: RFR: 8290154: [JVMCI] Implement JVMCI for RISC-V [v4]

2022-07-25 Thread Sacha Coppey
> This patch adds a JVMCI implementation for RISC-V. It creates the > jdk.vm.ci.riscv64 and jdk.vm.ci.hotspot.riscv64 packages, as well as > implements a part of jvmciCodeInstaller_riscv64.cpp. To check for > correctness, it enables JVMCI code installation tests on RISC-V. It should be > tested

Re: RFR: 8290154: [JVMCI] Implement JVMCI for RISC-V [v3]

2022-07-25 Thread Sacha Coppey
> This patch adds a JVMCI implementation for RISC-V. It creates the > jdk.vm.ci.riscv64 and jdk.vm.ci.hotspot.riscv64 packages, as well as > implements a part of jvmciCodeInstaller_riscv64.cpp. To check for > correctness, it enables JVMCI code installation tests on RISC-V. It should be > tested

Re: RFR: 8290154: [JVMCI] Implement JVMCI for RISC-V [v2]

2022-07-25 Thread Sacha Coppey
> This patch adds a JVMCI implementation for RISC-V. It creates the > jdk.vm.ci.riscv64 and jdk.vm.ci.hotspot.riscv64 packages, as well as > implements a part of jvmciCodeInstaller_riscv64.cpp. To check for > correctness, it enables JVMCI code installation tests on RISC-V. It should be > tested

Re: RFR: 8290154: [JVMCI] Implement JVMCI for RISC-V

2022-07-25 Thread Fei Yang
On Thu, 21 Jul 2022 10:18:05 GMT, Sacha Coppey wrote: > This patch adds a JVMCI implementation for RISC-V. It creates the > jdk.vm.ci.riscv64 and jdk.vm.ci.hotspot.riscv64 packages, as well as > implements a part of jvmciCodeInstaller_riscv64.cpp. To check for > correctness, it enables JVMCI c