Re: RFR: 8290154: [JVMCI] partially implement JVMCI for RISC-V [v5]

2022-08-22 Thread Fei Yang
On Mon, 22 Aug 2022 16:57:41 GMT, Sacha Coppey wrote: >> src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.riscv64/src/jdk/vm/ci/riscv64/RISCV64Kind.java >> line 54: >> >>> 52: V256_QWORD(32, QWORD), >>> 53: V256_SINGLE(32, SINGLE), >>> 54: V256_DOUBLE(32, DOUBLE); >> >> I see some ve

Re: RFR: 8292716: Configure should check that jtreg is of the required version [v3]

2022-08-22 Thread Erik Joelsson
On Mon, 22 Aug 2022 14:11:32 GMT, Magnus Ihse Bursie wrote: >> While reviewing the PR for >> [JDK-8289798](https://bugs.openjdk.org/browse/JDK-8289798) (switching to >> jtreg 7) I realized that it would be better if configure checked if the >> provided jtreg is of the minimum required version.

Re: RFR: 8290154: [JVMCI] partially implement JVMCI for RISC-V [v5]

2022-08-22 Thread Sacha Coppey
On Mon, 22 Aug 2022 14:05:49 GMT, Fei Yang wrote: >> Sacha Coppey has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Add space in switch > > src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.riscv64/src/jdk/vm/ci/riscv64/RISCV64Kind.java > li

Re: RFR: JDK-8289798: Update to use jtreg 7 [v2]

2022-08-22 Thread Christian Stein
> Please review the change to update to using jtreg 7. > > The primary change is to the `jib-profiles.js` file, which specifies the > version of jtreg to use, for those systems that rely on this file. In > addition, the `requiredVersion` has been updated in the various `TEST.ROOT` > files. Chr

Re: RFR: 8292716: Configure should check that jtreg is of the required version [v3]

2022-08-22 Thread Magnus Ihse Bursie
> While reviewing the PR for > [JDK-8289798](https://bugs.openjdk.org/browse/JDK-8289798) (switching to > jtreg 7) I realized that it would be better if configure checked if the > provided jtreg is of the minimum required version. > > This PR is dependent on https://github.com/openjdk/jdk/pull/

Re: RFR: 8290154: [JVMCI] partially implement JVMCI for RISC-V [v5]

2022-08-22 Thread Fei Yang
On Wed, 27 Jul 2022 11:25:22 GMT, Sacha Coppey wrote: >> This patch adds a partial JVMCI implementation for RISC-V, to allow using >> the GraalVM Native Image RISC-V LLVM backend, which does not use JVMCI for >> code emission. >> It creates the jdk.vm.ci.riscv64 and jdk.vm.ci.hotspot.riscv64 pa

Re: RFR: 8292716: Configure should check that jtreg is of the required version [v2]

2022-08-22 Thread Magnus Ihse Bursie
> While reviewing the PR for > [JDK-8289798](https://bugs.openjdk.org/browse/JDK-8289798) (switching to > jtreg 7) I realized that it would be better if configure checked if the > provided jtreg is of the minimum required version. > > This PR is dependent on https://github.com/openjdk/jdk/pull/

Integrated: 8292717: Clean up checking of testing requirements in configure

2022-08-22 Thread Magnus Ihse Bursie
On Mon, 22 Aug 2022 11:37:40 GMT, Magnus Ihse Bursie wrote: > I have just moved the code around without changing it, with two exceptions: > > * I have updated the names of the functions to match their new home > * I have changed the order in `configure.ac`, so toolchain setup is finished > befo

RFR: 8292716: Configure should check that jtreg is of the required version

2022-08-22 Thread Magnus Ihse Bursie
While reviewing the PR for [JDK-8289798](https://bugs.openjdk.org/browse/JDK-8289798) (switching to jtreg 7) I realized that it would be better if configure checked if the provided jtreg is of the minimum required version. This PR is dependent on https://github.com/openjdk/jdk/pull/9964, so wha

Integrated: 8287828: Fix so that one can select jtreg test case by ID from make

2022-08-22 Thread Leo Korinth
On Sat, 4 Jun 2022 01:51:20 GMT, Leo Korinth wrote: > One can select a testcase by ID when running a jtreg test case directly from > jtreg (using the testcase.java#testID syntax). However, this has not been > possible to do when launching jtreg indirectly from make. > > This fix attempts to ad

Re: RFR: 8290154: [JVMCI] partially implement JVMCI for RISC-V [v6]

2022-08-22 Thread Doug Simon
On Mon, 22 Aug 2022 11:37:52 GMT, Sacha Coppey wrote: >> This patch adds a partial JVMCI implementation for RISC-V, to allow using >> the GraalVM Native Image RISC-V LLVM backend, which does not use JVMCI for >> code emission. >> It creates the jdk.vm.ci.riscv64 and jdk.vm.ci.hotspot.riscv64 pa

Re: RFR: 8292717: Clean up checking of testing requirements in configure

2022-08-22 Thread Erik Joelsson
On Mon, 22 Aug 2022 11:37:40 GMT, Magnus Ihse Bursie wrote: > I have just moved the code around without changing it, with two exceptions: > > * I have updated the names of the functions to match their new home > * I have changed the order in `configure.ac`, so toolchain setup is finished > befo

RFR: 8292717: Clean up checking of testing requirements in configure

2022-08-22 Thread Magnus Ihse Bursie
I have just moved the code around without changing it, with two exceptions: * I have updated the names of the functions to match their new home * I have changed the order in `configure.ac`, so toolchain setup is finished before going on to testing requirements. - Commit messages: -

Re: RFR: 8290154: [JVMCI] partially implement JVMCI for RISC-V [v5]

2022-08-22 Thread Sacha Coppey
On Wed, 27 Jul 2022 11:25:22 GMT, Sacha Coppey wrote: >> This patch adds a partial JVMCI implementation for RISC-V, to allow using >> the GraalVM Native Image RISC-V LLVM backend, which does not use JVMCI for >> code emission. >> It creates the jdk.vm.ci.riscv64 and jdk.vm.ci.hotspot.riscv64 pa

Re: RFR: 8290154: [JVMCI] partially implement JVMCI for RISC-V [v6]

2022-08-22 Thread Sacha Coppey
> This patch adds a partial JVMCI implementation for RISC-V, to allow using the > GraalVM Native Image RISC-V LLVM backend, which does not use JVMCI for code > emission. > It creates the jdk.vm.ci.riscv64 and jdk.vm.ci.hotspot.riscv64 packages, as > well as implements a part of jvmciCodeInstalle

Re: RFR: JDK-8289798: Update to use jtreg 7

2022-08-22 Thread Magnus Ihse Bursie
On Wed, 6 Jul 2022 08:24:21 GMT, Christian Stein wrote: > Please review the change to update to using jtreg 7. > > The primary change is to the `jib-profiles.js` file, which specifies the > version of jtreg to use, for those systems that rely on this file. In > addition, the `requiredVersion`

Integrated: 8292226: Prepare make for better Link Time Optimization support

2022-08-22 Thread Julian Waters
On Thu, 11 Aug 2022 04:18:58 GMT, Julian Waters wrote: > The support for Link Time Optimization in the JDK's make system could do with > some cleaning up, at the moment it simply assumes the compiler is gcc and > sets the flags as such. Instead of introducing changes in bulk, as a first > step

Re: RFR: 8292226: Prepare make for better Link Time Optimization support [v5]

2022-08-22 Thread Magnus Ihse Bursie
On Fri, 12 Aug 2022 16:45:21 GMT, Julian Waters wrote: >> The support for Link Time Optimization in the JDK's make system could do >> with some cleaning up, at the moment it simply assumes the compiler is gcc >> and sets the flags as such. Instead of introducing changes in bulk, as a >> first

Re: RFR: JDK-8289798: Update to use jtreg 7

2022-08-22 Thread Magnus Ihse Bursie
On Wed, 6 Jul 2022 08:24:21 GMT, Christian Stein wrote: > Please review the change to update to using jtreg 7. > > The primary change is to the `jib-profiles.js` file, which specifies the > version of jtreg to use, for those systems that rely on this file. In > addition, the `requiredVersion`