Re: RFR: 8292329: Enable CDS shared heap for zero builds [v2]

2022-08-24 Thread Ioi Lam
On Wed, 24 Aug 2022 06:04:52 GMT, Aleksey Shipilev wrote: >> Ioi Lam has updated the pull request incrementally with one additional >> commit since the last revision: >> >> @shipilev review comments > > Zero can default to G1 after #9994. Together with this patch, it should also > be able to

Integrated: 8292329: Enable CDS shared heap for zero builds

2022-08-24 Thread Ioi Lam
On Tue, 23 Aug 2022 15:56:35 GMT, Ioi Lam wrote: > ZERO uses UseSerialGC by default. When we dump the default CDS archive during > the build process, it fails to dump the shared heap (which requires G1GC). > > The fix is to force -XX:+UseG1GC when dumping the default CDS archive during > the b

Re: RFR: 8292329: Enable CDS shared heap for zero builds [v3]

2022-08-24 Thread Magnus Ihse Bursie
On Wed, 24 Aug 2022 17:41:03 GMT, Ioi Lam wrote: >> ZERO uses UseSerialGC by default. When we dump the default CDS archive >> during the build process, it fails to dump the shared heap (which requires >> G1GC). >> >> The fix is to force -XX:+UseG1GC when dumping the default CDS archive during

Re: RFR: 8292329: Enable CDS shared heap for zero builds [v3]

2022-08-24 Thread Ioi Lam
> ZERO uses UseSerialGC by default. When we dump the default CDS archive during > the build process, it fails to dump the shared heap (which requires G1GC). > > The fix is to force -XX:+UseG1GC when dumping the default CDS archive during > the build process. > > Speed up: > > (Before) > $ perf

Re: RFR: 8292329: Enable CDS shared heap for zero builds [v2]

2022-08-24 Thread Ioi Lam
On Wed, 24 Aug 2022 10:26:36 GMT, Magnus Ihse Bursie wrote: >> Ioi Lam has updated the pull request incrementally with one additional >> commit since the last revision: >> >> @shipilev review comments > > make/Images.gmk line 141: > >> 139: >> 140: $$(eval $$(call SetupExecute, $1_$2_gen_

Re: gold linker issues / devkit ?

2022-08-24 Thread erik . joelsson
On 8/24/22 3:29 AM, Baesken, Matthias wrote: After switching the OpenJDK build to a Fedora devkit  (from non-devkit  Ubuntu based build) , we were running  into issues described here : https://github.com/SAP/SapMachine/issues/1227 and here : https://github.com/eclipse-platform/eclipse.plat

Integrated: 8292816: GPL Classpath exception missing from assemblyprefix.h

2022-08-24 Thread Tyler Steele
On Tue, 23 Aug 2022 21:31:24 GMT, Tyler Steele wrote: > Adds Classpath exception to assemblyprefix.h. Affects copyright header only. This pull request has now been integrated. Changeset: 71ab5c95 Author:Tyler Steele URL: https://git.openjdk.org/jdk/commit/71ab5c95af28497fb31aba8ba95

Re: RFR: 8292816: GPL Classpath exception missing from assemblyprefix.h

2022-08-24 Thread Tyler Steele
On Tue, 23 Aug 2022 21:31:24 GMT, Tyler Steele wrote: > Adds Classpath exception to assemblyprefix.h. Affects copyright header only. Thanks for the reviews - PR: https://git.openjdk.org/jdk/pull/9990

Re: RFR: 8290154: [JVMCI] partially implement JVMCI for RISC-V [v7]

2022-08-24 Thread Fei Yang
On Wed, 24 Aug 2022 07:43:06 GMT, Sacha Coppey wrote: > > I see you added more changes in hotspot file sharedRuntime_riscv.cpp > > guarded by macro INCLUDE_JVMCI. Searching for INCLUDE_JVMCI or > > COMPILER2_OR_JVMCI in src/hotspot/cpu/aarch64, I see several more places > > checking for these

Re: RFR: 8292329: Enable CDS shared heap for zero builds [v2]

2022-08-24 Thread Magnus Ihse Bursie
On Tue, 23 Aug 2022 16:49:01 GMT, Ioi Lam wrote: >> ZERO uses UseSerialGC by default. When we dump the default CDS archive >> during the build process, it fails to dump the shared heap (which requires >> G1GC). >> >> The fix is to force -XX:+UseG1GC when dumping the default CDS archive during

gold linker issues / devkit ?

2022-08-24 Thread Baesken, Matthias
After switching the OpenJDK build to a Fedora devkit (from non-devkit Ubuntu based build) , we were running into issues described here : https://github.com/SAP/SapMachine/issues/1227 and here : https://github.com/eclipse-platform/eclipse.platform.swt/issues/321 When using the gold linker se

Re: RFR: 8292329: Enable CDS shared heap for zero builds [v2]

2022-08-24 Thread Magnus Ihse Bursie
On Tue, 23 Aug 2022 22:49:01 GMT, Erik Joelsson wrote: >> The suggested code should be something like this, note the double `$$` in >> the call. >> >> Suggestion: >> >> $1_$2_CDS_DUMP_FLAGS := $$(CDS_DUMP_FLAGS) >> ifeq ($$(call check-jvm-feature, g1gc), true) >> $1_$2_CDS_DUMP_FLAGS +

Re: RFR: 8292816: GPL Classpath exception missing from assemblyprefix.h

2022-08-24 Thread Magnus Ihse Bursie
On Tue, 23 Aug 2022 21:31:24 GMT, Tyler Steele wrote: > Adds Classpath exception to assemblyprefix.h. Affects copyright header only. Marked as reviewed by ihse (Reviewer). - PR: https://git.openjdk.org/jdk/pull/9990

Re: RFR: 8290154: [JVMCI] partially implement JVMCI for RISC-V [v8]

2022-08-24 Thread Sacha Coppey
On Wed, 24 Aug 2022 08:08:51 GMT, Yadong Wang wrote: >> Sacha Coppey has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Add a comments for the change in deoptimization.hpp > > src/hotspot/cpu/riscv/jvmciCodeInstaller_riscv.cpp line 119: >

Re: RFR: 8290154: [JVMCI] partially implement JVMCI for RISC-V [v9]

2022-08-24 Thread Sacha Coppey
> This patch adds a partial JVMCI implementation for RISC-V, to allow using the > GraalVM Native Image RISC-V LLVM backend, which does not use JVMCI for code > emission. > It creates the jdk.vm.ci.riscv64 and jdk.vm.ci.hotspot.riscv64 packages, as > well as implements a part of jvmciCodeInstalle

Re: RFR: 8290154: [JVMCI] partially implement JVMCI for RISC-V [v8]

2022-08-24 Thread Yadong Wang
On Wed, 24 Aug 2022 07:55:47 GMT, Sacha Coppey wrote: >> This patch adds a partial JVMCI implementation for RISC-V, to allow using >> the GraalVM Native Image RISC-V LLVM backend, which does not use JVMCI for >> code emission. >> It creates the jdk.vm.ci.riscv64 and jdk.vm.ci.hotspot.riscv64 pa

Re: RFR: 8290154: [JVMCI] partially implement JVMCI for RISC-V [v8]

2022-08-24 Thread Sacha Coppey
> This patch adds a partial JVMCI implementation for RISC-V, to allow using the > GraalVM Native Image RISC-V LLVM backend, which does not use JVMCI for code > emission. > It creates the jdk.vm.ci.riscv64 and jdk.vm.ci.hotspot.riscv64 packages, as > well as implements a part of jvmciCodeInstalle

Re: RFR: 8290154: [JVMCI] partially implement JVMCI for RISC-V [v7]

2022-08-24 Thread Sacha Coppey
On Tue, 23 Aug 2022 11:29:45 GMT, Sacha Coppey wrote: >> This patch adds a partial JVMCI implementation for RISC-V, to allow using >> the GraalVM Native Image RISC-V LLVM backend, which does not use JVMCI for >> code emission. >> It creates the jdk.vm.ci.riscv64 and jdk.vm.ci.hotspot.riscv64 pa

Re: RFR: 8290154: [JVMCI] partially implement JVMCI for RISC-V [v7]

2022-08-24 Thread Doug Simon
On Tue, 23 Aug 2022 11:29:45 GMT, Sacha Coppey wrote: >> This patch adds a partial JVMCI implementation for RISC-V, to allow using >> the GraalVM Native Image RISC-V LLVM backend, which does not use JVMCI for >> code emission. >> It creates the jdk.vm.ci.riscv64 and jdk.vm.ci.hotspot.riscv64 pa