Re: RFR: 8293550: Optionally add get-task-allow entitlement to macos binaries [v6]

2022-09-15 Thread Chris Plummer
On Thu, 15 Sep 2022 23:17:39 GMT, Erik Joelsson wrote: >> When signing Macos binaries, it's possible to add various entitlements. We >> already do this for things that Java and the JDK needs when actually signing >> the binaries. >> >> There is a special entitlement

Re: RFR: 8293550: Optionally add get-task-allow entitlement to macos binaries [v6]

2022-09-15 Thread Erik Joelsson
> When signing Macos binaries, it's possible to add various entitlements. We > already do this for things that Java and the JDK needs when actually signing > the binaries. > > There is a special entitlement "com.apple.security.get-task-allow" which is > needed to be able to debug an

Re: RFR: 8293550: Optionally add get-task-allow entitlement to macos binaries [v5]

2022-09-15 Thread Chris Plummer
On Thu, 15 Sep 2022 18:30:46 GMT, Erik Joelsson wrote: >> When signing Macos binaries, it's possible to add various entitlements. We >> already do this for things that Java and the JDK needs when actually signing >> the binaries. >> >> There is a special entitlement

Re: RFR: 8293550: Optionally add get-task-allow entitlement to macos binaries [v3]

2022-09-15 Thread Erik Joelsson
On Thu, 15 Sep 2022 17:27:36 GMT, Erik Joelsson wrote: >> doc/building.md line 908: >> >>> 906: chosen if it works. If nothing works, the codesign step is skipped. >>> Note that on >>> 907: `aarch64`, the Xcode linker will always perform a default `adhoc` >>> signing >>> 908: without any

Re: RFR: 8293550: Optionally add get-task-allow entitlement to macos binaries [v5]

2022-09-15 Thread Erik Joelsson
> When signing Macos binaries, it's possible to add various entitlements. We > already do this for things that Java and the JDK needs when actually signing > the binaries. > > There is a special entitlement "com.apple.security.get-task-allow" which is > needed to be able to debug an

Re: RFR: 8293550: Optionally add get-task-allow entitlement to macos binaries [v3]

2022-09-15 Thread Erik Joelsson
On Thu, 15 Sep 2022 16:50:29 GMT, Magnus Ihse Bursie wrote: >> Erik Joelsson has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Reworked doc text > > doc/building.md line 908: > >> 906: chosen if it works. If nothing works, the codesign

Re: RFR: 8293550: Optionally add get-task-allow entitlement to macos binaries [v3]

2022-09-15 Thread Erik Joelsson
On Thu, 15 Sep 2022 16:37:26 GMT, Magnus Ihse Bursie wrote: >> Erik Joelsson has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Reworked doc text > > make/autoconf/jdk-options.m4 line 716: > >> 714: PARAMS="$1" >> 715: MESSAGE="$2" >>

Re: RFR: 8293550: Optionally add get-task-allow entitlement to macos binaries [v4]

2022-09-15 Thread Erik Joelsson
> When signing Macos binaries, it's possible to add various entitlements. We > already do this for things that Java and the JDK needs when actually signing > the binaries. > > There is a special entitlement "com.apple.security.get-task-allow" which is > needed to be able to debug an

Re: RFR: 8293550: Optionally add get-task-allow entitlement to macos binaries [v3]

2022-09-15 Thread Erik Joelsson
On Thu, 15 Sep 2022 16:41:42 GMT, Magnus Ihse Bursie wrote: >> Erik Joelsson has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Reworked doc text > > make/autoconf/jdk-options.m4 line 750: > >> 748: ENABLED_DEFAULT: true, >> 749:

Re: RFR: 8293550: Optionally add get-task-allow entitlement to macos binaries [v3]

2022-09-15 Thread Magnus Ihse Bursie
On Thu, 15 Sep 2022 13:14:15 GMT, Erik Joelsson wrote: >> When signing Macos binaries, it's possible to add various entitlements. We >> already do this for things that Java and the JDK needs when actually signing >> the binaries. >> >> There is a special entitlement

Re: RFR: 8293550: Optionally add get-task-allow entitlement to macos binaries [v3]

2022-09-15 Thread Magnus Ihse Bursie
On Thu, 15 Sep 2022 13:14:15 GMT, Erik Joelsson wrote: >> When signing Macos binaries, it's possible to add various entitlements. We >> already do this for things that Java and the JDK needs when actually signing >> the binaries. >> >> There is a special entitlement

Re: RFR: 8293550: Optionally add get-task-allow entitlement to macos binaries [v3]

2022-09-15 Thread Magnus Ihse Bursie
On Thu, 15 Sep 2022 13:14:15 GMT, Erik Joelsson wrote: >> When signing Macos binaries, it's possible to add various entitlements. We >> already do this for things that Java and the JDK needs when actually signing >> the binaries. >> >> There is a special entitlement

Re: RFR: 8293550: Optionally add get-task-allow entitlement to macos binaries [v2]

2022-09-15 Thread Erik Joelsson
On Thu, 15 Sep 2022 02:29:29 GMT, Chris Plummer wrote: >> Erik Joelsson has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Comment fix > > doc/building.html line 528: > >> 526: macOS >> 527: On modern versions of macOS, signing and

Re: RFR: 8293550: Optionally add get-task-allow entitlement to macos binaries [v3]

2022-09-15 Thread Erik Joelsson
> When signing Macos binaries, it's possible to add various entitlements. We > already do this for things that Java and the JDK needs when actually signing > the binaries. > > There is a special entitlement "com.apple.security.get-task-allow" which is > needed to be able to debug an

Re: RFR: 8293550: Optionally add get-task-allow entitlement to macos binaries [v2]

2022-09-15 Thread Erik Joelsson
On Thu, 15 Sep 2022 01:50:12 GMT, Chris Plummer wrote: >> Erik Joelsson has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Comment fix > > make/data/macosxsigning/default-debug.plist line 15: > >> 13: com.apple.security.cs.debugger >>

Integrated: 8244681: Add a warning for possibly lossy conversion in compound assignments

2022-09-15 Thread Adam Sotona
On Mon, 9 May 2022 15:56:35 GMT, Adam Sotona wrote: > Please review this patch adding new lint option, **lossy-conversions**, to > javac to warn about type casts in compound assignments with possible lossy > conversions. > > The new lint warning is shown if the type of the right-hand operand