For Oracle internal builds we control the version of GNU Make (currently fixed
at 4.0). In Cygwin this is causing problems as the now rather dated GNU Make
binary we use isn't compatible with Cygwin.dll version 3.3 or later. To work
around this, I'm making the dependency dynamic on the version
On Wed, 12 Oct 2022 17:00:15 GMT, Andrew Haley wrote:
>> A bug in GCC causes shared libraries linked with -ffast-math to disable
>> denormal arithmetic. This breaks Java's floating-point semantics.
>>
>> The bug is https://gcc.gnu.org/bugzilla/show_bug.cgi?id=55522
>>
>> One solution is to
PS And additional expressions could be crashed to rule out
flush-to-zero, treating all subnormals and zero, and other non-compliant
modes of operation.
-Joe
On 10/20/2022 1:05 PM, Joseph D. Darcy wrote:
On 10/20/2022 10:43 AM, Andrew Haley wrote:
On Wed, 12 Oct 2022 17:00:15 GMT, Andrew
On 10/20/2022 10:43 AM, Andrew Haley wrote:
On Wed, 12 Oct 2022 17:00:15 GMT, Andrew Haley wrote:
A bug in GCC causes shared libraries linked with -ffast-math to disable
denormal arithmetic. This breaks Java's floating-point semantics.
The bug is
On Thu, 20 Oct 2022 10:24:28 GMT, Magnus Ihse Bursie wrote:
> After JDK-8294281, it is now possible to disable warnings for individual
> files instead for whole libraries. I used this opportunity to go through all
> disabled warnings in the accessibility native code.
>
> Any warnings that
On Thu, 20 Oct 2022 10:36:08 GMT, Magnus Ihse Bursie wrote:
> After JDK-8294281, it is now possible to disable warnings for individual
> files instead for whole libraries. I used this opportunity to go through all
> disabled warnings in java.desktop native libraries.
>
> Any warnings that
On Thu, 20 Oct 2022 11:58:58 GMT, Magnus Ihse Bursie wrote:
> Properties files is essentially source code. It should have the same
> whitespace checks as all other source code, so we don't get spurious trailing
> whitespace changes.
>
> With the new Skara jcheck, it is possible to increase
On Thu, 20 Oct 2022 11:58:58 GMT, Magnus Ihse Bursie wrote:
> Properties files is essentially source code. It should have the same
> whitespace checks as all other source code, so we don't get spurious trailing
> whitespace changes.
>
> With the new Skara jcheck, it is possible to increase
On Thu, 20 Oct 2022 11:58:58 GMT, Magnus Ihse Bursie wrote:
> Properties files is essentially source code. It should have the same
> whitespace checks as all other source code, so we don't get spurious trailing
> whitespace changes.
>
> With the new Skara jcheck, it is possible to increase
On Thu, 20 Oct 2022 18:06:09 GMT, Erik Joelsson wrote:
>> After JDK-8294281, it is now possible to disable warnings for individual
>> files instead for whole libraries. I used this opportunity to go through all
>> disabled warnings in the accessibility native code.
>>
>> Any warnings that
On Thu, 20 Oct 2022 18:14:45 GMT, Erik Joelsson wrote:
>> After JDK-8294281, it is now possible to disable warnings for individual
>> files instead for whole libraries. I used this opportunity to go through all
>> disabled warnings in java.desktop native libraries.
>>
>> Any warnings that
On Thu, 20 Oct 2022 10:15:50 GMT, Magnus Ihse Bursie wrote:
> After [JDK-8294281](https://bugs.openjdk.org/browse/JDK-8294281), it is now
> possible to disable warnings for individual files instead for whole
> libraries. I used this opportunity to go through all disabled warnings in the
>
On Thu, 20 Oct 2022 11:58:58 GMT, Magnus Ihse Bursie wrote:
> Properties files is essentially source code. It should have the same
> whitespace checks as all other source code, so we don't get spurious trailing
> whitespace changes.
>
> With the new Skara jcheck, it is possible to increase
On Thu, 20 Oct 2022 18:46:04 GMT, Magnus Ihse Bursie wrote:
>> I would vote against this change. Per java properties spec
>> https://github.com/openjdk/jdk/pull/10792
>>
>>
>> White space following the property value is not ignored, and is treated as
>> part of the property value.
>>
>>
>>
On Thu, 20 Oct 2022 18:38:43 GMT, Andy Goryachev wrote:
> `White space following the property value is not ignored, and is treated as
> part of the property value.`
Although I didn't know this was in the spec, I suspected it might be the case.
When looking at the jdk.management.agent changes,
On Thu, 20 Oct 2022 17:54:51 GMT, Chris Plummer wrote:
>> After [JDK-8294281](https://bugs.openjdk.org/browse/JDK-8294281), it is now
>> possible to disable warnings for individual files instead for whole
>> libraries. I used this opportunity to go through all disabled warnings in
>> the
On Thu, 20 Oct 2022 10:28:55 GMT, Magnus Ihse Bursie wrote:
> In `libsctp`, there are a couple of `DISABLED_WARNINGS` that are no longer
> needed to build successfully. These should be removed.
This pull request has now been integrated.
Changeset: de1e0c57
Author:Magnus Ihse Bursie
URL:
On Thu, 20 Oct 2022 18:38:43 GMT, Andy Goryachev wrote:
>> Properties files is essentially source code. It should have the same
>> whitespace checks as all other source code, so we don't get spurious
>> trailing whitespace changes.
>>
>> With the new Skara jcheck, it is possible to increase
On Thu, 20 Oct 2022 11:58:58 GMT, Magnus Ihse Bursie wrote:
> Properties files is essentially source code. It should have the same
> whitespace checks as all other source code, so we don't get spurious trailing
> whitespace changes.
>
> With the new Skara jcheck, it is possible to increase
On Thu, 20 Oct 2022 11:58:58 GMT, Magnus Ihse Bursie wrote:
> Properties files is essentially source code. It should have the same
> whitespace checks as all other source code, so we don't get spurious trailing
> whitespace changes.
>
> With the new Skara jcheck, it is possible to increase
On Thu, 20 Oct 2022 10:28:55 GMT, Magnus Ihse Bursie wrote:
> In `libsctp`, there are a couple of `DISABLED_WARNINGS` that are no longer
> needed to build successfully. These should be removed.
If everything still builds then LGTM too.
-
Marked as reviewed by dfuchs (Reviewer).
On Thu, 20 Oct 2022 10:15:50 GMT, Magnus Ihse Bursie wrote:
> After [JDK-8294281](https://bugs.openjdk.org/browse/JDK-8294281), it is now
> possible to disable warnings for individual files instead for whole
> libraries. I used this opportunity to go through all disabled warnings in the
>
On Thu, 20 Oct 2022 11:58:58 GMT, Magnus Ihse Bursie wrote:
> Properties files is essentially source code. It should have the same
> whitespace checks as all other source code, so we don't get spurious trailing
> whitespace changes.
>
> With the new Skara jcheck, it is possible to increase
On Thu, 20 Oct 2022 11:13:18 GMT, Magnus Ihse Bursie wrote:
>> It would be possible to mark classes with `@sealedGraph` to indicate that
>> the sealed hierarchy should be rendered graphically in the JavaDocs. Classes
>> not marked would be unaffected, creating an opt-in approach.
>>
>>
On Thu, 20 Oct 2022 10:36:08 GMT, Magnus Ihse Bursie wrote:
> After JDK-8294281, it is now possible to disable warnings for individual
> files instead for whole libraries. I used this opportunity to go through all
> disabled warnings in java.desktop native libraries.
>
> Any warnings that
On Thu, 20 Oct 2022 10:28:55 GMT, Magnus Ihse Bursie wrote:
> In `libsctp`, there are a couple of `DISABLED_WARNINGS` that are no longer
> needed to build successfully. These should be removed.
Marked as reviewed by erikj (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/10789
On Thu, 20 Oct 2022 10:24:28 GMT, Magnus Ihse Bursie wrote:
> After JDK-8294281, it is now possible to disable warnings for individual
> files instead for whole libraries. I used this opportunity to go through all
> disabled warnings in the accessibility native code.
>
> Any warnings that
On Wed, 19 Oct 2022 08:15:54 GMT, Sergey Bylokhov wrote:
> The "sizecalc.h" file is moved out from java.desktop/share/native/include,
> the files in that folder appear in the jdk bundle after installation like the
> "jawt.h".
Marked as reviewed by erikj (Reviewer).
-
PR:
On Thu, 20 Oct 2022 10:19:38 GMT, Magnus Ihse Bursie wrote:
> After JDK-8294281, it is now possible to disable warnings for individual
> files instead for whole libraries. I used this opportunity to go through all
> disabled warnings in the security native libraries.
>
> Any warnings that
On Thu, 20 Oct 2022 10:15:50 GMT, Magnus Ihse Bursie wrote:
> After [JDK-8294281](https://bugs.openjdk.org/browse/JDK-8294281), it is now
> possible to disable warnings for individual files instead for whole
> libraries. I used this opportunity to go through all disabled warnings in the
>
On Wed, 12 Oct 2022 17:00:15 GMT, Andrew Haley wrote:
>> A bug in GCC causes shared libraries linked with -ffast-math to disable
>> denormal arithmetic. This breaks Java's floating-point semantics.
>>
>> The bug is https://gcc.gnu.org/bugzilla/show_bug.cgi?id=55522
>>
>> One solution is to
The fixpath.sh script has two "modes", one in which it tries to
autodetect it's environment itself, and one in which the environment
info is fed into it from the caller.
The latter method is used in all real use cases when it is used in the
make files.
You are exercising the first case.
To clarify, you need the added
FIXPATH_ARGS="-e $PATHTOOL -p $WINENV_PREFIX_ARG -r
${WINENV_ROOT//\\/} -t $WINENV_TEMP_DIR -c $CMD -q"
to be sure to get the correct behavior.
/Magnus
On 2022-10-20 17:03, Magnus Ihse Bursie wrote:
The fixpath.sh script has two "modes", one in which it
Yep, just tried the same thing on MSYS, worked like a charm
(Path to fixpath was truncated for easier reading)
$ fixpath print /usr/bin/make
C:\msys64\usr\bin\make
This is going to be pretty frustrating, but I'll take a crack at it to see
if I can wrestle WSL into fixpath, thanks for the link
Properties files is essentially source code. It should have the same whitespace
checks as all other source code, so we don't get spurious trailing whitespace
changes.
With the new Skara jcheck, it is possible to increase the coverage of the
whitespace checks (in the old mercurial version, this
On Wed, 19 Oct 2022 21:00:06 GMT, Jonathan Gibbons wrote:
>> I'm not that familiar with css syntax. Can you be more concrete on how you
>> wish this written?
>
> I'm suggesting something like the following, although I have not explicitly
> tested it:
>
>
> .module-graph span, .sealed-graph
> It would be possible to mark classes with `@sealedGraph` to indicate that the
> sealed hierarchy should be rendered graphically in the JavaDocs. Classes not
> marked would be unaffected, creating an opt-in approach.
>
>
After JDK-8294281, it is now possible to disable warnings for individual files
instead for whole libraries. I used this opportunity to go through all disabled
warnings in java.desktop native libraries.
Any warnings that were only triggered in a few files were removed from the
library as a
On Tue, 27 Sep 2022 16:14:32 GMT, Magnus Ihse Bursie wrote:
> After JDK-8294281, it is now possible to disable warnings for individual
> files instead for whole libraries. I used this opportunity to go through all
> disabled warnings in java.desktop native libraries.
>
> Any warnings that
On Tue, 27 Sep 2022 16:14:32 GMT, Magnus Ihse Bursie wrote:
> After JDK-8294281, it is now possible to disable warnings for individual
> files instead for whole libraries. I used this opportunity to go through all
> disabled warnings in java.desktop native libraries.
>
> Any warnings that
In `libsctp`, there are a couple of `DISABLED_WARNINGS` that are no longer
needed to build successfully. These should be removed.
-
Commit messages:
- 8295719: Remove unneeded disabled warnings in jdk.sctp
Changes: https://git.openjdk.org/jdk/pull/10789/files
Webrev:
After JDK-8294281, it is now possible to disable warnings for individual files
instead for whole libraries. I used this opportunity to go through all disabled
warnings in the accessibility native code.
Any warnings that were only triggered in a few files were removed from the
library as a
After JDK-8294281, it is now possible to disable warnings for individual files
instead for whole libraries. I used this opportunity to go through all disabled
warnings in the security native libraries.
Any warnings that were only triggered in a few files were removed from the
library as a
After [JDK-8294281](https://bugs.openjdk.org/browse/JDK-8294281), it is now
possible to disable warnings for individual files instead for whole libraries.
I used this opportunity to go through all disabled warnings in the
serviceability native libraries.
Any warnings that were only triggered
On Thu, 20 Oct 2022 10:00:14 GMT, Magnus Ihse Bursie wrote:
> We need to transition to use the new `$GITHUB_OUTPUT` method instead.
>
> This needs to be fixed since it is currently spamming the summary with
> warnings, and will stop working soon.
Thanks! Looks fine, provided GHAs are green.
We need to transition to use the new `$GITHUB_OUTPUT` method instead.
This needs to be fixed since it is currently spamming the summary with
warnings, and will stop working soon.
-
Commit messages:
- 8295714: GHA ::set-output is deprecated and will be removed
Changes:
Hi,
Fixpath does not work with WSL paths; historically it was hard to map them
to Windows paths.
This article suggests that it should be easier now:
https://www.howtogeek.com/426749/how-to-access-your-linux-wsl-files-in-windows-10/
I suppose you could give it a try if you're interested.
Regards,
Hi all,
On Windows MakeBase contains a utility to extract Windows paths from Unix
style paths:
# FixPath
#
# On Windows, converts a path from cygwin/unix style (e.g. /bin/foo) into
# "mixed mode" (e.g. c:/cygwin/bin/foo). On other platforms, return the path
# unchanged.
# This also converts a
On Thu, 20 Oct 2022 07:34:29 GMT, Aleksey Shipilev wrote:
> > @shipilev this has broken our linux aarch64 builds!
>
> Whoa. Looking.
That would be: #10781
-
PR: https://git.openjdk.org/jdk/pull/10444
On Thu, 20 Oct 2022 07:14:27 GMT, Aleksey Shipilev wrote:
>> Aleksey Shipilev has updated the pull request with a new target base due to
>> a merge or a rebase. The pull request now contains five commits:
>>
>> - Merge branch 'master' into JDK-8294438-misleading-indentation
>> - Merge branch
On Thu, 20 Oct 2022 07:14:27 GMT, Aleksey Shipilev wrote:
>> Aleksey Shipilev has updated the pull request with a new target base due to
>> a merge or a rebase. The pull request now contains five commits:
>>
>> - Merge branch 'master' into JDK-8294438-misleading-indentation
>> - Merge branch
On Tue, 27 Sep 2022 10:28:54 GMT, Aleksey Shipilev wrote:
> There are number of places where misleading-indentation is reported by GCC.
> Currently, the warning is disabled for the entirety of Hotspot, which is not
> good.
>
> C1 does an unusual style here. Changing it globally would touch a
On Wed, 19 Oct 2022 19:11:42 GMT, Aleksey Shipilev wrote:
>> There are number of places where misleading-indentation is reported by GCC.
>> Currently, the warning is disabled for the entirety of Hotspot, which is not
>> good.
>>
>> C1 does an unusual style here. Changing it globally would
53 matches
Mail list logo
