Re: RFR: JDK-8296149: Start of release updates for JDK 21

2022-11-28 Thread Iris Clark
On Tue, 1 Nov 2022 05:49:25 GMT, Joe Darcy wrote: > Usual start-of-release updates. Symbol updates in initial version reflect JDK > 20 build 21. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.org/jdk/pull/10924

Re: RFR: JDK-8296149: Start of release updates for JDK 21

2022-11-28 Thread Joe Darcy
On Tue, 29 Nov 2022 04:45:57 GMT, David Holmes wrote: >> Usual start-of-release updates. Symbol updates in initial version reflect >> JDK 20 build 21. > > src/java.compiler/share/classes/javax/lang/model/util/AbstractAnnotationValueVisitor14.java > line 47: > >> 45: * @since 14 >> 46: */ >>

Re: RFR: JDK-8296149: Start of release updates for JDK 21

2022-11-28 Thread David Holmes
On Tue, 1 Nov 2022 05:49:25 GMT, Joe Darcy wrote: > Usual start-of-release updates. Symbol updates in initial version reflect JDK > 20 build 21. I looked at everything bar the sym files. All seems fine/usual. One query below (probably one I ask each release). Thanks. src/java.compiler/share/

RFR: JDK-8296149: Start of release updates for JDK 21

2022-11-28 Thread Joe Darcy
Usual start-of-release updates. Symbol updates in initial version reflect JDK 20 build 21. - Commit messages: - Fix failed HotSpot regression tests. - Merge branch 'master' into JDK-8296149 - Update symbol information to JDK 20 build 24. - Merge branch 'master' into JDK-8296149

Re: RFR: JDK-8296149: Start of release updates for JDK 21

2022-11-28 Thread Joe Darcy
On Tue, 1 Nov 2022 05:49:25 GMT, Joe Darcy wrote: > Usual start-of-release updates. Symbol updates in initial version reflect JDK > 20 build 21. Flipping the draft-bit off for this PR ahead of the upcoming start of JDK 21. Symbol information now up-to-date as of JDK 20 b25. - PR:

RFR: 8252584: HotSpot Style Guide should permit alignas

2022-11-28 Thread Julian Waters
Add alignas to the permitted features set with some restrictions. (Thanks @kimbarrett for the help) - Commit messages: - HotSpot Style Guide changes Changes: https://git.openjdk.org/jdk/pull/11404/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=11404&range=00 Issue: https

Integrated: 8296754: AutoCreateSharedArchive in JDK 20 is not compatible with JDK 19

2022-11-28 Thread Matias Saavedra Silva
On Mon, 14 Nov 2022 21:33:23 GMT, Matias Saavedra Silva wrote: > The -XX:+AutoCreateSharedArchive flag was implemented in JDK 19, however, > this flag doesn't work across JDK 19 and 20. > > Expected: JDK 20 should recreate the specified CDS archive > Actual: JDK 20 cannot recognize the archive

Re: RFR: [DRAFT] 8294982: Implementation of Classfile API [v2]

2022-11-28 Thread Adam Sotona
On Sun, 27 Nov 2022 01:38:01 GMT, Erik Gahlin wrote: >> Is the practice of naming the directory `snippets` well-established or >> mandated? Otherwise I think a name like `snippet-files` (akin to >> `doc-files`) would be much better, since it indicates that is not a java >> package name. (These

Re: RFR: [DRAFT] 8294982: Implementation of Classfile API [v2]

2022-11-28 Thread Adam Sotona
> **This pull request is not intended for immediate integration to JDK > mainline.** > > This is root pull request with Classfile API implementation, tests and > benchmarks initial drop into JDK. > > Following pull requests consolidating JDK class files parsing, generating, > and transforming