On Sun, 27 Nov 2022 01:38:01 GMT, Erik Gahlin <egah...@openjdk.org> wrote:
>> Is the practice of naming the directory `snippets` well-established or >> mandated? Otherwise I think a name like `snippet-files` (akin to >> `doc-files`) would be much better, since it indicates that is not a java >> package name. (These do not usually include `-`; I am unsure if this is >> prohibited by the specification, or just not used by convention.) >> >> In fact, when checking, I see that there is already a handful of >> `snippet-files`: >> >> ./jdk.jfr/share/classes/jdk/jfr/snippet-files >> ./jdk.jfr/share/classes/jdk/jfr/consumer/snippet-files >> ./java.compiler/share/classes/javax/tools/snippet-files >> >> >> So maybe rename it to `snippet-files`, and I'll look into making exclusion >> of `snippet-files` be done automatically. > > It would be nice to get the directory excluded (from packaging) by default. I > used the snippet-files name since it was mentioned in the JEP > https://openjdk.org/jeps/413 Snippets moved from `jdk/classfile/snippets` to `jdk/classfile/snippet-files` and explicit exclusion of `jdk/classfile/snippet-files` will be removed when excluded from compilation by default. Thanks! ------------- PR: https://git.openjdk.org/jdk/pull/10982
