On Wed, 4 Jan 2023 06:22:11 GMT, David Holmes wrote:
>> Justin King has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Exclude more zapping when ASan is in use
>>
>> Signed-off-by: Justin King
>
> This doesn't look "too terrible",
On Mon, 9 Jan 2023 22:26:20 GMT, Mikael Vidstedt wrote:
> This pull request contains a clean backport of commit
> [4b6809b9](https://github.com/openjdk/jdk/commit/4b6809b94a09871712df7a1c51b7192adbe2093b)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> The commit being
On Mon, 9 Jan 2023 22:26:20 GMT, Mikael Vidstedt wrote:
> This pull request contains a clean backport of commit
> [4b6809b9](https://github.com/openjdk/jdk/commit/4b6809b94a09871712df7a1c51b7192adbe2093b)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> The commit being
On Fri, 6 Jan 2023 22:23:35 GMT, Matias Saavedra Silva
wrote:
>> This is an enhancement of the test case in
>> [JDK-8296754](https://bugs.openjdk.org/browse/JDK-8296754), which tests
>> against an archive created by the "boot JDK", which is usually set as the
>> previous official JDK release
This pull request contains a clean backport of commit
[4b6809b9](https://github.com/openjdk/jdk/commit/4b6809b94a09871712df7a1c51b7192adbe2093b)
from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
The commit being backported was authored by Mikael Vidstedt on 5 Jan 2023 and
was
On Mon, 9 Jan 2023 17:28:20 GMT, Ichiroh Takiguchi
wrote:
> On Japanese environment, following SHIFT_JIS compatible charsets are there:
> * PCK (x-PCK)
> * MS932 (windows-31j)
> * IBM943C (x-IBM943C)
>
> According to make/data/charsetmapping/charsets,
> PCK and MS932 are independent charset
On Mon, 9 Jan 2023 09:18:52 GMT, Sergey Bylokhov wrote:
> The `GtestImage.gmk` is updated to use separate macro calls in case the
> runtime libraries are not in the same directory.
Thanks for fixing this!
-
Marked as reviewed by erikj (Reviewer).
PR:
On Japanese environment, following SHIFT_JIS compatible charsets are there:
* PCK (x-PCK)
* MS932 (windows-31j)
* IBM943C (x-IBM943C)
According to make/data/charsetmapping/charsets,
PCK and MS932 are independent charset and have no dependencies on others.
On RHEL8, SHIFT_JIS encoding is
On Wed, 4 Jan 2023 06:22:11 GMT, David Holmes wrote:
>> Justin King has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Exclude more zapping when ASan is in use
>>
>> Signed-off-by: Justin King
>
> This doesn't look "too terrible",
On Mon, 9 Jan 2023 08:08:28 GMT, Thomas Stuefe wrote:
> Metaspace changes mostly good. Do the gtests pass? Especially the Metaspace
> fence tests? You need to execute them via the jtreg wrapper
> (test/hotspot/jtreg/gtest) - these wrappers execute the googletest suite with
> a number of
> This change instruments Metaspace for ASan. Metaspace allocates memory using
> `mmap`/`munmap` which ASan is not aware of. Fortunately ASan supports
> applications [manually poisoning/unpoisoning
> memory](https://github.com/google/sanitizers/wiki/AddressSanitizerManualPoisoning).
> ASan is
The `GtestImage.gmk` is updated to use separate macro calls in case the runtime
libraries are not in the same directory.
-
Commit messages:
- 8299789: Compilation of gtest causes build to fail if runtime libraries are
in different dirs
Changes:
> This change instruments Metaspace for ASan. Metaspace allocates memory using
> `mmap`/`munmap` which ASan is not aware of. Fortunately ASan supports
> applications [manually poisoning/unpoisoning
> memory](https://github.com/google/sanitizers/wiki/AddressSanitizerManualPoisoning).
> ASan is
On Mon, 9 Jan 2023 07:39:03 GMT, Thomas Stuefe wrote:
>> Justin King has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Use -fno-common as suggested by ASan docs
>>
>> Signed-off-by: Justin King
>
>
On Mon, 9 Jan 2023 15:57:53 GMT, Justin King wrote:
>> This change instruments Metaspace for ASan. Metaspace allocates memory using
>> `mmap`/`munmap` which ASan is not aware of. Fortunately ASan supports
>> applications [manually poisoning/unpoisoning
>>
> This change instruments Metaspace for ASan. Metaspace allocates memory using
> `mmap`/`munmap` which ASan is not aware of. Fortunately ASan supports
> applications [manually poisoning/unpoisoning
> memory](https://github.com/google/sanitizers/wiki/AddressSanitizerManualPoisoning).
> ASan is
> This change instruments Metaspace for ASan. Metaspace allocates memory using
> `mmap`/`munmap` which ASan is not aware of. Fortunately ASan supports
> applications [manually poisoning/unpoisoning
> memory](https://github.com/google/sanitizers/wiki/AddressSanitizerManualPoisoning).
> ASan is
On Fri, 6 Jan 2023 21:37:35 GMT, Alexandre Iline wrote:
> Update JCov version to 3.0.14
This pull request has now been integrated.
Changeset: bfd59714
Author:Alexandre Iline
URL:
https://git.openjdk.org/jdk/commit/bfd597142945bf87cefe320371b7648d44c6f916
Stats: 1 line in 1 file
On Mon, 9 Jan 2023 08:05:47 GMT, Thomas Stuefe wrote:
>> Ah I see.
>
> I like this, but would compilers not complain about unused statements?
I don't believe so, at least not based on current options. Other projects use
similar tricks, like ABSL_DCHECK from Abseil which short circuits
On Sat, 7 Jan 2023 08:29:26 GMT, Sergey Bylokhov wrote:
> Just a curious, is it possible to release the jcov build on the related jcov
> GitHub page?
This would be a question to @lkuskov
-
PR: https://git.openjdk.org/jdk/pull/11886
On Mon, 9 Jan 2023 06:37:22 GMT, David Holmes wrote:
> All your new files need a copyright and GPL header.
Sorry if I'm being blind but I'm not seeing it. Which file(s) are you referring
to?
The `@test /nodynamiccopyright/` files don't get one per
On Thu, 5 Jan 2023 16:29:13 GMT, Justin King wrote:
>> This change instruments Metaspace for ASan. Metaspace allocates memory using
>> `mmap`/`munmap` which ASan is not aware of. Fortunately ASan supports
>> applications [manually poisoning/unpoisoning
>>
On Thu, 5 Jan 2023 02:53:54 GMT, David Holmes wrote:
>> This helps with maintenance. All builds will still compile the `addr` and
>> `size` statements, ensuring they are valid, but will strip them when ASan is
>> not enabled. In the event that refactoring occurs and one of the statements
>>
23 matches
Mail list logo
