On Tue, 10 Jan 2023 23:17:06 GMT, Justin King wrote:
>> This change instruments Metaspace for ASan. Metaspace allocates memory using
>> `mmap`/`munmap` which ASan is not aware of. Fortunately ASan supports
>> applications [manually poisoning/unpoisoning
>> memory](https://github.com/google/san
On Thu, 12 Jan 2023 05:44:55 GMT, Ioi Lam wrote:
>> Justin King has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update sanitizers/address.h based on review
>>
>> Signed-off-by: Justin King
>
> src/hotspot/share/memory/metaspace/chu
On Tue, 10 Jan 2023 23:17:06 GMT, Justin King wrote:
>> This change instruments Metaspace for ASan. Metaspace allocates memory using
>> `mmap`/`munmap` which ASan is not aware of. Fortunately ASan supports
>> applications [manually poisoning/unpoisoning
>> memory](https://github.com/google/san
On Thu, 12 Jan 2023 03:02:51 GMT, Matias Saavedra Silva
wrote:
>> This is an enhancement of the test case in
>> [JDK-8296754](https://bugs.openjdk.org/browse/JDK-8296754), which tests
>> against an archive created by the "boot JDK", which is usually set as the
>> previous official JDK release
> This is an enhancement of the test case in
> [JDK-8296754](https://bugs.openjdk.org/browse/JDK-8296754), which tests
> against an archive created by the "boot JDK", which is usually set as the
> previous official JDK release when building the JDK repo.
>
> If it's able to acquire previous val
On Thu, 12 Jan 2023 00:15:08 GMT, Maurizio Cimadamore
wrote:
> So, for static methods, it could go down two ways: either we don't even look
> at referenced method bodies, give up and just declare "sorry, escaping". Or,
> if we look into method bodies, and see that the relationship between inne
On Wed, 11 Jan 2023 22:40:43 GMT, Archie L. Cobbs wrote:
>
> D'oh, you're right. But if you made `returnMe()` static or private then the
> argument would still hold.
>
> > And, if the method is static, same story - you are passing ref3 somewhere
> > else, and ref3 potentially contains this.
>
On Wed, 11 Jan 2023 21:51:45 GMT, Maurizio Cimadamore
wrote:
> So, in this example though you are calling an instance method before the
> object is initialized, which would seem to me like a leak
D'oh, you're right. But if you made `returnMe()` static or private then the
argument would still
On Wed, 11 Jan 2023 21:45:20 GMT, Maurizio Cimadamore
wrote:
>> Regarding the assignment graph approach, I think that would work if the
>> references are bouncing around strictly between variables, but what if the
>> chain includes any of the more complicated stuff that is currently being
>>
On Wed, 11 Jan 2023 19:10:04 GMT, Archie L. Cobbs wrote:
>> Good idea. Looks like the difference is in the noise, at least on my Macbook:
>>
>> Builds of master (jdk-21+3-69-gc6588d5bb3f)
>> ==
>>
>> Build times:
>>
>> real 2m24.650s
>> user 13m4
On Wed, 11 Jan 2023 03:30:03 GMT, Archie L. Cobbs wrote:
>> This PR adds a new lint warning category `this-escape`.
>>
>> It also adds `@SuppressWarnings` annotations as needed to the JDK itself to
>> allow the JDK to continue to compile with `-Xlint:all`.
>>
>> A 'this' escape warning is gene
On Wed, 11 Jan 2023 15:59:29 GMT, Maurizio Cimadamore
wrote:
> What I'm interested in though is what incremental improvement is brought by
> the more complex analysis you have in this PR?
It's a good question. Here are some thoughts...
One meta-goal is that this analysis be conservative. In o
On Wed, 11 Jan 2023 18:44:20 GMT, Archie L. Cobbs wrote:
>> Also, looking at the loop test more closely, it seems to me that what the
>> compiler needs to do is to prove that there can be possible paths by which a
>> `this` can land into ref4.
>>
>> If we build a graph of all the assignments,
On Wed, 11 Jan 2023 18:37:01 GMT, Mikael Vidstedt wrote:
> This pull request contains a clean backport of commit
> [a17b563f](https://github.com/openjdk/jdk/commit/a17b563f54b2e0953a1dd9a613e6d5e0e9a8e4cb)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> The commit being b
On Wed, 11 Jan 2023 16:14:24 GMT, Maurizio Cimadamore
wrote:
>> True - probably 3 * 3 can be achieved if this:
>>
>>
>> ThisEscapeLoop ref21 = ref14;
>>
>> Is replaced with
>>
>>
>> ThisEscapeLoop ref21 = this;
>>
>>
>> In which case the inner loop won't converge immediately (a
This pull request contains a clean backport of commit
[a17b563f](https://github.com/openjdk/jdk/commit/a17b563f54b2e0953a1dd9a613e6d5e0e9a8e4cb)
from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
The commit being backported was authored by Mikael Vidstedt on 11 Jan 2023 and
was rev
On Wed, 11 Jan 2023 01:47:11 GMT, Mikael Vidstedt wrote:
> Update the Xcode11.3.1-MacOSX10.15 devkit version used on macOS at Oracle to
> work around an issue on Ventura.
This pull request has now been integrated.
Changeset: a17b563f
Author:Mikael Vidstedt
URL:
https://git.openjdk.
On Tue, 10 Jan 2023 20:48:55 GMT, Coleen Phillimore wrote:
> This change makes native output files be only printed when building with
> LOG=info, to make the build not have so many pages of output.
> Tested with GHA and locally (tbd)
Turning on LOG=info for test-images has reams of information
On Tue, 10 Jan 2023 20:48:55 GMT, Coleen Phillimore wrote:
> This change makes native output files be only printed when building with
> LOG=info, to make the build not have so many pages of output.
> Tested with GHA and locally (tbd)
Hi Erik, I'm so annoyed with this page of messages that I don
On Wed, 11 Jan 2023 14:12:46 GMT, Maurizio Cimadamore
wrote:
>> Actually I think it would take 1 + 1 + 3 iterations.
>>
>> During the first two iterations of the outer loop, nothing changes after the
>> first go round of the inner loop - i.e., the total set of possible
>> references in existe
On Wed, 11 Jan 2023 03:30:03 GMT, Archie L. Cobbs wrote:
>> This PR adds a new lint warning category `this-escape`.
>>
>> It also adds `@SuppressWarnings` annotations as needed to the JDK itself to
>> allow the JDK to continue to compile with `-Xlint:all`.
>>
>> A 'this' escape warning is gene
On Tue, 10 Jan 2023 20:48:55 GMT, Coleen Phillimore wrote:
> This change makes native output files be only printed when building with
> LOG=info, to make the build not have so many pages of output.
> Tested with GHA and locally (tbd)
I'm sorry, but I don't think this is the right solution here.
On Wed, 11 Jan 2023 00:22:03 GMT, Archie L. Cobbs wrote:
>> So, if the code was be like this:
>>
>>
>> ThisEscapeLoop ref11 = this;
>> ThisEscapeLoop ref12 = null;
>> ThisEscapeLoop ref13 = null;
>> ThisEscapeLoop ref14 = null;
>> for (int i = 0; i < 100; i++) {
>> ref14 = ref13;
>> ref
On Tue, 10 Jan 2023 22:44:21 GMT, Sergey Bylokhov wrote:
> Hi all,
> This pull request contains a backport of commit
> [c8a8388a](https://github.com/openjdk/jdk/commit/c8a8388aba3dc121bad04aaa123f6cd7525c3d38)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
> The commit being
On Wed, 11 Jan 2023 01:47:11 GMT, Mikael Vidstedt wrote:
> Update the Xcode11.3.1-MacOSX10.15 devkit version used on macOS at Oracle to
> work around an issue on Ventura.
Marked as reviewed by erikj (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/11932
> MSYS2 should be more appropriately installed into the runner's tool cache
> rather than inside the newly checked out repository containing all the JDK's
> source code, as doing so may interfere with the build process and cause weird
> corner cases in the submitted actions workflow
Julian Wate
26 matches
Mail list logo
