Re: RFR: 8300692: GCC 12 reports some compiler warnings in bundled freetype [v3]

2023-01-20 Thread Dan Lutker
On Fri, 20 Jan 2023 23:47:37 GMT, Dan Lutker wrote: >> Disabling warnings for bundled Freetype > > Dan Lutker has updated the pull request with a new target base due to a merge > or a rebase. The pull request now contains one commit: > > 8300692: GCC 12 reports some compiler warnings in

Re: RFR: 8300806: Update googletest to v1.13.0 [v2]

2023-01-20 Thread Mikael Vidstedt
> Please review this PR which updates the required version of googletest to > v1.13.0. > > It’s been (quite) a while since we upgraded the version of googletest used to > run the hotspot unit tests (test/hotspot/gtest). The current version (1.8.1) > is from 2018 and there is build issue with

Re: RFR: 8300806: Update googletest to v1.13.0 [v2]

2023-01-20 Thread Mikael Vidstedt
On Fri, 20 Jan 2023 23:56:05 GMT, Erik Joelsson wrote: >> Mikael Vidstedt has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update doc/building.html > > doc/building.md line 873: > >> 871: >> 872: * by downloading and unpacking the

Re: RFR: 8300806: Update googletest to v1.13.0

2023-01-20 Thread Erik Joelsson
On Fri, 20 Jan 2023 22:24:32 GMT, Mikael Vidstedt wrote: > Please review this PR which updates the required version of googletest to > v1.13.0. > > It’s been (quite) a while since we upgraded the version of googletest used to > run the hotspot unit tests (test/hotspot/gtest). The current

Re: RFR: 8300692: GCC 12 reports some compiler warnings in bundled freetype [v3]

2023-01-20 Thread Dan Lutker
> Disabling warnings for bundled Freetype Dan Lutker has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. - Changes: - all:

RFR: 8300806: Update googletest to v1.13.0

2023-01-20 Thread Mikael Vidstedt
Please review this PR which updates the required version of googletest to v1.13.0. It’s been (quite) a while since we upgraded the version of googletest used to run the hotspot unit tests (test/hotspot/gtest). The current version (1.8.1) is from 2018 and there is build issue with Xcode 14.x

Re: RFR: 8300692: GCC 12 reports some compiler warnings in bundled freetype [v2]

2023-01-20 Thread Dan Lutker
> Disabling warnings for bundled Freetype Dan Lutker has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:

Re: RFR: 8295795: hsdis does not build with binutils 2.39+

2023-01-20 Thread Erik Joelsson
On Fri, 20 Jan 2023 09:20:59 GMT, Andrew Haley wrote: > So I'm trying to revert my mistaken approval. Do another review with "Request changes" to invalidate your previous approval. - PR: https://git.openjdk.org/jdk/pull/10817

Re: RFR: 8299592: Fix and reenable warnings in java.desktop native code compilation [v2]

2023-01-20 Thread Daniel Jeliński
> Please review this patch that fixes and re-enables a few warnings in libawt > compilation. > > Verified that debug and release builds finish successfully on Win, Mac and > Linux. Also verified that client libs tests still pass. Daniel Jeliński has updated the pull request with a new target

Re: RFR: 8299592: Fix and reenable warnings in java.desktop native code compilation

2023-01-20 Thread Daniel Jeliński
On Wed, 4 Jan 2023 12:44:39 GMT, Daniel Jeliński wrote: > Please review this patch that fixes and re-enables a few warnings in libawt > compilation. > > Verified that debug and release builds finish successfully on Win, Mac and > Linux. Also verified that client libs tests still pass. In

Re: RFR: 8295795: hsdis does not build with binutils 2.39+

2023-01-20 Thread Andrew Haley
On Fri, 21 Oct 2022 15:26:59 GMT, Aleksey Shipilev wrote: > Fails like this: > > > $ sh ./configure --with-boot-jdk=jdk19u-ea --with-hsdis=binutils > --with-binutils-src=binutils-2.39 > $ make clean build-hsdis > > === Output from failing command(s) repeated here === > * For target

Re: RFR: 8295795: hsdis does not build with binutils 2.39+

2023-01-20 Thread Andrew Haley
On Fri, 21 Oct 2022 15:26:59 GMT, Aleksey Shipilev wrote: > Fails like this: > > > $ sh ./configure --with-boot-jdk=jdk19u-ea --with-hsdis=binutils > --with-binutils-src=binutils-2.39 > $ make clean build-hsdis > > === Output from failing command(s) repeated here === > * For target