RFR: 8301129: Link to debuginfo files should only be made after stripping

2023-01-25 Thread Julian Waters
Links to debuginfo files should only be made after strip is run, as doing so before can cause strip to wreck the embedded link and make the executable entirely un-executable in certain strange cases. It's safer to always just make the link after strip is called regardless - Commit

Re: RFR: 8295795: hsdis does not build with binutils 2.39+

2023-01-25 Thread Ludovic Henry
On Fri, 21 Oct 2022 15:26:59 GMT, Aleksey Shipilev wrote: > Fails like this: > > > $ sh ./configure --with-boot-jdk=jdk19u-ea --with-hsdis=binutils > --with-binutils-src=binutils-2.39 > $ make clean build-hsdis > > === Output from failing command(s) repeated here === > * For target

Integrated: 8300806: Update googletest to v1.13.0

2023-01-25 Thread Mikael Vidstedt
On Fri, 20 Jan 2023 22:24:32 GMT, Mikael Vidstedt wrote: > Please review this PR which updates the required version of googletest to > v1.13.0. > > It’s been (quite) a while since we upgraded the version of googletest used to > run the hotspot unit tests (test/hotspot/gtest). The current

Re: RFR: 8300806: Update googletest to v1.13.0 [v4]

2023-01-25 Thread Mikael Vidstedt
On Wed, 25 Jan 2023 18:19:44 GMT, Erik Joelsson wrote: >> Mikael Vidstedt has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update building docs to reflect new minimum gtest requirement > > Marked as reviewed by erikj (Reviewer). Thank

Re: RFR: 8300806: Update googletest to v1.13.0 [v4]

2023-01-25 Thread Erik Joelsson
On Mon, 23 Jan 2023 20:47:32 GMT, Mikael Vidstedt wrote: >> Please review this PR which updates the required version of googletest to >> v1.13.0. >> >> It’s been (quite) a while since we upgraded the version of googletest used >> to run the hotspot unit tests (test/hotspot/gtest). The current

RFR: JDK-8301097: Update GHA XCode to 12.5.1

2023-01-25 Thread Justin King
We are using 11.7 for x86 and 12.4 for aarch64. We should probably be using the same version for both. I assume aarch64 is using a more recent one for better aarch64 support in XCode. 12.4 is not the last release in the 12.x series, that would be 12.5.1, so we should update both to use that.

Integrated: JDK-8300592: ASan build does not correctly propagate options to some test launchers

2023-01-25 Thread Justin King
On Wed, 18 Jan 2023 20:40:40 GMT, Justin King wrote: > Update some custom launchers to set the default ASan options, without it the > tests fail due to incompatibility with LSan. Additionally adds `-fno-common` > for ASan build, as suggested by the docs. This pull request has now been

Re: RFR: JDK-8300592: ASan build does not correctly propagate options to some test launchers [v2]

2023-01-25 Thread Justin King
On Wed, 25 Jan 2023 15:28:14 GMT, Magnus Ihse Bursie wrote: >> Justin King has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Remove extra whitespace >> >>Signed-off-by: Justin King >> - Always link ASan default options to any

Re: RFR: JDK-8300592: ASan build does not correctly propagate options to some test launchers [v3]

2023-01-25 Thread Justin King
> Update some custom launchers to set the default ASan options, without it the > tests fail due to incompatibility with LSan. Additionally adds `-fno-common` > for ASan build, as suggested by the docs. Justin King has updated the pull request incrementally with one additional commit since the

Re: RFR: JDK-8300531: MSVC CFlags look suspicious [v3]

2023-01-25 Thread Justin King
> Update MSVC CFlags to be more consistent with other compilers. Also disables > RTTI in a simliar manner to GCC/Clang for the JVM. Justin King has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by

Re: RFR: JDK-8300592: ASan build does not correctly propagate options to some test launchers [v2]

2023-01-25 Thread Magnus Ihse Bursie
On Mon, 23 Jan 2023 19:39:44 GMT, Justin King wrote: >> Update some custom launchers to set the default ASan options, without it the >> tests fail due to incompatibility with LSan. Additionally adds `-fno-common` >> for ASan build, as suggested by the docs. > > Justin King has updated the pull

Re: RFR: 8294982: Implementation of Classfile API [v8]

2023-01-25 Thread Magnus Ihse Bursie
On Wed, 25 Jan 2023 13:14:43 GMT, Adam Sotona wrote: >> This is root pull request with Classfile API implementation, tests and >> benchmarks initial drop into JDK. >> >> Following pull requests consolidating JDK class files parsing, generating, >> and transforming >>

Re: RFR: 8300805: Update autoconf build-aux files with latest from 2022-09-17

2023-01-25 Thread Erik Joelsson
On Tue, 24 Jan 2023 09:50:01 GMT, Christoph Langer wrote: >> For a long time, we have been stuck with very old versions of the autoconf >> build-aux (config.guess and config.sub) files. Now we have legal approval >> for updating these files to versions 2022-09-17. >> >> I have gone through

Integrated: 8300805: Update autoconf build-aux files with latest from 2022-09-17

2023-01-25 Thread Erik Joelsson
On Mon, 23 Jan 2023 21:50:32 GMT, Erik Joelsson wrote: > For a long time, we have been stuck with very old versions of the autoconf > build-aux (config.guess and config.sub) files. Now we have legal approval for > updating these files to versions 2022-09-17. > > I have gone through all the

Integrated: 8300997: Add curl support to createJMHBundle.sh

2023-01-25 Thread Eirik Bjorsnos
On Tue, 24 Jan 2023 09:39:19 GMT, Eirik Bjorsnos wrote: > Please review this PR which updates make/devkit/createJMHBundle.sh to add > support for curl instead of wget when downloading JMH dependencies. > > This would reduce friction for MacOS devs who would like to run micros > without

Re: RFR: 8294982: Implementation of Classfile API [v8]

2023-01-25 Thread Adam Sotona
> This is root pull request with Classfile API implementation, tests and > benchmarks initial drop into JDK. > > Following pull requests consolidating JDK class files parsing, generating, > and transforming ([JDK-8294957](https://bugs.openjdk.org/browse/JDK-8294957)) > will chain to this one.

Re: RFR: 8294982: Implementation of Classfile API [v7]

2023-01-25 Thread Adam Sotona
On Thu, 12 Jan 2023 12:47:49 GMT, Magnus Ihse Bursie wrote: >> Adam Sotona has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - removal of Preview.java and TransPatterns.java patch >>and enabled preview for java.base >> - jdk.compiler

Re: RFR: 8300997: Add curl support to createJMHBundle.sh

2023-01-25 Thread Eirik Bjorsnos
On Tue, 24 Jan 2023 13:45:37 GMT, Erik Joelsson wrote: >> Please review this PR which updates make/devkit/createJMHBundle.sh to add >> support for curl instead of wget when downloading JMH dependencies. >> >> This would reduce friction for MacOS devs who would like to run micros >> without

Re: RFR: 8300805: Update autoconf build-aux files with latest from 2022-09-17

2023-01-25 Thread Christoph Langer
On Mon, 23 Jan 2023 21:50:32 GMT, Erik Joelsson wrote: > For a long time, we have been stuck with very old versions of the autoconf > build-aux (config.guess and config.sub) files. Now we have legal approval for > updating these files to versions 2022-09-17. > > I have gone through all the