On Thu, 12 Jan 2023 12:47:49 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:
>> Adam Sotona has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - removal of Preview.java and TransPatterns.java patch >> and enabled preview for java.base >> - jdk.compiler ClassWriter patch to avoid writing PREVIEW_MINOR_VERSION to >> classes participating in preview > > make/modules/java.base/Java.gmk line 28: > >> 26: DOCLINT += -Xdoclint:all/protected \ >> 27: '-Xdoclint/package:java.*,javax.*' >> 28: JAVAC_FLAGS += -XDstringConcat=inline > > I think it makes more sense to just have a single `JAVAC_FLAGS` assignment > line, not one per flag. fixed, thanks > make/modules/java.base/Java.gmk line 39: > >> 37: >> 38: EXCLUDES += java/lang/doc-files >> 39: EXCLUDES += jdk/classfile/snippet-files > > ... and the same goes for the `EXCLUDES`. If the line gets longer than 80 > chars, split it like the `COPY` line above. fixed, thanks ------------- PR: https://git.openjdk.org/jdk/pull/10982
