Re: RFR: 8294982: Implementation of Classfile API [v43]

2023-03-03 Thread Paul Sandoz
On Fri, 3 Mar 2023 16:39:41 GMT, Adam Sotona wrote: >> This is root pull request with Classfile API implementation, tests and >> benchmarks initial drop into JDK. >> >> Following pull requests consolidating JDK class files parsing, generating, >> and transforming >> ([JDK-8294957](https://bug

Re: RFR: 8294982: Implementation of Classfile API [v43]

2023-03-03 Thread Paul Sandoz
On Fri, 3 Mar 2023 16:39:41 GMT, Adam Sotona wrote: >> This is root pull request with Classfile API implementation, tests and >> benchmarks initial drop into JDK. >> >> Following pull requests consolidating JDK class files parsing, generating, >> and transforming >> ([JDK-8294957](https://bug

Re: RFR: 8294982: Implementation of Classfile API [v43]

2023-03-03 Thread Paul Sandoz
On Fri, 3 Mar 2023 16:39:41 GMT, Adam Sotona wrote: >> This is root pull request with Classfile API implementation, tests and >> benchmarks initial drop into JDK. >> >> Following pull requests consolidating JDK class files parsing, generating, >> and transforming >> ([JDK-8294957](https://bug

Re: RFR: 8294982: Implementation of Classfile API [v43]

2023-03-03 Thread Paul Sandoz
On Fri, 3 Mar 2023 16:39:41 GMT, Adam Sotona wrote: >> This is root pull request with Classfile API implementation, tests and >> benchmarks initial drop into JDK. >> >> Following pull requests consolidating JDK class files parsing, generating, >> and transforming >> ([JDK-8294957](https://bug

Re: RFR: 8294982: Implementation of Classfile API [v43]

2023-03-03 Thread Paul Sandoz
On Fri, 3 Mar 2023 16:39:41 GMT, Adam Sotona wrote: >> This is root pull request with Classfile API implementation, tests and >> benchmarks initial drop into JDK. >> >> Following pull requests consolidating JDK class files parsing, generating, >> and transforming >> ([JDK-8294957](https://bug

Re: RFR: 8294982: Implementation of Classfile API [v43]

2023-03-03 Thread Paul Sandoz
On Fri, 3 Mar 2023 16:39:41 GMT, Adam Sotona wrote: >> This is root pull request with Classfile API implementation, tests and >> benchmarks initial drop into JDK. >> >> Following pull requests consolidating JDK class files parsing, generating, >> and transforming >> ([JDK-8294957](https://bug

Re: RFR: 8294982: Implementation of Classfile API [v43]

2023-03-03 Thread Paul Sandoz
On Fri, 3 Mar 2023 16:39:41 GMT, Adam Sotona wrote: >> This is root pull request with Classfile API implementation, tests and >> benchmarks initial drop into JDK. >> >> Following pull requests consolidating JDK class files parsing, generating, >> and transforming >> ([JDK-8294957](https://bug

Re: RFR: 8294982: Implementation of Classfile API [v43]

2023-03-03 Thread Paul Sandoz
On Fri, 3 Mar 2023 16:39:41 GMT, Adam Sotona wrote: >> This is root pull request with Classfile API implementation, tests and >> benchmarks initial drop into JDK. >> >> Following pull requests consolidating JDK class files parsing, generating, >> and transforming >> ([JDK-8294957](https://bug

Re: RFR: 8294982: Implementation of Classfile API [v43]

2023-03-03 Thread Paul Sandoz
On Fri, 3 Mar 2023 16:39:41 GMT, Adam Sotona wrote: >> This is root pull request with Classfile API implementation, tests and >> benchmarks initial drop into JDK. >> >> Following pull requests consolidating JDK class files parsing, generating, >> and transforming >> ([JDK-8294957](https://bug

Re: RFR: 8286781: Replace the deprecated/obsolete gethostbyname and inet_addr calls [v2]

2023-03-03 Thread David Holmes
On Fri, 3 Mar 2023 07:30:39 GMT, Kim Barrett wrote: >> David Holmes has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Restrict getaddrinfo to IPv4 only as per the rest of the code > > Looks good. Thanks for the reviews @kimbarrett and @d

Re: RFR: JDK-8301998: Update HarfBuzz to 7.0.1 [v2]

2023-03-03 Thread Harshitha Onkar
On Fri, 3 Mar 2023 20:30:23 GMT, Phil Race wrote: >> Harshitha Onkar has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Updating.txt changes > > src/java.desktop/share/native/libharfbuzz/hb-icu.h line 1: > >> 1: /* > > We don't need/use h

Re: RFR: JDK-8301998: Update HarfBuzz to 7.0.1 [v2]

2023-03-03 Thread Phil Race
On Fri, 3 Mar 2023 20:25:09 GMT, Harshitha Onkar wrote: >> HarfBuzz library updated from v4.4.1 to v7.0.1 >> >> - harfbuzz.md file updated >> - Added -DHB_NO_VISIBILITY to HARFBUZZ_CFLAGS in Awt2DLibraries.gmk to avoid >> build issues on linux and macos targets. >> - GPOS.hh has been moved from

Re: RFR: JDK-8301998: Update HarfBuzz to 7.0.1 [v2]

2023-03-03 Thread Harshitha Onkar
> HarfBuzz library updated from v4.4.1 to v7.0.1 > > - harfbuzz.md file updated > - Added -DHB_NO_VISIBILITY to HARFBUZZ_CFLAGS in Awt2DLibraries.gmk to avoid > build issues on linux and macos targets. > - GPOS.hh has been moved from Layout to Layout/GPOS to match upstream changes. > - Total of 2

RFR: JDK-8301998: Update HarfBuzz to 7.0.1

2023-03-03 Thread Harshitha Onkar
HarfBuzz library updated from v4.4.1 to v7.0.1 - harfbuzz.md file updated - Added -DHB_NO_VISIBILITY to HARFBUZZ_CFLAGS in Awt2DLibraries.gmk to avoid build issues on linux and macos targets. - GPOS.hh has been moved from Layout to Layout/GPOS to match upstream changes. - Total of 270 files chang

Re: RFR: 8303588: [JVMCI] make JVMCI source directories conform with standard layout

2023-03-03 Thread Vladimir Kozlov
On Fri, 3 Mar 2023 17:47:20 GMT, Doug Simon wrote: > The layout of the sources in `jdk.internal.vm.ci` stems from their initial > development outside the JDK where they adopted a layout influenced by Eclipse. > > There's no good reason for maintaining this layout any more. Moving to a > standa

RFR: 8303588: [JVMCI] make JVMCI source directories conform with standard layout

2023-03-03 Thread Doug Simon
The layout of the sources in `jdk.internal.vm.ci` stems from their initial development outside the JDK where they adopted a layout influenced by Eclipse. There's no good reason for maintaining this layout any more. Moving to a standard layout also means IDEs will be able to make sense of the JVM

Re: RFR: 8294982: Implementation of Classfile API [v36]

2023-03-03 Thread Adam Sotona
On Fri, 3 Mar 2023 00:57:35 GMT, Paul Sandoz wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> StackMapFrameInfo extracted to top level from StackMapTableAttribute > > src/java.base/share/classes/jdk/internal/classfil

Re: RFR: 8294982: Implementation of Classfile API [v43]

2023-03-03 Thread Adam Sotona
> This is root pull request with Classfile API implementation, tests and > benchmarks initial drop into JDK. > > Following pull requests consolidating JDK class files parsing, generating, > and transforming ([JDK-8294957](https://bugs.openjdk.org/browse/JDK-8294957)) > will chain to this one. >

Re: RFR: 8294982: Implementation of Classfile API [v36]

2023-03-03 Thread Paul Sandoz
On Fri, 3 Mar 2023 15:50:33 GMT, Adam Sotona wrote: >> src/java.base/share/classes/jdk/internal/classfile/instruction/NewMultiArrayInstruction.java >> line 60: >> >>> 58: static NewMultiArrayInstruction of(ClassEntry arrayTypeEntry, >>> 59:int dimensi

Re: RFR: 8294982: Implementation of Classfile API [v41]

2023-03-03 Thread Adam Sotona
On Fri, 3 Mar 2023 14:14:55 GMT, Jaikiran Pai wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Signature.TypeArg does not inherit from Signature > > src/java.base/share/classes/jdk/internal/classfile/AccessFlags.java

Re: RFR: 8294982: Implementation of Classfile API [v36]

2023-03-03 Thread Adam Sotona
On Thu, 2 Mar 2023 20:54:39 GMT, Paul Sandoz wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> StackMapFrameInfo extracted to top level from StackMapTableAttribute > > src/java.base/share/classes/jdk/internal/classfil

Re: RFR: 8294982: Implementation of Classfile API [v36]

2023-03-03 Thread Adam Sotona
On Thu, 2 Mar 2023 20:37:37 GMT, Paul Sandoz wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> StackMapFrameInfo extracted to top level from StackMapTableAttribute > > src/java.base/share/classes/jdk/internal/classfil

Re: RFR: 8294982: Implementation of Classfile API [v36]

2023-03-03 Thread Adam Sotona
On Fri, 3 Mar 2023 14:53:19 GMT, Adam Sotona wrote: >> src/java.base/share/classes/jdk/internal/classfile/instruction/CharacterRange.java >> line 42: >> >>> 40: * the setting of the {@link Classfile.Option#processDebug(boolean)} >>> option. >>> 41: */ >>> 42: public sealed interface Characte

Re: RFR: 8294982: Implementation of Classfile API [v36]

2023-03-03 Thread Adam Sotona
On Thu, 2 Mar 2023 19:31:50 GMT, Paul Sandoz wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> StackMapFrameInfo extracted to top level from StackMapTableAttribute > > src/java.base/share/classes/jdk/internal/classfil

Re: RFR: 8294982: Implementation of Classfile API [v42]

2023-03-03 Thread Adam Sotona
> This is root pull request with Classfile API implementation, tests and > benchmarks initial drop into JDK. > > Following pull requests consolidating JDK class files parsing, generating, > and transforming ([JDK-8294957](https://bugs.openjdk.org/browse/JDK-8294957)) > will chain to this one. >

Re: RFR: 8294982: Implementation of Classfile API [v36]

2023-03-03 Thread Adam Sotona
On Thu, 2 Mar 2023 19:27:58 GMT, Paul Sandoz wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> StackMapFrameInfo extracted to top level from StackMapTableAttribute > > src/java.base/share/classes/jdk/internal/classfil

Re: RFR: 8294982: Implementation of Classfile API [v41]

2023-03-03 Thread Jaikiran Pai
On Fri, 3 Mar 2023 13:50:15 GMT, Adam Sotona wrote: >> This is root pull request with Classfile API implementation, tests and >> benchmarks initial drop into JDK. >> >> Following pull requests consolidating JDK class files parsing, generating, >> and transforming >> ([JDK-8294957](https://bug

Re: RFR: 8294982: Implementation of Classfile API [v41]

2023-03-03 Thread Adam Sotona
> This is root pull request with Classfile API implementation, tests and > benchmarks initial drop into JDK. > > Following pull requests consolidating JDK class files parsing, generating, > and transforming ([JDK-8294957](https://bugs.openjdk.org/browse/JDK-8294957)) > will chain to this one. >

Re: RFR: 8303480: Miscellaneous fixes to mostly invisible doc comments

2023-03-03 Thread Alexey Ivanov
On Fri, 3 Mar 2023 10:09:27 GMT, Claes Redestad wrote: > Yes, iff means if-and-only-if and is used for extra precision in formal > logic, mathematics. I've never come across it before. With your explanations, it makes perfect sense. - PR: https://git.openjdk.org/jdk/pull/12826

Re: RFR: 8286781: Replace the deprecated/obsolete gethostbyname and inet_addr calls [v2]

2023-03-03 Thread Daniel Jeliński
On Fri, 3 Mar 2023 09:56:35 GMT, David Holmes wrote: >> We can replace `gethostbyname`, which is deprecated on Windows and Linux, >> with `getaddrinfo`. This API is available on all supported platforms and so >> can be placed in shared code. @djelinski pointed out that `getaddrinfo` can >> res

Re: RFR: 8303480: Miscellaneous fixes to mostly invisible doc comments

2023-03-03 Thread Claes Redestad
On Fri, 3 Mar 2023 09:38:13 GMT, Pavel Rappo wrote: >> src/java.base/share/classes/java/lang/invoke/BootstrapMethodInvoker.java >> line 257: >> >>> 255: >>> 256: /** >>> 257: * @return true iff the BSM method type exactly matches >> >> I assume “iff” should “if”? > > Here and elsewhe

Re: RFR: 8286781: Replace the deprecated/obsolete gethostbyname and inet_addr calls [v2]

2023-03-03 Thread David Holmes
> We can replace `gethostbyname`, which is deprecated on Windows and Linux, > with `getaddrinfo`. This API is available on all supported platforms and so > can be placed in shared code. @djelinski pointed out that `getaddrinfo` can > resolve both IP addresses and host names so the two step appro

Re: RFR: 8303480: Miscellaneous fixes to mostly invisible doc comments

2023-03-03 Thread Pavel Rappo
On Fri, 3 Mar 2023 08:15:49 GMT, Alexey Ivanov wrote: >> Please review this superficial documentation cleanup that was triggered by >> unrelated analysis of doc comments in JDK API. >> >> The only effect that this multi-area PR has on the JDK API Documentation >> (i.e. the observable effect on

Re: RFR: 8303480: Miscellaneous fixes to mostly invisible doc comments

2023-03-03 Thread Pavel Rappo
On Thu, 2 Mar 2023 16:23:17 GMT, Alexey Ivanov wrote: >> Please review this superficial documentation cleanup that was triggered by >> unrelated analysis of doc comments in JDK API. >> >> The only effect that this multi-area PR has on the JDK API Documentation >> (i.e. the observable effect on

Re: RFR: 8294982: Implementation of Classfile API [v40]

2023-03-03 Thread Adam Sotona
> This is root pull request with Classfile API implementation, tests and > benchmarks initial drop into JDK. > > Following pull requests consolidating JDK class files parsing, generating, > and transforming ([JDK-8294957](https://bugs.openjdk.org/browse/JDK-8294957)) > will chain to this one. >

Re: RFR: 8294982: Implementation of Classfile API [v39]

2023-03-03 Thread Adam Sotona
> This is root pull request with Classfile API implementation, tests and > benchmarks initial drop into JDK. > > Following pull requests consolidating JDK class files parsing, generating, > and transforming ([JDK-8294957](https://bugs.openjdk.org/browse/JDK-8294957)) > will chain to this one. >

Re: RFR: 8294982: Implementation of Classfile API [v38]

2023-03-03 Thread Adam Sotona
> This is root pull request with Classfile API implementation, tests and > benchmarks initial drop into JDK. > > Following pull requests consolidating JDK class files parsing, generating, > and transforming ([JDK-8294957](https://bugs.openjdk.org/browse/JDK-8294957)) > will chain to this one. >

Re: RFR: 8294982: Implementation of Classfile API [v37]

2023-03-03 Thread Adam Sotona
> This is root pull request with Classfile API implementation, tests and > benchmarks initial drop into JDK. > > Following pull requests consolidating JDK class files parsing, generating, > and transforming ([JDK-8294957](https://bugs.openjdk.org/browse/JDK-8294957)) > will chain to this one. >

Re: RFR: 8303480: Miscellaneous fixes to mostly invisible doc comments

2023-03-03 Thread Alexey Ivanov
On Thu, 2 Mar 2023 12:03:44 GMT, Pavel Rappo wrote: > Please review this superficial documentation cleanup that was triggered by > unrelated analysis of doc comments in JDK API. > > The only effect that this multi-area PR has on the JDK API Documentation > (i.e. the observable effect on the ge