Re: RFR: JDK-8302801: Remove fdlibm C sources [v4]

2023-03-04 Thread Joe Darcy
> While the review of https://github.com/openjdk/jdk/pull/12800 finishes up, I > thought I'd get out for the review the next phase of the FDLIBM port: > removing the FDLIBM C sources from the repo. > > A repo with the changes for JDK-8302027 and this PR successful build on the > default set of

Integrated: 8303588: [JVMCI] make JVMCI source directories conform with standard layout

2023-03-04 Thread Doug Simon
On Fri, 3 Mar 2023 17:47:20 GMT, Doug Simon wrote: > The layout of the sources in `jdk.internal.vm.ci` stems from their initial > development outside the JDK where they adopted a layout influenced by Eclipse. > > There's no good reason for maintaining this layout any more. Moving to a > standa

Re: RFR: 8303588: [JVMCI] make JVMCI source directories conform with standard layout

2023-03-04 Thread Doug Simon
On Fri, 3 Mar 2023 18:02:22 GMT, Vladimir Kozlov wrote: >> The layout of the sources in `jdk.internal.vm.ci` stems from their initial >> development outside the JDK where they adopted a layout influenced by >> Eclipse. >> >> There's no good reason for maintaining this layout any more. Moving t

Re: RFR: 8303588: [JVMCI] make JVMCI source directories conform with standard layout

2023-03-04 Thread Doug Simon
On Fri, 3 Mar 2023 18:02:22 GMT, Vladimir Kozlov wrote: > Please, test it in mach5 Done - please see link in issue. All 6 failures are not related to this change. - PR: https://git.openjdk.org/jdk/pull/12860

Re: RFR: 8295884: Implement IDE support for Eclipse [v36]

2023-03-04 Thread Julian Waters
> Eclipse is a popular and very well-known IDE in the world of Java > development, utilized widely in many contexts, by beginners and experienced > teams alike. Although a relatively lightweight IDE, it features surprisingly > powerful indexing and code analysis capabilities, as well as useful t

Re: RFR: 8295884: Implement IDE support for Eclipse [v35]

2023-03-04 Thread Julian Waters
The message from this sender included one or more files which could not be scanned for virus detection; do not open these files unless you are certain of the sender's intent. -- On Tue, 25 Oct 2022 22:17:25 GMT, Erik Joelsson wro

Re: RFR: 8295884: Implement IDE support for Eclipse [v30]

2023-03-04 Thread Magnus Ihse Bursie
On Tue, 28 Feb 2023 13:06:19 GMT, Julian Waters wrote: > can `REPLACEMENTS` take a Makefile variable that has newlines in it? yes - PR: https://git.openjdk.org/jdk/pull/10853

Re: RFR: 8295884: Implement IDE support for Eclipse [v30]

2023-03-04 Thread Julian Waters
On Mon, 23 Jan 2023 15:11:14 GMT, Magnus Ihse Bursie wrote: >> Oh my god, thanks so much for that pointer, this likely would've been so >> much easier to do, zzz >> >> I'll do that after implementing extracting defines from the command line >> though, to make it less messy > > @TheShermanTanke

Re: RFR: 8295884: Implement IDE support for Eclipse [v35]

2023-03-04 Thread Julian Waters
> Eclipse is a popular and very well-known IDE in the world of Java > development, utilized widely in many contexts, by beginners and experienced > teams alike. Although a relatively lightweight IDE, it features surprisingly > powerful indexing and code analysis capabilities, as well as useful t

Re: RFR: 8295884: Implement IDE support for Eclipse [v34]

2023-03-04 Thread Julian Waters
> Eclipse is a popular and very well-known IDE in the world of Java > development, utilized widely in many contexts, by beginners and experienced > teams alike. Although a relatively lightweight IDE, it features surprisingly > powerful indexing and code analysis capabilities, as well as useful t

Re: RFR: 8302189: Mark assertion failures noreturn [v2]

2023-03-04 Thread Kim Barrett
> Also 8302799: Refactor Debugging variable usage for noreturn crash reporting Kim Barrett has updated the pull request incrementally with one additional commit since the last revision: make Debugging::_enabled a nesting counter - Changes: - all: https://git.openjdk.org/jdk/pul

Re: RFR: 8302189: Mark assertion failures noreturn

2023-03-04 Thread Kim Barrett
On Fri, 3 Mar 2023 04:35:35 GMT, David Holmes wrote: > I don't use these particular debugging mechanism, neither Debugger nor > BREAKPOINT, but it seems potentially problematic to me that the removed > BREAKPOINTs happened after the error was reported, and IIUC the new mechanism > will activat