Re: RFR: JDK-8301998: Update HarfBuzz to 7.0.1 [v2]

2023-03-08 Thread Harshitha Onkar
> HarfBuzz library updated from v4.4.1 to v7.0.1 > > - harfbuzz.md file updated > - Added -DHB_NO_VISIBILITY to HARFBUZZ_CFLAGS in Awt2DLibraries.gmk to avoid > build issues on linux and macos targets. > - GPOS.hh moved to Layout to Layout/GPOS to match upstream changes. > - hb-ot-color-* files

Re: RFR: 8303485: Replacing os.name for operating system customization

2023-03-08 Thread Justin King
Let's please not kill generic BSD support if at all possible. There is NetBSD, OpenBSD, FreeBSD, and DragonflyBSD. I know FreeBSD and NetBSD have OpenJDK 19 and 17 respectively. On Wed, Mar 8, 2023, 6:54 PM David Holmes wrote: > On Wed, 8 Mar 2023 19:15:16 GMT, Roger Riggs wrote: > > >

Re: RFR: 8303485: Replacing os.name for operating system customization

2023-03-08 Thread David Holmes
On Wed, 8 Mar 2023 19:15:16 GMT, Roger Riggs wrote: > Improvements to support OS specific customization for JDK internal use: > - To select values and code; allowing elimination of unused code and values > - Optionally evaluated by build processes, compilation, or archiving (i.e. > CDS) > -

Re: RFR: 8303485: Replacing os.name for operating system customization

2023-03-08 Thread Naoto Sato
On Wed, 8 Mar 2023 19:15:16 GMT, Roger Riggs wrote: > Improvements to support OS specific customization for JDK internal use: > - To select values and code; allowing elimination of unused code and values > - Optionally evaluated by build processes, compilation, or archiving (i.e. > CDS) > -

Re: RFR: 8303485: Replacing os.name for operating system customization

2023-03-08 Thread Mandy Chung
On Wed, 8 Mar 2023 19:15:16 GMT, Roger Riggs wrote: > Improvements to support OS specific customization for JDK internal use: > - To select values and code; allowing elimination of unused code and values > - Optionally evaluated by build processes, compilation, or archiving (i.e. > CDS) > -

Re: RFR: 8303485: Replacing os.name for operating system customization

2023-03-08 Thread Raffaello Giulietti
On Wed, 8 Mar 2023 19:15:16 GMT, Roger Riggs wrote: > Improvements to support OS specific customization for JDK internal use: > - To select values and code; allowing elimination of unused code and values > - Optionally evaluated by build processes, compilation, or archiving (i.e. > CDS) > -

Re: RFR: 8303691: Fedora based devkit build should load more packages from archive location

2023-03-08 Thread Christoph Langer
On Mon, 6 Mar 2023 20:28:22 GMT, Christoph Langer wrote: > When building Fedora based Linux devkits, rpm packages are downloaded from > locations at the Fedora project. > The latest/active versions reside under https://dl.fedoraproject.org while > older, archived versions live at

RFR: 8303485: Replacing os.name for operating system customization

2023-03-08 Thread Roger Riggs
Improvements to support OS specific customization for JDK internal use: - To select values and code; allowing elimination of unused code and values - Optionally evaluated by build processes, compilation, or archiving (i.e. CDS) - Simple API to replace adhoc comparisons with `os.name` - Clear

Re: RFR: 8294982: Implementation of Classfile API [v49]

2023-03-08 Thread Adam Sotona
On Tue, 7 Mar 2023 15:48:58 GMT, Maurizio Cimadamore wrote: >> This is common practise across the whole implementation. Do you suggest to >> remove all similar javadoc from all implementation classes? > > Well, if the javadoc simply states the name of the class it doesn't seem very > useful.

Re: RFR: 8294982: Implementation of Classfile API [v58]

2023-03-08 Thread Adam Sotona
> This is root pull request with Classfile API implementation, tests and > benchmarks initial drop into JDK. > > Following pull requests consolidating JDK class files parsing, generating, > and transforming ([JDK-8294957](https://bugs.openjdk.org/browse/JDK-8294957)) > will chain to this one.

Re: RFR: 8294982: Implementation of Classfile API [v43]

2023-03-08 Thread Adam Sotona
On Tue, 7 Mar 2023 16:06:17 GMT, Paul Sandoz wrote: >> `Long:numberOfLeadingZeros` implementation uses more method calls, >> conditional statements and binary operations. I would prefer to stick with >> the current implementation for its speed and simplicity. > > `numberOfLeadingZeros` is an

Re: RFR: 8294982: Implementation of Classfile API [v57]

2023-03-08 Thread Adam Sotona
> This is root pull request with Classfile API implementation, tests and > benchmarks initial drop into JDK. > > Following pull requests consolidating JDK class files parsing, generating, > and transforming ([JDK-8294957](https://bugs.openjdk.org/browse/JDK-8294957)) > will chain to this one.

Re: RFR: 8294982: Implementation of Classfile API [v56]

2023-03-08 Thread Adam Sotona
> This is root pull request with Classfile API implementation, tests and > benchmarks initial drop into JDK. > > Following pull requests consolidating JDK class files parsing, generating, > and transforming ([JDK-8294957](https://bugs.openjdk.org/browse/JDK-8294957)) > will chain to this one.