RFR: 8304303: implement VirtualThread class notifyJvmti methods as C2 intrinsics

2023-03-15 Thread Serguei Spitsyn
This is needed for performance improvements in support of virtual threads. The update includes the following: 1. Refactored the `VirtualThread` native methods: `notifyJvmtiMountBegin` and `notifyJvmtiMountEnd` => `notifyJvmtiMount` `notifyJvmtiUnmountBegin` and `notifyJvmtiUnmoun

Re: RFR: 8303018: Unicode Emoji Properties [v3]

2023-03-15 Thread Naoto Sato
On Wed, 15 Mar 2023 20:43:22 GMT, Eirik Bjorsnos wrote: > Unrelated side note: Reviewing this PR inspired me to see if one could > generate more efficient switch expressions for the CharacterDataLatin1 > methods as replacement for the property lookup / masking done today. This > seemed to give

Re: RFR: 8303018: Unicode Emoji Properties [v3]

2023-03-15 Thread Eirik Bjorsnos
On Wed, 15 Mar 2023 18:21:11 GMT, Naoto Sato wrote: >> Proposing accessor methods to Emoji properties defined in [Unicode Technical >> Standard #51](https://unicode.org/reports/tr51/) in `java.lang.Character` >> class. This is per a request from the client group, as well as refining the >> cur

Re: RFR: 8301991: Convert l10n properties resource bundles to UTF-8 native

2023-03-15 Thread Naoto Sato
On Thu, 23 Feb 2023 09:04:23 GMT, Justin Lu wrote: > This PR converts Unicode sequences to UTF-8 native in .properties file. > (Excluding the Unicode space and tab sequence). The conversion was done using > native2ascii. > > In addition, the build logic is adjusted to support reading in the >

Re: RFR: 8303018: Unicode Emoji Properties [v3]

2023-03-15 Thread Roger Riggs
On Wed, 15 Mar 2023 18:21:11 GMT, Naoto Sato wrote: >> Proposing accessor methods to Emoji properties defined in [Unicode Technical >> Standard #51](https://unicode.org/reports/tr51/) in `java.lang.Character` >> class. This is per a request from the client group, as well as refining the >> cur

Re: RFR: 8303018: Unicode Emoji Properties [v2]

2023-03-15 Thread Naoto Sato
On Tue, 14 Mar 2023 20:47:55 GMT, Roger Riggs wrote: >> Naoto Sato has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fixed method descriptions > > make/jdk/src/classes/build/tools/generatecharacter/EmojiData.java line 99: > >> 97:

Re: RFR: 8303018: Unicode Emoji Properties [v2]

2023-03-15 Thread Naoto Sato
On Tue, 14 Mar 2023 17:09:54 GMT, Eirik Bjorsnos wrote: >> Naoto Sato has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fixed method descriptions > > make/jdk/src/classes/build/tools/generatecharacter/GenerateCharacter.java > line 215: >

Re: RFR: 8303018: Unicode Emoji Properties [v3]

2023-03-15 Thread Naoto Sato
> Proposing accessor methods to Emoji properties defined in [Unicode Technical > Standard #51](https://unicode.org/reports/tr51/) in `java.lang.Character` > class. This is per a request from the client group, as well as refining the > currently existing ad-hoc emoji implementation in regex. A CS

Integrated: 8302659: Modernize Windows native code for NetworkInterface

2023-03-15 Thread Rich DiCroce
On Thu, 16 Feb 2023 14:32:15 GMT, Rich DiCroce wrote: > Improves performance and correctness, as discussed on the net-dev mailing > list. This pull request has now been integrated. Changeset: 35a29690 Author:Rich DiCroce Committer: Daniel Jeliński URL: https://git.openjdk.org/jdk/

Re: RFR: 8302659: Modernize Windows native code for NetworkInterface [v5]

2023-03-15 Thread Michael McMahon
On Wed, 1 Mar 2023 18:55:05 GMT, Rich DiCroce wrote: >> Improves performance and correctness, as discussed on the net-dev mailing >> list. > > Rich DiCroce has updated the pull request incrementally with one additional > commit since the last revision: > > Revert flag change in ResolverConfi

Re: RFR: 8301991: Convert l10n properties resource bundles to UTF-8 native

2023-03-15 Thread Archie L . Cobbs
On Thu, 23 Feb 2023 09:04:23 GMT, Justin Lu wrote: > This PR converts Unicode sequences to UTF-8 native in .properties file. > (Excluding the Unicode space and tab sequence). The conversion was done using > native2ascii. > > In addition, the build logic is adjusted to support reading in the >

Re: RFR: 8301991: Convert l10n properties resource bundles to UTF-8 native

2023-03-15 Thread Jonathan Gibbons
On Thu, 23 Feb 2023 09:04:23 GMT, Justin Lu wrote: > This PR converts Unicode sequences to UTF-8 native in .properties file. > (Excluding the Unicode space and tab sequence). The conversion was done using > native2ascii. > > In addition, the build logic is adjusted to support reading in the >

Re: RFR: 8301991: Convert l10n properties resource bundles to UTF-8 native

2023-03-15 Thread Justin Lu
On Tue, 7 Mar 2023 23:15:14 GMT, Jonathan Gibbons wrote: >> This PR converts Unicode sequences to UTF-8 native in .properties file. >> (Excluding the Unicode space and tab sequence). The conversion was done >> using native2ascii. >> >> In addition, the build logic is adjusted to support readin

RFR: 8301991: Convert l10n properties resource bundles to UTF-8 native

2023-03-15 Thread Justin Lu
This PR converts Unicode sequences to UTF-8 native in .properties file. (Excluding the Unicode space and tab sequence). The conversion was done using native2ascii. In addition, the build logic is adjusted to support reading in the .properties files as UTF-8 during the conversion from .propertie

Re: Double '$' in jdk/make/RunTests.gmk

2023-03-15 Thread erik . joelsson
Hello Matthias, Double '$' in makefiles is used to escape '$' when called by the $(eval $(call ...)) combination. Care needs to be taken to use either double or single '$' to control when (in which make evaluation phase) a variable or macro call is evaluated. In practice this means that we mai

Double '$' in jdk/make/RunTests.gmk

2023-03-15 Thread Baesken, Matthias
Hi, I noticed a double usage of ‘$’ in jdk/make/RunTests.gmk 800 ifeq ($$(call isTargetOs, windows), true) 801 $1_JTREG_BASIC_OPTIONS += -e:_NT_SYMBOL_PATH Is there some good reason for this, the other call isTargetOs - snippets in the Makefiles do not use $$? Best regards, Ma

Integrated: 8304030: Configure call fails on AIX when using --with-gtest option.

2023-03-15 Thread Arno Zeller
On Tue, 14 Mar 2023 08:08:12 GMT, Arno Zeller wrote: > When calling configure with the --with-gtest option on AIX it fails with the > following error: > ... > checking for X11/Intrinsic.h... yes > checking for gtest... > /sapmnt/sapjvm_work/openjdk/tools/gtest/googletest-1.13.0 This pull reque

Re: RFR: 8304030: Configure call fails on AIX when using --with-gtest option.

2023-03-15 Thread Arno Zeller
On Tue, 14 Mar 2023 08:08:12 GMT, Arno Zeller wrote: > When calling configure with the --with-gtest option on AIX it fails with the > following error: > ... > checking for X11/Intrinsic.h... yes > checking for gtest... > /sapmnt/sapjvm_work/openjdk/tools/gtest/googletest-1.13.0 As far as I can