Re: RFR: 8303229: JFR: Preserve disk repository after exit

2023-03-20 Thread Erik Gahlin
On Tue, 21 Mar 2023 02:02:59 GMT, David Holmes wrote: > @egahlin you to update this with latest master to get DCmd `num_arguments` > changes that went in recently. Will fix. - PR Comment: https://git.openjdk.org/jdk/pull/13111#issuecomment-1477183338

Re: RFR: 8303229: JFR: Preserve disk repository after exit

2023-03-20 Thread David Holmes
On Tue, 21 Mar 2023 01:24:44 GMT, Erik Gahlin wrote: > Hi, > > Could I have a review of an enhancement that adds the option > preserve-repository=true/false to -XX:FlightRecorderOptions and jcmd > JFR.configure. When set to true, chunk files in the repository will not be > removed by the JVM

RFR: 8303229: JFR: Preserve disk repository after exit

2023-03-20 Thread Erik Gahlin
Hi, Could I have a review of an enhancement that adds the option preserve-repository=true/false to -XX:FlightRecorderOptions and jcmd JFR.configure. When set to true, chunk files in the repository will not be removed by the JVM at exit. Testing: jdk/jdk/jfr Thanks Erik - Commit

Re: RFR: 8304265: Implementation of Foreign Function and Memory API (Third Preview)

2023-03-20 Thread Paul Sandoz
On Fri, 17 Mar 2023 15:42:56 GMT, Per Minborg wrote: > API changes for the FFM API (third preview) > > Specdiff: > https://cr.openjdk.org/~pminborg/panama/21/v1/specdiff/overview-summary.html > > Javadoc: > https://cr.openjdk.org/~pminborg/panama/21/v1/javadoc/java.base/module-summary.html src

Re: RFR: 8304265: Implementation of Foreign Function and Memory API (Third Preview)

2023-03-20 Thread Paul Sandoz
On Fri, 17 Mar 2023 15:42:56 GMT, Per Minborg wrote: > API changes for the FFM API (third preview) > > Specdiff: > https://cr.openjdk.org/~pminborg/panama/21/v1/specdiff/overview-summary.html > > Javadoc: > https://cr.openjdk.org/~pminborg/panama/21/v1/javadoc/java.base/module-summary.html src

Re: RFR: 8304265: Implementation of Foreign Function and Memory API (Third Preview)

2023-03-20 Thread Paul Sandoz
On Fri, 17 Mar 2023 15:42:56 GMT, Per Minborg wrote: > API changes for the FFM API (third preview) > > Specdiff: > https://cr.openjdk.org/~pminborg/panama/21/v1/specdiff/overview-summary.html > > Javadoc: > https://cr.openjdk.org/~pminborg/panama/21/v1/javadoc/java.base/module-summary.html src

Re: RFR: 8304265: Implementation of Foreign Function and Memory API (Third Preview)

2023-03-20 Thread Paul Sandoz
On Fri, 17 Mar 2023 15:42:56 GMT, Per Minborg wrote: > API changes for the FFM API (third preview) > > Specdiff: > https://cr.openjdk.org/~pminborg/panama/21/v1/specdiff/overview-summary.html > > Javadoc: > https://cr.openjdk.org/~pminborg/panama/21/v1/javadoc/java.base/module-summary.html src

Re: RFR: 8304434: [AIX] Update minimum xlclang version

2023-03-20 Thread Tyler Steele
On Mon, 20 Mar 2023 20:07:12 GMT, Martin Doerr wrote: >> Minor changes to the build system to recognize and warn that an incompatible >> toolchain is detected. > > LGTM. I think the reason for this PR is another issue? If so, please link the > JBS issues as "relates to". > @MBaesken: Please tak

Re: RFR: 8304265: Implementation of Foreign Function and Memory API (Third Preview)

2023-03-20 Thread Erik Joelsson
On Fri, 17 Mar 2023 15:42:56 GMT, Per Minborg wrote: > API changes for the FFM API (third preview) > > Specdiff: > https://cr.openjdk.org/~pminborg/panama/21/v1/specdiff/overview-summary.html > > Javadoc: > https://cr.openjdk.org/~pminborg/panama/21/v1/javadoc/java.base/module-summary.html Bui

Integrated: 8303018: Unicode Emoji Properties

2023-03-20 Thread Naoto Sato
On Mon, 13 Mar 2023 21:16:24 GMT, Naoto Sato wrote: > Proposing accessor methods to Emoji properties defined in [Unicode Technical > Standard #51](https://unicode.org/reports/tr51/) in `java.lang.Character` > class. This is per a request from the client group, as well as refining the > current

Re: RFR: 8304434: [AIX] Update minimum xlclang version

2023-03-20 Thread Martin Doerr
On Fri, 17 Mar 2023 22:36:24 GMT, Tyler Steele wrote: > Minor changes to the build system to recognize and warn that an incompatible > toolchain is detected. LGTM. I think the reason for this PR is another issue? If so, please link the JBS issues as "relates to". @MBaesken: Please take a look.

Integrated: 8304303: implement VirtualThread class notifyJvmti methods as C2 intrinsics

2023-03-20 Thread Serguei Spitsyn
On Thu, 16 Mar 2023 05:03:51 GMT, Serguei Spitsyn wrote: > This is needed for future performance/scalability improvements in JVMTI > support of virtual threads. > The update includes the following: > > 1. Refactored the `VirtualThread` native methods: > `notifyJvmtiMountBegin` and `noti

RFR: 8304265: Implementation of Foreign Function and Memory API (Third Preview)

2023-03-20 Thread Per Minborg
API changes for the FFM API (third preview) Specdiff: https://cr.openjdk.org/~pminborg/panama/21/v1/specdiff/overview-summary.html Javadoc: https://cr.openjdk.org/~pminborg/panama/21/v1/javadoc/java.base/module-summary.html - Commit messages: - Update after first round of comments

Re: RFR: 8304265: Implementation of Foreign Function and Memory API (Third Preview)

2023-03-20 Thread Maurizio Cimadamore
On Fri, 17 Mar 2023 15:42:56 GMT, Per Minborg wrote: > API changes for the FFM API (third preview) > > Specdiff: > https://cr.openjdk.org/~pminborg/panama/21/v1/specdiff/overview-summary.html > > Javadoc: > https://cr.openjdk.org/~pminborg/panama/21/v1/javadoc/java.base/module-summary.html Her

Re: RFR: 8304265: Implementation of Foreign Function and Memory API (Third Preview)

2023-03-20 Thread ExE Boss
On Fri, 17 Mar 2023 15:42:56 GMT, Per Minborg wrote: > API changes for the FFM API (third preview) > > Specdiff: > https://cr.openjdk.org/~pminborg/panama/21/v1/specdiff/overview-summary.html > > Javadoc: > https://cr.openjdk.org/~pminborg/panama/21/v1/javadoc/java.base/module-summary.html src

Integrated: 8304364: [AIX] Build erroneously determines build disk is non-local when using GNU-utils df on AIX

2023-03-20 Thread Tyler Steele
On Thu, 16 Mar 2023 18:55:34 GMT, Tyler Steele wrote: > The GNU-utils df command supports a flag `-l` which displays information > about local disks only. The AIX df equivalent is `-T local`. However, my > build systems uses GNU-utils on AIX. In this case, the build system uses `df > -T local`

Re: RFR: JDK-8304537: Ant-based langtools build fails after JDK-8015831 Add lint check for calling overridable methods from a constructor [v2]

2023-03-20 Thread Vicente Romero
On Mon, 20 Mar 2023 16:19:19 GMT, Jan Lahoda wrote: >> `this-escape` lint is disabled for jdk.compiler, so it should be disabled >> for the ant-based langtools-only build as well. > > Jan Lahoda has updated the pull request with a new target base due to a merge > or a rebase. The incremental we

Re: RFR: JDK-8304537: Ant-based langtools build fails after JDK-8015831 Add lint check for calling overridable methods from a constructor [v2]

2023-03-20 Thread Erik Joelsson
On Mon, 20 Mar 2023 16:19:19 GMT, Jan Lahoda wrote: >> `this-escape` lint is disabled for jdk.compiler, so it should be disabled >> for the ant-based langtools-only build as well. > > Jan Lahoda has updated the pull request with a new target base due to a merge > or a rebase. The incremental we

Re: RFR: 8304364: [AIX] Build erroneously determines build disk is non-local when using GNU-utils df on AIX

2023-03-20 Thread Tyler Steele
On Thu, 16 Mar 2023 18:55:34 GMT, Tyler Steele wrote: > The GNU-utils df command supports a flag `-l` which displays information > about local disks only. The AIX df equivalent is `-T local`. However, my > build systems uses GNU-utils on AIX. In this case, the build system uses `df > -T local`

Re: RFR: 8304434: [AIX] Update minimum xlclang version

2023-03-20 Thread Tyler Steele
On Fri, 17 Mar 2023 22:36:24 GMT, Tyler Steele wrote: > Minor changes to the build system to recognize and warn that an incompatible > toolchain is detected. Thanks for the review Erik. These changes are pretty close to trivial, but I would still like to get a second review in case there is s

Re: RFR: JDK-8304537: Ant-based langtools build fails after JDK-8015831 Add lint check for calling overridable methods from a constructor [v2]

2023-03-20 Thread Jan Lahoda
> `this-escape` lint is disabled for jdk.compiler, so it should be disabled for > the ant-based langtools-only build as well. Jan Lahoda has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/

Re: RFR: JDK-8304537: Ant-based langtools build fails after JDK-8015831 Add lint check for calling overridable methods from a constructor

2023-03-20 Thread Jan Lahoda
On Mon, 20 Mar 2023 14:50:01 GMT, Jan Lahoda wrote: > `this-escape` lint is disabled for jdk.compiler, so it should be disabled for > the ant-based langtools-only build as well. Thanks, Archie. So, I've: - added a few more @SuppressWarnings, as needed - removed the `this-escape` disablement

Re: RFR: JDK-8304537: Ant-based langtools build fails after JDK-8015831 Add lint check for calling overridable methods from a constructor

2023-03-20 Thread Archie L . Cobbs
On Mon, 20 Mar 2023 14:50:01 GMT, Jan Lahoda wrote: > `this-escape` lint is disabled for jdk.compiler, so it should be disabled for > the ant-based langtools-only build as well. Just a note... the fix for JDK-8304443 adds `@SuppressWarnings("this-escape")` to the compiler code, and that should

Re: RFR: JDK-8304537: Ant-based langtools build fails after JDK-8015831 Add lint check for calling overridable methods from a constructor

2023-03-20 Thread Vicente Romero
On Mon, 20 Mar 2023 14:50:01 GMT, Jan Lahoda wrote: > `this-escape` lint is disabled for jdk.compiler, so it should be disabled for > the ant-based langtools-only build as well. looks good - Marked as reviewed by vromero (Reviewer). PR: https://git.openjdk.org/jdk/pull/13102

RFR: JDK-8304537: Ant-based langtools build fails after JDK-8015831 Add lint check for calling overridable methods from a constructor

2023-03-20 Thread Jan Lahoda
`this-escape` lint is disabled for jdk.compiler, so it should be disabled for the ant-based langtools-only build as well. - Commit messages: - JDK-8304537: Ant-based langtools build fails after JDK-8015831 Add lint check for calling overridable methods from a constructor Changes:

Re: RFR: 8304434: [AIX] Update minimum xlclang version

2023-03-20 Thread Erik Joelsson
On Fri, 17 Mar 2023 22:36:24 GMT, Tyler Steele wrote: > Minor changes to the build system to recognize and warn that an incompatible > toolchain is detected. Marked as reviewed by erikj (Reviewer). - PR: https://git.openjdk.org/jdk/pull/13086

Re: RFR: 8304303: implement VirtualThread class notifyJvmti methods as C2 intrinsics [v4]

2023-03-20 Thread Serguei Spitsyn
On Fri, 17 Mar 2023 10:31:46 GMT, Serguei Spitsyn wrote: >> This is needed for future performance/scalability improvements in JVMTI >> support of virtual threads. >> The update includes the following: >> >> 1. Refactored the `VirtualThread` native methods: >> `notifyJvmtiMountBegin` and

Re: RFR: 8304303: implement VirtualThread class notifyJvmti methods as C2 intrinsics [v4]

2023-03-20 Thread Serguei Spitsyn
On Sat, 18 Mar 2023 11:24:47 GMT, Alan Bateman wrote: > The most important case is when there is no JVMTI env. If I read the changes > correctly, the overhead for park/continue changes from one volatile-read > (notifyJvmtiEvents) to two plain-writes (JavaThread::_is_in_VTMS_transition). > > If