This change fixes or skips some NMT tests when running under ASan, as well as
fixing a leak.
- `allocator_may_return_null=1` is added as the default is `0`, meaning ASan
will never return `nullptr` and will instead crash. NMT tests check that large
allocations return `nullptr` so those do not
On Tue, 28 Mar 2023 13:09:45 GMT, Per Minborg wrote:
>> > src="https://user-images.githubusercontent.com/7457876/228246205-ff2730cb-610f-4673-aa30-d110845a34fc.png;>
>>
>> It belongs to the opening brace for `{@return`. Hard to see with other curls
>> in between.
>
> I would have written:
>
>
On Tue, 28 Mar 2023 13:14:09 GMT, Per Minborg wrote:
>> API changes for the FFM API (third preview)
>>
>> Specdiff:
>> https://cr.openjdk.org/~pminborg/panama/21/v1/specdiff/overview-summary.html
>>
>> Javadoc:
>>
On Tue, 28 Mar 2023 10:07:12 GMT, Per Minborg wrote:
>> src/java.base/share/classes/jdk/internal/foreign/abi/fallback/LibFallback.java
>> line 61:
>>
>>> 59: static final MemorySegment VOID_TYPE =
>>> MemorySegment.ofAddress(ffi_type_void());
>>> 60: static final short STRUCT_TAG =
On Tue, 28 Mar 2023 12:36:28 GMT, Jorn Vernee wrote:
>> src/java.base/share/classes/java/lang/foreign/MemorySegment.java line 2310:
>>
>>> 2308: /**
>>> 2309: * {@return {@code true}, if the provided object is also a
>>> scope, which models the same lifetime as that
>>> 2310:
On Tue, 28 Mar 2023 13:08:22 GMT, Per Minborg wrote:
>> It's to close the text span for the `{@return`
>
> src="https://user-images.githubusercontent.com/7457876/228246205-ff2730cb-610f-4673-aa30-d110845a34fc.png;>
>
> It belongs to the opening brace for `{@return`. Hard to see with other
> API changes for the FFM API (third preview)
>
> Specdiff:
> https://cr.openjdk.org/~pminborg/panama/21/v1/specdiff/overview-summary.html
>
> Javadoc:
> https://cr.openjdk.org/~pminborg/panama/21/v1/javadoc/java.base/module-summary.html
Per Minborg has updated the pull request incrementally
> API changes for the FFM API (third preview)
>
> Specdiff:
> https://cr.openjdk.org/~pminborg/panama/21/v1/specdiff/overview-summary.html
>
> Javadoc:
> https://cr.openjdk.org/~pminborg/panama/21/v1/javadoc/java.base/module-summary.html
Per Minborg has updated the pull request incrementally
On Tue, 28 Mar 2023 11:00:00 GMT, Maurizio Cimadamore
wrote:
>> Per Minborg has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 22 commits:
>>
>> - Merge with master
>> - Make fallbacklinker.c consistent with downcallLinker.cpp
>>
On Tue, 28 Mar 2023 10:56:07 GMT, Per Minborg wrote:
>> API changes for the FFM API (third preview)
>>
>> Specdiff:
>> https://cr.openjdk.org/~pminborg/panama/21/v1/specdiff/overview-summary.html
>>
>> Javadoc:
>>
> API changes for the FFM API (third preview)
>
> Specdiff:
> https://cr.openjdk.org/~pminborg/panama/21/v1/specdiff/overview-summary.html
>
> Javadoc:
> https://cr.openjdk.org/~pminborg/panama/21/v1/javadoc/java.base/module-summary.html
Per Minborg has updated the pull request with a new
> API changes for the FFM API (third preview)
>
> Specdiff:
> https://cr.openjdk.org/~pminborg/panama/21/v1/specdiff/overview-summary.html
>
> Javadoc:
> https://cr.openjdk.org/~pminborg/panama/21/v1/javadoc/java.base/module-summary.html
Per Minborg has updated the pull request incrementally
On Fri, 24 Mar 2023 08:42:37 GMT, ExE Boss wrote:
>> Per Minborg has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Improve javadocs for Linker::captureStateLayout
>
>
On Fri, 24 Mar 2023 08:35:06 GMT, ExE Boss wrote:
>> Per Minborg has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Improve javadocs for Linker::captureStateLayout
>
> src/java.base/share/classes/jdk/internal/foreign/abi/SharedUtils.java
On Tue, 28 Mar 2023 04:40:24 GMT, David Holmes wrote:
> I also added this to JBS:
>
> JDK-8239563 was also done to support Graal, and this change is now undoing
> that. Do the Graal folk who want this understand it will restore the problem
> that JDK-8239563 fixed?
I have no insight as to
15 matches
Mail list logo