Withdrawn: 8295159: DSO created with -ffast-math breaks Java floating-point arithmetic

2023-04-14 Thread duke
On Tue, 11 Oct 2022 16:02:41 GMT, Andrew Haley wrote: > A bug in GCC causes shared libraries linked with -ffast-math to disable > denormal arithmetic. This breaks Java's floating-point semantics. > > The bug is https://gcc.gnu.org/bugzilla/show_bug.cgi?id=55522 > > One solution is to save and

Re: RFR: 8304915: Create jdk.internal.util.Architecture enum and apply [v13]

2023-04-14 Thread Roger Riggs
On Fri, 14 Apr 2023 17:08:10 GMT, Erik Joelsson wrote: >> make/modules/java.base/gensrc/GensrcMisc.gmk line 72: >> >>> 70: endif >>> 71: >>> 72: $(eval $(call SetupTextFileProcessing, BUILD_PLATFORMPROPERTIES_JAVA, \ >> >> @erikj79 Is there a better/good way to do these mappings, or select

Integrated: 8304930: Enable Link Time Optimization as an option for Visual C++

2023-04-14 Thread Julian Waters
On Sun, 2 Apr 2023 07:00:51 GMT, Julian Waters wrote: > Currently, Link Time Optimization is only available for Java Virtual Machines > compiled with gcc. Since the Java VM is the most performance critical part of > the Java Platform for obvious reasons, it follows that optimized executables

Re: RFR: 8304915: Create jdk.internal.util.Architecture enum and apply [v13]

2023-04-14 Thread Erik Joelsson
On Fri, 14 Apr 2023 14:31:31 GMT, Roger Riggs wrote: >> Roger Riggs has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fixed isPPC64(). >> Consolidated switch cases in ArchTest. >> Moved mapping of build TARGET_OS and TARGET_CPU to the

Re: RFR: 8304930: Enable Link Time Optimization as an option for Visual C++ [v2]

2023-04-14 Thread Erik Joelsson
On Fri, 14 Apr 2023 15:32:45 GMT, Julian Waters wrote: >> Currently, Link Time Optimization is only available for Java Virtual >> Machines compiled with gcc. Since the Java VM is the most performance >> critical part of the Java Platform for obvious reasons, it follows that >> optimized

Re: RFR: 8304930: Enable Link Time Optimization as an option for Visual C++ [v2]

2023-04-14 Thread Julian Waters
> Currently, Link Time Optimization is only available for Java Virtual Machines > compiled with gcc. Since the Java VM is the most performance critical part of > the Java Platform for obvious reasons, it follows that optimized executables > produced for Windows (as Visual C++ is currently the

Re: RFR: 8304930: Enable Link Time Optimization as an option for Visual C++

2023-04-14 Thread Julian Waters
On Sun, 2 Apr 2023 07:00:51 GMT, Julian Waters wrote: > Currently, Link Time Optimization is only available for Java Virtual Machines > compiled with gcc. Since the Java VM is the most performance critical part of > the Java Platform for obvious reasons, it follows that optimized executables

Re: RFR: 8304915: Create jdk.internal.util.Architecture enum and apply [v13]

2023-04-14 Thread Roger Riggs
On Wed, 12 Apr 2023 17:31:49 GMT, Roger Riggs wrote: >> Define an internal jdk.internal.util.Architecture enumeration and static >> methods to replace uses of the system property `os.arch`. >> The enumeration values are defined to match those used in the build. >> The initial values are: `X64,

Re: RFR: 8304930: Enable Link Time Optimization as an option for Visual C++

2023-04-14 Thread Erik Joelsson
On Sun, 2 Apr 2023 07:00:51 GMT, Julian Waters wrote: > Currently, Link Time Optimization is only available for Java Virtual Machines > compiled with gcc. Since the Java VM is the most performance critical part of > the Java Platform for obvious reasons, it follows that optimized executables

RFR: 8304930: Enable Link Time Optimization as an option for Visual C++

2023-04-14 Thread Julian Waters
Currently, Link Time Optimization is only available for Java Virtual Machines compiled with gcc. Since the Java VM is the most performance critical part of the Java Platform for obvious reasons, it follows that optimized executables produced for Windows (as Visual C++ is currently the only

Re: RFR: 8305089: Implement missing socket options on AIX [v4]

2023-04-14 Thread Vyom Tewari
On Fri, 14 Apr 2023 07:59:49 GMT, Varada M wrote: >> Breaking this into two parts : >> >> 1. Implementing socket options for AIX >> 2. DontFragmentTest failure >> >> - Implementing socket options for AIX : >> >> Unlike the linux, windows and macOS, AIX uses the default implementation for

Re: RFR: 8305089: Implement missing socket options on AIX [v4]

2023-04-14 Thread Varada M
On Fri, 14 Apr 2023 12:13:39 GMT, Daniel Fuchs wrote: >> Varada M has updated the pull request with a new target base due to a merge >> or a rebase. The pull request now contains six commits: >> >> - Merge branch 'master' into aix_socket_options >> - Updated copyright year >> - Update to

Re: RFR: 8305089: Implement missing socket options on AIX [v5]

2023-04-14 Thread Daniel Fuchs
On Fri, 14 Apr 2023 12:27:30 GMT, Varada M wrote: >> Breaking this into two parts : >> >> 1. Implementing socket options for AIX >> 2. DontFragmentTest failure >> >> - Implementing socket options for AIX : >> >> Unlike the linux, windows and macOS, AIX uses the default implementation for

Re: RFR: 8305089: Implement missing socket options on AIX [v5]

2023-04-14 Thread Varada M
> Breaking this into two parts : > > 1. Implementing socket options for AIX > 2. DontFragmentTest failure > > - Implementing socket options for AIX : > > Unlike the linux, windows and macOS, AIX uses the default implementation for > socket options such as ipDontFragmentSupported(), >

Re: RFR: 8305089: Implement missing socket options on AIX [v4]

2023-04-14 Thread Daniel Fuchs
On Fri, 14 Apr 2023 12:09:48 GMT, Varada M wrote: >> Hello Varada, so the Linux version uses `SO_PEERCRED` socket option and when >> it fails, the error message says "get SO_PEERCRED failed". The AIX version >> uses `SO_PEERID` and if it fails, the current proposed form in this PR will >>

Re: RFR: 8305089: Implement missing socket options on AIX [v4]

2023-04-14 Thread Varada M
On Fri, 14 Apr 2023 11:58:53 GMT, Jaikiran Pai wrote: >> On linux it is implemented from >> [attachListener_linux.cpp](https://github.com/openjdk/jdk/blob/master/src/hotspot/os/linux/attachListener_linux.cpp#L361) >> and on aix it is from >>

Re: RFR: 8305089: Implement missing socket options on AIX [v4]

2023-04-14 Thread Daniel Fuchs
On Fri, 14 Apr 2023 07:59:49 GMT, Varada M wrote: >> Breaking this into two parts : >> >> 1. Implementing socket options for AIX >> 2. DontFragmentTest failure >> >> - Implementing socket options for AIX : >> >> Unlike the linux, windows and macOS, AIX uses the default implementation for

Re: RFR: 8305089: Implement missing socket options on AIX [v4]

2023-04-14 Thread Jaikiran Pai
On Fri, 14 Apr 2023 11:33:13 GMT, Varada M wrote: >> I'm curious, what is the rationale? >> By comparison the Linux version has: >> >> handleError(env, rv, "get SO_PEERCRED failed"); > > On linux it is implemented from >

Re: RFR: 8305089: Implement missing socket options on AIX [v4]

2023-04-14 Thread Varada M
On Fri, 14 Apr 2023 11:27:33 GMT, Daniel Fuchs wrote: >> It is intended > > I'm curious, what is the rationale? > By comparison the Linux version has: > > handleError(env, rv, "get SO_PEERCRED failed"); On linux it is implemented from

Re: RFR: 8305089: Implement missing socket options on AIX [v4]

2023-04-14 Thread Daniel Fuchs
On Fri, 14 Apr 2023 10:52:45 GMT, Varada M wrote: >> src/jdk.net/aix/native/libextnet/AIXSocketOptions.c line 130: >> >>> 128: >>> 129: if ((rv=getsockopt(fd, SOL_SOCKET, SO_PEERID, _info, )) < >>> 0) { >>> 130: handleError(env, rv, "get failed"); >> >> Is the double space after

Re: RFR: 8305089: Implement missing socket options on AIX [v4]

2023-04-14 Thread Varada M
On Fri, 14 Apr 2023 09:10:22 GMT, Daniel Fuchs wrote: >> Varada M has updated the pull request with a new target base due to a merge >> or a rebase. The pull request now contains six commits: >> >> - Merge branch 'master' into aix_socket_options >> - Updated copyright year >> - Update to

Re: RFR: 8305089: Implement missing socket options on AIX [v4]

2023-04-14 Thread Daniel Fuchs
On Fri, 14 Apr 2023 07:59:49 GMT, Varada M wrote: >> Breaking this into two parts : >> >> 1. Implementing socket options for AIX >> 2. DontFragmentTest failure >> >> - Implementing socket options for AIX : >> >> Unlike the linux, windows and macOS, AIX uses the default implementation for

Re: RFR: 8305089: Implement missing socket options on AIX [v4]

2023-04-14 Thread Jaikiran Pai
On Fri, 14 Apr 2023 07:59:49 GMT, Varada M wrote: >> Breaking this into two parts : >> >> 1. Implementing socket options for AIX >> 2. DontFragmentTest failure >> >> - Implementing socket options for AIX : >> >> Unlike the linux, windows and macOS, AIX uses the default implementation for

Re: RFR: 8305089: Implement missing socket options on AIX [v4]

2023-04-14 Thread Daniel JeliƄski
On Fri, 14 Apr 2023 07:59:49 GMT, Varada M wrote: >> Breaking this into two parts : >> >> 1. Implementing socket options for AIX >> 2. DontFragmentTest failure >> >> - Implementing socket options for AIX : >> >> Unlike the linux, windows and macOS, AIX uses the default implementation for

Re: RFR: 8305089: Implement missing socket options on AIX [v4]

2023-04-14 Thread Varada M
> Breaking this into two parts : > > 1. Implementing socket options for AIX > 2. DontFragmentTest failure > > - Implementing socket options for AIX : > > Unlike the linux, windows and macOS, AIX uses the default implementation for > socket options such as ipDontFragmentSupported(), >