Re: RFR: 8305590: Remove nothrow exception specifications from operator new [v2]

2023-04-19 Thread Kim Barrett
On Wed, 19 Apr 2023 14:46:48 GMT, Afshin Zafari wrote: >> src/hotspot/share/prims/jvmtiRawMonitor.hpp line 114: >> >>> 112: >>> 113: // Non-aborting operator new >>> 114: void* operator new(size_t size, const std::nothrow_t& >>> nothrow_constant) throw() { >> >> Hm, now I'm wondering

RFR: 8305669: RuntimeException when running benchmarks through make on Windows/WSL

2023-04-19 Thread Chen Liang
This patch replaces `FIXPATH` with `FixPath` on individual path argumenets. The root cause might be that JMH requires passing VM args to benchmarks in quotes, which might have triggered incorrect detections in `FIXPATH` (as in comparison, `$1_MICRO_JAVA_OPTIONS +=

Re: RFR: 8306408: Fix the format of several tables in building.md [v4]

2023-04-19 Thread Dingli Zhang
> Hi all, > > Currently, the format of several tables in building.md looks a little > problematic and will incorrectly display the split line. In contrast, the > corresponding building.html will display the tables correctly. > > This patch will only change building.md and the format of the

Re: RFR: 8306408: Fix the format of several tables in building.md

2023-04-19 Thread Dingli Zhang
On Wed, 19 Apr 2023 18:34:33 GMT, Erik Joelsson wrote: > > Hi @erikj79 I apologize for a missing change. Could you please run pandoc > > again for me? Thanks for your patience and help! > > Done. Thanks again! - PR Comment:

Re: RFR: 8306408: Fix the format of several tables in building.md

2023-04-19 Thread Erik Joelsson
On Wed, 19 Apr 2023 13:08:31 GMT, Erik Joelsson wrote: >> Hi all, >> >> Currently, the format of several tables in building.md looks a little >> problematic and will incorrectly display the split line. In contrast, the >> corresponding building.html will display the tables correctly. >> >>

Re: RFR: 8304915: Create jdk.internal.util.Architecture enum and apply [v16]

2023-04-19 Thread Roger Riggs
> Define an internal jdk.internal.util.Architecture enumeration and static > methods to replace uses of the system property `os.arch`. > The enumeration values are defined to match those used in the build. > The initial values are: `X64, X86, AARCH64, RISCV64, S390, PPC64` > Note that `amd64` and

Re: RFR: 8304915: Create jdk.internal.util.Architecture enum and apply [v15]

2023-04-19 Thread Amit Kumar
On Mon, 17 Apr 2023 20:59:06 GMT, Roger Riggs wrote: >> Define an internal jdk.internal.util.Architecture enumeration and static >> methods to replace uses of the system property `os.arch`. >> The enumeration values are defined to match those used in the build. >> The initial values are: `X64,

Re: RFR: 8304915: Create jdk.internal.util.Architecture enum and apply [v15]

2023-04-19 Thread Amit Kumar
On Wed, 19 Apr 2023 13:22:54 GMT, Martin Doerr wrote: >> Roger Riggs has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 17 commits: >> >> - Merge branch 'master' into 8304915-arch-enum >> - ArchTest on Debian RISC-V 64 confirmed

Re: RFR: 8306408: Fix the format of several tables in building.md

2023-04-19 Thread Dingli Zhang
On Wed, 19 Apr 2023 13:08:31 GMT, Erik Joelsson wrote: >> Hi all, >> >> Currently, the format of several tables in building.md looks a little >> problematic and will incorrectly display the split line. In contrast, the >> corresponding building.html will display the tables correctly. >> >>

Re: RFR: 8306408: Fix the format of several tables in building.md [v3]

2023-04-19 Thread Dingli Zhang
> Hi all, > > Currently, the format of several tables in building.md looks a little > problematic and will incorrectly display the split line. In contrast, the > corresponding building.html will display the tables correctly. > > This patch will only change building.md and the format of the

Re: RFR: 8306408: Fix the format of several tables in building.md

2023-04-19 Thread Dingli Zhang
On Wed, 19 Apr 2023 13:08:31 GMT, Erik Joelsson wrote: > I see we have this style of tables already present in building.md, so it > should be fine. Generating building.html from this does cause a diff to the > html file, so those still need to go in together. Please find a regenerated >

Re: RFR: 8306408: Fix the format of several tables in building.md [v2]

2023-04-19 Thread Dingli Zhang
> Hi all, > > Currently, the format of several tables in building.md looks a little > problematic and will incorrectly display the split line. In contrast, the > corresponding building.html will display the tables correctly. > > This patch will only change building.md and the format of the

Re: RFR: 8305590: Remove nothrow exception specifications from operator new [v2]

2023-04-19 Thread Afshin Zafari
On Wed, 19 Apr 2023 11:00:32 GMT, Kim Barrett wrote: >> Afshin Zafari has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8305590: Remove nothrow exception specifications from operator new > > src/hotspot/share/prims/jvmtiRawMonitor.hpp

Re: RFR: 8304265: Implementation of Foreign Function and Memory API (Third Preview) [v24]

2023-04-19 Thread Per Minborg
> API changes for the FFM API (third preview) > > ### Specdiff > https://cr.openjdk.org/~pminborg/panama/21/v2/specdiff/overview-summary.html > > ### Javadoc > https://cr.openjdk.org/~pminborg/panama/21/v2/javadoc/api/java.base/java/lang/foreign/package-summary.html > > ### Tests > > - [X]

Re: RFR: 8304915: Create jdk.internal.util.Architecture enum and apply [v15]

2023-04-19 Thread Martin Doerr
On Mon, 17 Apr 2023 20:59:06 GMT, Roger Riggs wrote: >> Define an internal jdk.internal.util.Architecture enumeration and static >> methods to replace uses of the system property `os.arch`. >> The enumeration values are defined to match those used in the build. >> The initial values are: `X64,

Re: RFR: 8306408: Fix the format of several tables in building.md

2023-04-19 Thread Erik Joelsson
On Wed, 19 Apr 2023 02:49:55 GMT, Dingli Zhang wrote: > Hi all, > > Currently, the format of several tables in building.md looks a little > problematic and will incorrectly display the split line. In contrast, the > corresponding building.html will display the tables correctly. > > This

Re: RFR: 8304915: Create jdk.internal.util.Architecture enum and apply [v15]

2023-04-19 Thread Glavo
On Mon, 17 Apr 2023 20:59:06 GMT, Roger Riggs wrote: >> Define an internal jdk.internal.util.Architecture enumeration and static >> methods to replace uses of the system property `os.arch`. >> The enumeration values are defined to match those used in the build. >> The initial values are: `X64,

Re: RFR: 8305590: Remove nothrow exception specifications from operator new [v2]

2023-04-19 Thread David Holmes
On Wed, 19 Apr 2023 10:25:49 GMT, Afshin Zafari wrote: >> - The `throw()` (i.e., no throw) specifications are removed from the >> instances of `operator new` where _do not_ return `nullptr`. >> >> - The `-fcheck-new` is removed from the gcc compile flags. >> >> - The `operator new` and

Re: RFR: 8305590: Remove nothrow exception specifications from operator new [v2]

2023-04-19 Thread Kim Barrett
On Wed, 19 Apr 2023 10:25:49 GMT, Afshin Zafari wrote: >> - The `throw()` (i.e., no throw) specifications are removed from the >> instances of `operator new` where _do not_ return `nullptr`. >> >> - The `-fcheck-new` is removed from the gcc compile flags. >> >> - The `operator new` and

Re: RFR: 8305590: Remove nothrow exception specifications from operator new [v2]

2023-04-19 Thread Afshin Zafari
On Tue, 18 Apr 2023 18:59:31 GMT, Kim Barrett wrote: >> src/hotspot/share/runtime/thread.hpp line 203: >> >>> 201: static bool is_JavaThread_protected_by_TLH(const JavaThread* target); >>> 202: >>> 203: void operator delete(void* p); >> >> Should you have removed delete and

Re: RFR: 8305590: Remove nothrow exception specifications from operator new [v2]

2023-04-19 Thread Afshin Zafari
On Tue, 18 Apr 2023 18:29:13 GMT, Kim Barrett wrote: >> Afshin Zafari has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8305590: Remove nothrow exception specifications from operator new > > src/hotspot/share/memory/allocation.hpp line

Re: RFR: 8305590: Remove nothrow exception specifications from operator new [v2]

2023-04-19 Thread Afshin Zafari
> - The `throw()` (i.e., no throw) specifications are removed from the > instances of `operator new` where _do not_ return `nullptr`. > > - The `-fcheck-new` is removed from the gcc compile flags. > > - The `operator new` and `operator delete` are deleted from `StackObj`. > > - The

Re: RFR: 8304265: Implementation of Foreign Function and Memory API (Third Preview) [v23]

2023-04-19 Thread Andrey Turbanov
On Thu, 13 Apr 2023 06:36:51 GMT, Per Minborg wrote: >> API changes for the FFM API (third preview) >> >> ### Specdiff >> https://cr.openjdk.org/~pminborg/panama/21/v2/specdiff/overview-summary.html >> >> ### Javadoc >>