Re: RFR: 8289735: UTIL_LOOKUP_PROGS fails on pathes with space [v2]

2023-04-24 Thread Erik Joelsson
On Mon, 24 Apr 2023 21:44:00 GMT, Christoph Langer wrote: >> This is an attempt to fix the issue on Windows when no cygwin Git is >> installed or the Git for Windows installation has precedence in PATH lookup. >> The path to the Windows GIT installation usually resides in `C:\Program >>

Re: RFR: 8289735: UTIL_LOOKUP_PROGS fails on pathes with space [v2]

2023-04-24 Thread Christoph Langer
> This is an attempt to fix the issue on Windows when no cygwin Git is > installed or the Git for Windows installation has precedence in PATH lookup. > The path to the Windows GIT installation usually resides in `C:\Program > Files` which contains a space and thus needs some special handling. >

Re: RFR: 8289735: UTIL_LOOKUP_PROGS fails on pathes with space

2023-04-24 Thread Christoph Langer
On Mon, 24 Apr 2023 21:04:50 GMT, Erik Joelsson wrote: > I think this change makes sense. Given how small this set of tools is now, I > think we should add a comment on `PLATFORM_SETUP_OPENJDK_BUILD_AND_TARGET` in > platform.m4 saying something about needing to be careful to only use tools >

Re: RFR: 8289735: UTIL_LOOKUP_PROGS fails on pathes with space

2023-04-24 Thread Erik Joelsson
On Mon, 24 Apr 2023 20:11:50 GMT, Christoph Langer wrote: > This is an attempt to fix the issue on Windows when no cygwin Git is > installed or the Git for Windows installation has precedence in PATH lookup. > The path to the Windows GIT installation usually resides in `C:\Program > Files`

RFR: 8289735: UTIL_LOOKUP_PROGS fails on pathes with space

2023-04-24 Thread Christoph Langer
This is an attempt to fix the issue on Windows when no cygwin Git is installed or the Git for Windows installation has precedence in PATH lookup. The path to the Windows GIT installation usually resides in `C:\Program Files` which contains a space and thus needs some special handling. There

Integrated: 8304896: Update to use jtreg 7.2

2023-04-24 Thread Christian Stein
On Mon, 17 Apr 2023 14:56:16 GMT, Christian Stein wrote: > Please review the change to update to using jtreg 7.2. > > The primary change is to the `jib-profiles.js` file, which specifies the > version of jtreg to use, for those systems that rely on this file. In > addition, the

Integrated: 8306658: GHA: MSVC installation could be optional since it might already be pre-installed

2023-04-24 Thread Christoph Langer
On Fri, 21 Apr 2023 06:56:43 GMT, Christoph Langer wrote: > We figured that seemingly the correct toolchain could be (and is) already > installed by default on Github runners and it makes sense to skip the > expensive installation operation which takes some 10+ minutes. > > I also tested the

Re: RFR: 8304986: Upcall stubs should support capureCallState

2023-04-24 Thread Jorn Vernee
On Fri, 21 Apr 2023 18:25:32 GMT, Jorn Vernee wrote: > Implement captureCallState support for upcall stubs. > > The method handle of an upcall stub linked with this linker option has an > additional leading memory segment parameter into which the capture state > (e.g. errno) should be

Withdrawn: 8304986: Upcall stubs should support capureCallState

2023-04-24 Thread Jorn Vernee
On Fri, 21 Apr 2023 18:25:32 GMT, Jorn Vernee wrote: > Implement captureCallState support for upcall stubs. > > The method handle of an upcall stub linked with this linker option has an > additional leading memory segment parameter into which the capture state > (e.g. errno) should be

Re: RFR: 8304915: Create jdk.internal.util.Architecture enum and apply [v17]

2023-04-24 Thread Martin Doerr
On Fri, 21 Apr 2023 20:26:12 GMT, Roger Riggs wrote: >> Define an internal jdk.internal.util.Architecture enumeration and static >> methods to replace uses of the system property `os.arch`. >> The enumeration values are defined to match those used in the build. >> The initial values are: `X64,

Re: RFR: 8306658: GHA: MSVC installation could be optional since it might already be pre-installed [v3]

2023-04-24 Thread Goetz Lindenmaier
On Fri, 21 Apr 2023 12:21:39 GMT, Christoph Langer wrote: >> We figured that seemingly the correct toolchain could be (and is) already >> installed by default on Github runners and it makes sense to skip the >> expensive installation operation which takes some 10+ minutes. >> >> I also tested

Re: RFR: 8304986: Upcall stubs should support capureCallState

2023-04-24 Thread ExE Boss
On Fri, 21 Apr 2023 18:25:32 GMT, Jorn Vernee wrote: > Implement captureCallState support for upcall stubs. > > The method handle of an upcall stub linked with this linker option has an > additional leading memory segment parameter into which the capture state > (e.g. errno) should be

Re: RFR: 8304986: Upcall stubs should support capureCallState

2023-04-24 Thread Jorn Vernee
On Fri, 21 Apr 2023 18:25:32 GMT, Jorn Vernee wrote: > Implement captureCallState support for upcall stubs. > > The method handle of an upcall stub linked with this linker option has an > additional leading memory segment parameter into which the capture state > (e.g. errno) should be

RFR: 8304986: Upcall stubs should support capureCallState

2023-04-24 Thread Jorn Vernee
Implement captureCallState support for upcall stubs. The method handle of an upcall stub linked with this linker option has an additional leading memory segment parameter into which the capture state (e.g. errno) should be written. After returning from Java, this value is then actually written