> The option
> CreateCoredumpOnCrash
> is enabled by default except the Windows client systems with release
> binaries.
>
> So it makes sense to switch it on explicitly in makefiles on Windows while
> testing. It still could be redefined by adding '-XX-CreateCoredumpOnCrash' as
> jtreg
On Thu, 27 Jul 2023 03:41:24 GMT, Leonid Mesnik wrote:
> The option
> CreateCoredumpOnCrash
> is enabled by default except the Windows client systems with release
> binaries.
>
> So it makes sense to switch it on explicitly in makefiles on Windows while
> testing. It still could be redefined
The option
CreateCoredumpOnCrash
is enabled by default except the Windows client systems with release binaries.
So it makes sense to switch it on explicitly in makefiles on Windows while
testing. It still could be redefined by adding '-XX-CreateCoredumpOnCrash' as
jtreg -vmoption if needed.
On Wed, 26 Jul 2023 14:18:49 GMT, Matthias Baesken wrote:
> > OTOH, this cleanup could be done in another PR. For now, the code as it is
> > would be ok, too.
>
> I agree, let's do the flags / macro adjustment in another issue. Andreas, I
> can open one for you if you want.
I would prefer to
On Wed, 26 Jul 2023 14:15:25 GMT, Christoph Langer wrote:
> OTOH, this cleanup could be done in another PR. For now, the code as it is
> would be ok, too.
I agree, let's do the flags / macro adjustment in another issue. Andreas, I can
open one for you if you want.
-
PR Comment:
On Wed, 26 Jul 2023 10:29:25 GMT, Andreas Steiner wrote:
>> On AIX the 'nm' needs -X64 option.
>
> Andreas Steiner has updated the pull request incrementally with one
> additional commit since the last revision:
>
> correction of comment
No, I don't think flags-other.m4 is suited. If at
On Wed, 26 Jul 2023 10:29:25 GMT, Andreas Steiner wrote:
>> On AIX the 'nm' needs -X64 option.
>
> Andreas Steiner has updated the pull request incrementally with one
> additional commit since the last revision:
>
> correction of comment
Rather than toolchain.m4, this might actually be
On Wed, 26 Jul 2023 12:10:51 GMT, David Holmes wrote:
> I don't think this is the right place to make this change. Shouldn't it be
> handled at configure time in ./autoconf/toolchain.m4 ? There is also a
> BUILD_NM variable that will not be fixed by the proposed change.
Currently all needed
On Wed, 26 Jul 2023 10:29:25 GMT, Andreas Steiner wrote:
>> On AIX the 'nm' needs -X64 option.
>
> Andreas Steiner has updated the pull request incrementally with one
> additional commit since the last revision:
>
> correction of comment
I agree, this should be handled in toochain.m4
On Wed, 26 Jul 2023 10:29:25 GMT, Andreas Steiner wrote:
>> On AIX the 'nm' needs -X64 option.
>
> Andreas Steiner has updated the pull request incrementally with one
> additional commit since the last revision:
>
> correction of comment
I don't think this is the right place to make this
On Wed, 26 Jul 2023 10:29:25 GMT, Andreas Steiner wrote:
>> On AIX the 'nm' needs -X64 option.
>
> Andreas Steiner has updated the pull request incrementally with one
> additional commit since the last revision:
>
> correction of comment
+1
-
Marked as reviewed by stuefe
On Wed, 26 Jul 2023 10:29:25 GMT, Andreas Steiner wrote:
>> On AIX the 'nm' needs -X64 option.
>
> Andreas Steiner has updated the pull request incrementally with one
> additional commit since the last revision:
>
> correction of comment
Marked as reviewed by mbaesken (Reviewer).
On Wed, 26 Jul 2023 08:01:29 GMT, Matthias Baesken wrote:
> Hi Andreas, thanks for addressing this. Should it be 'needs' instead of
> 'need' in the comment you added ?
>
> Btw did you look at the naming of the mangled symbols we check for
> (SetupOperatorNewDeleteCheck) , are those names
> On AIX the 'nm' needs -X64 option.
Andreas Steiner has updated the pull request incrementally with one additional
commit since the last revision:
correction of comment
-
Changes:
- all: https://git.openjdk.org/jdk/pull/15036/files
- new:
On Wed, 26 Jul 2023 07:52:44 GMT, Andreas Steiner wrote:
> On AIX the 'nm' needs -X64 option.
Right, thanks for jolting my memory
-
PR Comment: https://git.openjdk.org/jdk/pull/15036#issuecomment-1651237444
On Wed, 26 Jul 2023 08:10:26 GMT, Julian Waters wrote:
> I am fairly certain there is a better spot for this, but I cannot remember
> where at the moment. Is this for JvmMapfile.gmk where we dump the symbols of
> object files, or for something else?
It is needed for the
On Wed, 26 Jul 2023 07:52:44 GMT, Andreas Steiner wrote:
> On AIX the 'nm' needs -X64 option.
I am fairly certain there is a better spot for this, but I cannot remember
where at the moment. Is this for JvmMapfile.gmk where we dump the symbols of
object files, or for something else?
On Wed, 26 Jul 2023 07:52:44 GMT, Andreas Steiner wrote:
> On AIX the 'nm' needs -X64 option.
Hi Andreas, thanks for addressing this.
Should it be 'needs' instead of 'need' in the comment you added ?
Btw did you look at the naming of the mangled symbols we check for
On AIX the 'nm' needs -X64 option.
-
Commit messages:
- JDK-8312466
Changes: https://git.openjdk.org/jdk/pull/15036/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=15036=00
Issue: https://bugs.openjdk.org/browse/JDK-8312466
Stats: 6 lines in 1 file changed: 6 ins; 0 del; 0
On Wed, 26 Jul 2023 07:21:13 GMT, Matthias Baesken wrote:
>> In case of issues in the configure step, we run into error messages like
>> this :
>>
>> configure: Current directory is /openjdk/jdk_4/build_mymachine.
>> configure: Since this is not the source root, configure will output the
>>
On Thu, 29 Jun 2023 18:59:45 GMT, Jesse Glick wrote:
> @jaikiran in
> https://github.com/openjdk/jdk/pull/12871#issuecomment-1612310113 pointed me
> to a resource I had not previously found. https://openjdk.org/contribute is
> fine at a high level but still says things like
>
>> When your
On Thu, 29 Jun 2023 18:59:45 GMT, Jesse Glick wrote:
> @jaikiran in
> https://github.com/openjdk/jdk/pull/12871#issuecomment-1612310113 pointed me
> to a resource I had not previously found. https://openjdk.org/contribute is
> fine at a high level but still says things like
>
>> When your
@jaikiran in https://github.com/openjdk/jdk/pull/12871#issuecomment-1612310113
pointed me to a resource I had not previously found.
https://openjdk.org/contribute is fine at a high level but still says things
like
> When your change is ready, send a message to the appropriate development list…
On Tue, 25 Jul 2023 12:00:56 GMT, Matthias Baesken wrote:
> In case of issues in the configure step, we run into error messages like this
> :
>
> configure: Current directory is /openjdk/jdk_4/build_mymachine.
> configure: Since this is not the source root, configure will output the
>
> In case of issues in the configure step, we run into error messages like this
> :
>
> configure: Current directory is /openjdk/jdk_4/build_mymachine.
> configure: Since this is not the source root, configure will output the
> configuration here
> configure: (as opposed to creating a
On Wed, 19 Jul 2023 10:58:58 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to deprecate for
>> removal the `-Xdebug` option and `-debug` option of the `java` command?
>> This addresses https://bugs.openjdk.org/browse/JDK-8227229.
>>
>> As noted in the
On Tue, 25 Jul 2023 12:00:56 GMT, Matthias Baesken wrote:
> In case of issues in the configure step, we run into error messages like this
> :
>
> configure: Current directory is /openjdk/jdk_4/build_mymachine.
> configure: Since this is not the source root, configure will output the
>
27 matches
Mail list logo
