Re: RFR: 8313374: --enable-ccache's CCACHE_BASEDIR breaks builds [v6]

2023-08-15 Thread Kim Barrett
> On Aug 14, 2023, at 10:09 AM, Erik Joelsson wrote: > > On Wed, 9 Aug 2023 12:36:59 GMT, Jan Kratochvil > wrote: > >>> https://bugs.openjdk.org/browse/JDK-8313374 >>> --enable-ccache's CCACHE_BASEDIR breaks builds >> >> Jan Kratochvil has updated the pull request incrementally with one >>

Integrated: 8314166: Update googletest to v1.14.0

2023-08-15 Thread Mikael Vidstedt
On Fri, 11 Aug 2023 22:24:00 GMT, Mikael Vidstedt wrote: > As part of the ongoing work to enable -Wconversion with gcc there are a > number of occurrences of code in the GoogleTest code itself which need > fixing. These have been addressed in version 1.14.0 of GoogleTest. This > change is pick

Re: RFR: 8314166: Update googletest to v1.14.0 [v2]

2023-08-15 Thread Mikael Vidstedt
On Tue, 15 Aug 2023 17:05:28 GMT, Mikael Vidstedt wrote: >> As part of the ongoing work to enable -Wconversion with gcc there are a >> number of occurrences of code in the GoogleTest code itself which need >> fixing. These have been addressed in version 1.14.0 of GoogleTest. This >> change is

Re: RFR: 8314166: Update googletest to v1.14.0 [v2]

2023-08-15 Thread Mikael Vidstedt
> As part of the ongoing work to enable -Wconversion with gcc there are a > number of occurrences of code in the GoogleTest code itself which need > fixing. These have been addressed in version 1.14.0 of GoogleTest. This > change is picking up that version, adjusting the relevant build configura

Re: RFR: 8313661: [REDO] Relax prerequisites for java.base-jmod target

2023-08-15 Thread Alan Bateman
On Mon, 14 Aug 2023 22:18:56 GMT, Erik Joelsson wrote: > This is a redo of [pull/14561](https://git.openjdk.org/jdk/pull/14561). The > change relaxes the prerequisites for the top level java.base-jmod target to > not include targets for jmods of upgradable modules. > > The problem with the pr

Re: RFR: 8314265: Fix -Wconversion warnings in miscellaneous runtime code

2023-08-15 Thread Coleen Phillimore
On Thu, 10 Aug 2023 20:31:20 GMT, Coleen Phillimore wrote: > Fix MaxElementPrintSize and casts. Also fixed miscellaneous -Wconversion > warnings in runtime code. This is the last one I'm going to do for runtime > for a while. > Tested with tier1-4. @tstuefe There are some metaspace changes he

Re: RFR: 8314262: GHA: Cut down cross-compilation sysroots deeper

2023-08-15 Thread Erik Joelsson
On Tue, 15 Aug 2023 12:36:05 GMT, Aleksey Shipilev wrote: > [JDK-8294941](https://bugs.openjdk.org/browse/JDK-8294941) cut out some > unused files in GHA sysroots. But I notice that even after that, we still > have quite a bit of fluff there, especially in RISC-V sysroot. We can cut a > bit de

RFR: 8314262: GHA: Cut down cross-compilation sysroots deeper

2023-08-15 Thread Aleksey Shipilev
[JDK-8294941](https://bugs.openjdk.org/browse/JDK-8294941) cut out some unused files in GHA sysroots. But I notice that even after that, we still have quite a bit of fluff there, especially in RISC-V sysroot. We can cut a bit deeper. Notably, we don't need runnable gcc in the sysroot, because we

RFR: 8314265: Fix -Wconversion warnings in miscellaneous runtime code

2023-08-15 Thread Coleen Phillimore
Fix MaxElementPrintSize and casts. Also fixed miscellaneous -Wconversion warnings in runtime code. This is the last one I'm going to do for runtime for a while. Tested with tier1-4. - Commit messages: - Use parse_integer instead of strtol with a cast. - Unset Wconversion - Fix e

Re: RFR: JDK-8313764: Offer JVM HS functionality to shared lib load operations done by the JDK codebase

2023-08-15 Thread Matthias Baesken
On Mon, 14 Aug 2023 07:48:00 GMT, Matthias Baesken wrote: > Currently there is a number of functionality that would be interesting to > have for shared lib load operations in the JDK C code. > Some examples : > Events::log_dll_message for hs-err files reporting > JFR event NativeLibraryLoad > Th