Integrated: 8268719: Force execution (and source) code page used when compiling on Windows

2023-09-06 Thread Saint Wesonga
On Tue, 5 Sep 2023 15:51:58 GMT, Saint Wesonga wrote: > Set MSVC source and execution character sets to UTF-8 to enable Visual C++ to > compile all source files regardless of the active code page on Windows. This > avoids build errors due to "warning C4819: The file contains a character that

Re: RFR: 8315794: RISC-V: build fails with GCC 12.3

2023-09-06 Thread Fei Yang
On Wed, 6 Sep 2023 14:29:56 GMT, Antonios Printezis wrote: > The build failure happens when building on RISC-V with GCC 12.3. Is there a > better way to address this than disabling the stringop-overflow warnings for > the two files in question? Marked as reviewed by fyang (Reviewer).

Re: RFR: 8315794: RISC-V: build fails with GCC 12.3

2023-09-06 Thread Fei Yang
On Wed, 6 Sep 2023 14:29:56 GMT, Antonios Printezis wrote: > The build failure happens when building on RISC-V with GCC 12.3. Is there a > better way to address this than disabling the stringop-overflow warnings for > the two files in question? Hi, I once created a similar JBS issue and

Re: RFR: 8267174: Many test files have the wrong Copyright header

2023-09-06 Thread Alan Bateman
On Wed, 6 Sep 2023 16:49:39 GMT, Chris Plummer wrote: > > I wonder if this is the right thing to do for the hprof files. I believe > > they originated from some hprof tools that we no longer ship. 3rd parties > > might choose to integrate them into their own tools. > > Do you think I should

Re: RFR: 8309130: x86_64 AVX512 intrinsics for Arrays.sort methods (int, long, float and double arrays) [v30]

2023-09-06 Thread Srinivas Vamsi Parasa
On Wed, 30 Aug 2023 15:10:45 GMT, Srinivas Vamsi Parasa wrote: >>> Hi Vladimir, Just verified that the test/jdk/java/util/Arrays/Sorting.java >>> is triggering the intrinsic without additional flags >> >> Just to add that Sorting.java has short and long run modes. The default when >> running

Re: RFR: 8267174: Many test files have the wrong Copyright header

2023-09-06 Thread Chris Plummer
On Wed, 6 Sep 2023 16:06:29 GMT, Erik Joelsson wrote: > > I wonder if this is the right thing to do for the hprof files. I believe > > they originated from some hprof tools that we no longer ship. 3rd parties > > might choose to integrate them into their own tools. > > Do you think I should

Re: RFR: 8267174: Many test files have the wrong Copyright header

2023-09-06 Thread Erik Joelsson
On Tue, 5 Sep 2023 23:12:51 GMT, Chris Plummer wrote: > I wonder if this is the right thing to do for the hprof files. I believe they > originated from some hprof tools that we no longer ship. 3rd parties might > choose to integrate them into their own tools. Do you think I should revert

Re: RFR: 8312522: Implementation of Foreign Function & Memory API [v10]

2023-09-06 Thread Paul Sandoz
On Wed, 6 Sep 2023 10:50:59 GMT, Jorn Vernee wrote: >> src/java.base/share/classes/java/lang/foreign/Linker.java line 152: >> >>> 150: * >>> 151: * The following table shows some examples of how C types are modelled >>> in Linux/x64 (all the examples provided >>> 152: * here will assume

Re: RFR: 8267174: Many test files have the wrong Copyright header

2023-09-06 Thread Iris Clark
On Tue, 5 Sep 2023 22:49:41 GMT, Erik Joelsson wrote: > There are a number of files in the `test` directory that have an incorrect > copyright header, which includes the "classpath" exception text. This patch > removes that text from all test files that I could find it in. I did this > using

Re: RFR: 8308995: Update Network IO JFR events to be static mirror events [v4]

2023-09-06 Thread Tim Prinzing
On Tue, 22 Aug 2023 07:31:36 GMT, Alan Bateman wrote: > > https://bugs.openjdk.org/browse/JDK-8310979 - better exception handling > > https://bugs.openjdk.org/browse/JDK-8310978 - missing code paths for event > > generation https://bugs.openjdk.org/browse/JDK-8310994 - non-blocking, > > event

Re: RFR: 8315794: RISC-V: build fails with GCC 12.3

2023-09-06 Thread Erik Joelsson
On Wed, 6 Sep 2023 14:29:56 GMT, Antonios Printezis wrote: > The build failure happens when building on RISC-V with GCC 12.3. Is there a > better way to address this than disabling the stringop-overflow warnings for > the two files in question? Is there any merit to the warning? Generally

Re: RFR: 8268719: Force execution (and source) code page used when compiling on Windows

2023-09-06 Thread Erik Joelsson
On Tue, 5 Sep 2023 15:51:58 GMT, Saint Wesonga wrote: > Set MSVC source and execution character sets to UTF-8 to enable Visual C++ to > compile all source files regardless of the active code page on Windows. This > avoids build errors due to "warning C4819: The file contains a character that

RFR: 8315794: RISC-V: build fails with GCC 12.3

2023-09-06 Thread Antonios Printezis
The build failure happens when building on RISC-V with GCC 12.3. Is there a better way to address this than disabling the stringop-overflow warnings for the two files in question? - Commit messages: - 8315794: RISC-V: build fails with GCC 12.3 Changes:

Re: RFR: 8268719: Force execution (and source) code page used when compiling on Windows

2023-09-06 Thread Julian Waters
On Tue, 5 Sep 2023 15:51:58 GMT, Saint Wesonga wrote: > Set MSVC source and execution character sets to UTF-8 to enable Visual C++ to > compile all source files regardless of the active code page on Windows. This > avoids build errors due to "warning C4819: The file contains a character that

RFR: 8268719: Force execution (and source) code page used when compiling on Windows

2023-09-06 Thread Saint Wesonga
Set MSVC source and execution character sets to UTF-8 to enable Visual C++ to compile all source files regardless of the active code page on Windows. This avoids build errors due to "warning C4819: The file contains a character that cannot be represented in the current code page (932). Save the

Re: RFR: 8267174: Many test files have the wrong Copyright header

2023-09-06 Thread Alexey Ivanov
On Tue, 5 Sep 2023 22:49:41 GMT, Erik Joelsson wrote: > There are a number of files in the `test` directory that have an incorrect > copyright header, which includes the "classpath" exception text. This patch > removes that text from all test files that I could find it in. I did this > using

Re: RFR: 8312522: Implementation of Foreign Function & Memory API [v14]

2023-09-06 Thread Jorn Vernee
> This patch contains the implementation of the foreign linker & memory API JEP > for Java 22. The initial patch is composed of commits brought over directly > from the [panama-foreign repo](https://github.com/openjdk/panama-foreign). > The main changes found in this patch come from the

Re: RFR: 8267174: Many test files have the wrong Copyright header

2023-09-06 Thread Daniel Fuchs
On Tue, 5 Sep 2023 22:49:41 GMT, Erik Joelsson wrote: > There are a number of files in the `test` directory that have an incorrect > copyright header, which includes the "classpath" exception text. This patch > removes that text from all test files that I could find it in. I did this > using

Re: RFR: 8312522: Implementation of Foreign Function & Memory API [v13]

2023-09-06 Thread Jorn Vernee
> This patch contains the implementation of the foreign linker & memory API JEP > for Java 22. The initial patch is composed of commits brought over directly > from the [panama-foreign repo](https://github.com/openjdk/panama-foreign). > The main changes found in this patch come from the

Re: RFR: 8312522: Implementation of Foreign Function & Memory API [v10]

2023-09-06 Thread Jorn Vernee
On Tue, 5 Sep 2023 21:01:00 GMT, Paul Sandoz wrote: >> Jorn Vernee has updated the pull request incrementally with five additional >> commits since the last revision: >> >> - 8315096: Allowed access modes in memory segment should depend on layout >> alignment >> >>Reviewed-by:

Re: RFR: 8312522: Implementation of Foreign Function & Memory API [v11]

2023-09-06 Thread Jorn Vernee
On Wed, 6 Sep 2023 10:46:33 GMT, Martin Doerr wrote: >> Jorn Vernee has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix typo in doc >> >> Co-authored-by: Paul Sandoz > > Please adapt the new `LinuxPPC64Linker` when merging: > >

Re: RFR: 8312522: Implementation of Foreign Function & Memory API [v11]

2023-09-06 Thread Martin Doerr
On Wed, 6 Sep 2023 10:04:35 GMT, Jorn Vernee wrote: >> This patch contains the implementation of the foreign linker & memory API >> JEP for Java 22. The initial patch is composed of commits brought over >> directly from the [panama-foreign >> repo](https://github.com/openjdk/panama-foreign).

Re: RFR: 8312522: Implementation of Foreign Function & Memory API [v12]

2023-09-06 Thread Jorn Vernee
> This patch contains the implementation of the foreign linker & memory API JEP > for Java 22. The initial patch is composed of commits brought over directly > from the [panama-foreign repo](https://github.com/openjdk/panama-foreign). > The main changes found in this patch come from the

Re: RFR: 8312522: Implementation of Foreign Function & Memory API [v11]

2023-09-06 Thread Jorn Vernee
On Tue, 5 Sep 2023 21:56:54 GMT, Paul Sandoz wrote: >> Jorn Vernee has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix typo in doc >> >> Co-authored-by: Paul Sandoz > >

Re: RFR: 8312522: Implementation of Foreign Function & Memory API [v11]

2023-09-06 Thread Jorn Vernee
> This patch contains the implementation of the foreign linker & memory API JEP > for Java 22. The initial patch is composed of commits brought over directly > from the [panama-foreign repo](https://github.com/openjdk/panama-foreign). > The main changes found in this patch come from the

Re: RFR: 8312522: Implementation of Foreign Function & Memory API [v10]

2023-09-06 Thread Jorn Vernee
On Tue, 5 Sep 2023 21:10:47 GMT, Paul Sandoz wrote: >> Jorn Vernee has updated the pull request incrementally with five additional >> commits since the last revision: >> >> - 8315096: Allowed access modes in memory segment should depend on layout >> alignment >> >>Reviewed-by:

Re: RFR: 8267174: Many test files have the wrong Copyright header

2023-09-06 Thread Alan Bateman
On Tue, 5 Sep 2023 23:15:53 GMT, Jonathan Gibbons wrote: > One has to wonder about the `**/*_OLD.java` files, but that would be a > different cleanup The IBM double byte charsets were re-implemented in JDK 7. I think the old implementations moved to the test tree so it could be used to test