Re: RFR: JDK-8296240: Augment discussion of test tiers in doc/testing.md [v5]

2023-10-30 Thread Joe Darcy
> Clarify the intention of tier 1 tests. I'll reflow the paragraph and > regenerate the HTML file once the wording is agreed upon. Joe Darcy has updated the pull request incrementally with one additional commit since the last revision: Initial check-in of updated HTML file. -

Re: RFR: JDK-8306980: Generated docs should contain correct Legal Documents [v2]

2023-10-30 Thread Mandy Chung
On Thu, 26 Oct 2023 17:53:12 GMT, Jonathan Gibbons wrote: >> Please review an update to the way that `javadoc` handles the default legal >> notices when generating docs. >> >> Previously, the default notices were taken from the module's `legal` >> directory (`$JAVA_HOME/legal/jdk.javadoc`),

Re: RFR: JDK-8296240: Augment discussion of test tiers in doc/testing.md [v2]

2023-10-30 Thread Jonathan Gibbons
On 10/29/23 11:21 AM, Alan Bateman wrote: On Sat, 28 Oct 2023 21:03:50 GMT, Joe Darcy wrote: So in terms of a sentence or two of guidance, I think "aim for 10 seconds or less almost all of the time for a tier 1 test" is reasonable in this context. Yes, I think making it an aspiration

Re: OpenJDK 21 Build on MacOS Sonoma throwing WARNING: Secure coding is automatically enabled

2023-10-30 Thread erik . joelsson
On 10/30/23 10:05, Philip Race wrote: It is possible to use Xcode 12 on macOS14. Our internal build system manages to make this work. Don't ask me for the details, because I don't know them very well. Internally we use macOS 13.x  and Xcode 14.3.1 to build JDK 22, and macOS 12.x and Xcode

Re: RFR: JDK-8313790: [arm32] Specify -marm when building without an ABI profile

2023-10-30 Thread Erik Joelsson
On Fri, 4 Aug 2023 16:17:04 GMT, Thomas Stuefe wrote: > See [JDK-8288719](https://bugs.openjdk.org/browse/JDK-8288719) and subsequent > [discussion](https://mail.openjdk.org/pipermail/build-dev/2022-May/034635.html) > back in 2022. > > On Arm, we can generate either arm- or thumb-code

Re: RFR: 8319121: hsdis binutils: speedup building from source

2023-10-30 Thread Erik Joelsson
On Mon, 30 Oct 2023 15:41:48 GMT, Robbin Ehn wrote: > Hi all, please consider. > > Tested configure with binutils-src. > > Thanks This is a good idea, but to get it to work I think we need to re-order things in `configure.ac`. `BPERF_SETUP_BUILD_JOBS` is currently quite late.

Re: RFR: JDK-8296240: Augment discussion of test tiers in doc/testing.md [v4]

2023-10-30 Thread Joe Darcy
> Clarify the intention of tier 1 tests. I'll reflow the paragraph and > regenerate the HTML file once the wording is agreed upon. Joe Darcy has updated the pull request incrementally with one additional commit since the last revision: Implement review feedback. - Changes: -

Re: RFR: JDK-8296240: Augment discussion of test tiers in doc/testing.md [v2]

2023-10-30 Thread Joe Darcy
On Sun, 29 Oct 2023 18:19:12 GMT, Alan Bateman wrote: > > So in terms of a sentence or two of guidance, I think "aim for 10 seconds > > or less almost all of the time for a tier 1 test" is reasonable in this > > context. > > Yes, I think making it an aspiration would be better. > > In

Re: OpenJDK 21 Build on MacOS Sonoma throwing WARNING: Secure coding is automatically enabled

2023-10-30 Thread Philip Race
It is possible to use Xcode 12 on macOS14. Our internal build system manages to make this work. Don't ask me for the details, because I don't know them very well. I think you may have to create a (free) Apple developer a/c to be able to get the older Xcodes. That's step 1. But you are going to

RFR: JDK-8313790: [arm32] Specify -marm when building without an ABI profile

2023-10-30 Thread Thomas Stuefe
See [JDK-8288719](https://bugs.openjdk.org/browse/JDK-8288719) and subsequent [discussion](https://mail.openjdk.org/pipermail/build-dev/2022-May/034635.html) back in 2022. On Arm, we can generate either arm- or thumb-code (`-marm` or `-mthumb`). At the moment, if we don't specify an ABI

RFR: 8319121: hsdis binutils: speedup building from source

2023-10-30 Thread Robbin Ehn
Hi all, please consider. Tested configure with binutils-src. Thanks - Commit messages: - Use -j Changes: https://git.openjdk.org/jdk/pull/16421/files Webrev: https://webrevs.openjdk.org/?repo=jdk=16421=00 Issue: https://bugs.openjdk.org/browse/JDK-8319121 Stats: 2 lines in 1

Re: RFR: 8317132: Prepare HotSpot for permissive- [v9]

2023-10-30 Thread Julian Waters
> Prepare HotSpot for the permissive- Visual C++ flag, this change contains all > of the fixes required for HotSpot to compile under the stricter mode > activated when the permissive- flag is passed > > - Reworks code in topLevelUnhandledExceptionFilter for os_windows.cpp to > avoid goto

Re: RFR: 8317132: Prepare HotSpot for permissive- [v8]

2023-10-30 Thread Julian Waters
On Mon, 30 Oct 2023 15:08:03 GMT, Julian Waters wrote: >> Prepare HotSpot for the permissive- Visual C++ flag, this change contains >> all of the fixes required for HotSpot to compile under the stricter mode >> activated when the permissive- flag is passed >> >> - Reworks code in

Re: OpenJDK 21 Build on MacOS Sonoma throwing WARNING: Secure coding is automatically enabled

2023-10-30 Thread Asif Ikram
Dear Philip Thanks for your response and directions. I guess it is not possible to use Xcode 12.x on MacOS14, because it asks for the latest version of Xcode. I used the OpenJDk20 binary and OpenJDK21 binary to create the build from OpenJDK21+35 source code, but I'm still facing the same

Re: RFR: 8314488: Compile the JDK as C++17

2023-10-30 Thread Julian Waters
On Mon, 24 Jul 2023 01:41:16 GMT, Julian Waters wrote: > Implementation of [JEP draft: Compile the JDK as > C++17](https://bugs.openjdk.org/browse/JDK-8310260) Keeping alive - PR Comment: https://git.openjdk.org/jdk/pull/14988#issuecomment-1785145814

Integrated: JDK-8318961: increase javacserver connection timeout values and max retry attempts

2023-10-30 Thread Matthias Baesken
On Fri, 27 Oct 2023 10:43:58 GMT, Matthias Baesken wrote: > Increase javacserver connection timeout values and max retry attempts for > better make stability on some slower machines. This pull request has now been integrated. Changeset: b9983c72 Author:Matthias Baesken URL:

Re: RFR: JDK-8318961: increase javacserver connection timeout values and max retry attempts [v2]

2023-10-30 Thread Matthias Baesken
On Mon, 30 Oct 2023 09:29:05 GMT, Matthias Baesken wrote: >> Increase javacserver connection timeout values and max retry attempts for >> better make stability on some slower machines. > > Matthias Baesken has updated the pull request incrementally with one > additional commit since the last

Re: RFR: JDK-8318961: increase javacserver connection timeout values and max retry attempts [v2]

2023-10-30 Thread Erik Joelsson
On Mon, 30 Oct 2023 09:29:05 GMT, Matthias Baesken wrote: >> Increase javacserver connection timeout values and max retry attempts for >> better make stability on some slower machines. > > Matthias Baesken has updated the pull request incrementally with one > additional commit since the last

Re: RFR: JDK-8318961: increase javacserver connection timeout values and max retry attempts [v2]

2023-10-30 Thread Matthias Baesken
> Increase javacserver connection timeout values and max retry attempts for > better make stability on some slower machines. Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision: Adjust WAIT_BETWEEN_CONNECT_ATTEMPTS -

Re: RFR: JDK-8318961: increase javacserver connection timeout values and max retry attempts

2023-10-30 Thread Matthias Baesken
On Fri, 27 Oct 2023 10:43:58 GMT, Matthias Baesken wrote: > Increase javacserver connection timeout values and max retry attempts for > better make stability on some slower machines. I adjusted the WAIT_BETWEEN_CONNECT_ATTEMPTS; Let's how this works. - PR Comment: