On Tue, 24 Oct 2023 19:58:58 GMT, Matthew Donovan wrote:
>> Hello,
>>
>> In this PR I removed NSS tests from the ProblemList and updated NssTest to
>> use Sqlite databases. I also removed code in PKCS11Test.java that falls back
>> to NSS libraries installed on the test system. The tests can st
On Mon, 20 Nov 2023 15:08:22 GMT, Magnus Ihse Bursie wrote:
>> Update the build documentation to reflect the fact that non-English locales
>> are only supported on a "best effort" principle, and add instructions how to
>> install the necessary language pack to Visual Studio.
>
> Magnus Ihse Bur
> Classfile API is an internal library under package `jdk.internal.classfile`
> in JDK 21.
> This pull request turns the Classfile API into a preview feature and moves it
> into `java.lang.classfile`.
> It repackages all uses across JDK and tests and adds lots of missing Javadoc.
>
> This PR goe
> Classfile API is an internal library under package `jdk.internal.classfile`
> in JDK 21.
> This pull request turns the Classfile API into a preview feature and moves it
> into `java.lang.classfile`.
> It repackages all uses across JDK and tests and adds lots of missing Javadoc.
>
> This PR goe
On Fri, 10 Nov 2023 00:42:43 GMT, Magnus Ihse Bursie wrote:
> The build changes almost look good. Just remove the extra added lines at the
> end.
>
> I think this point too still remains:
>
> > 1. TransitiveDependencies seems to be unused now. I assume this is
> > intended. But maybe the java
On Mon, 20 Nov 2023 15:08:22 GMT, Magnus Ihse Bursie wrote:
>> Update the build documentation to reflect the fact that non-English locales
>> are only supported on a "best effort" principle, and add instructions how to
>> install the necessary language pack to Visual Studio.
>
> Magnus Ihse Bur
On Mon, 20 Nov 2023 17:46:53 GMT, Joe Wang wrote:
>> Implement the built-in Catalog.
>
> Joe Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> add a note; fix alignment
Thank you Joe.
All good by me and Congrats on moving this across t
On Mon, 20 Nov 2023 16:48:51 GMT, Lance Andersen wrote:
> Hi Joe,
>
> Thank you for all of your hard work and perseverance to drive this project as
> I realize it was a lot of work and iterations based on feedback from the team.
>
> Overall looks good. A couple of minor comments below
Thanks
On Mon, 20 Nov 2023 16:38:54 GMT, Magnus Ihse Bursie wrote:
> Build change trivially okay
Thanks Magnus!
-
PR Comment: https://git.openjdk.org/jdk/pull/16719#issuecomment-1819529895
> Implement the built-in Catalog.
Joe Wang has updated the pull request incrementally with one additional commit
since the last revision:
add a note; fix alignment
-
Changes:
- all: https://git.openjdk.org/jdk/pull/16719/files
- new: https://git.openjdk.org/jdk/pull/16719/fil
> Consider a simple module, like:
>
> module test {}
>
>
> And compile it with JDK 22 and JDK 21 using:
> javac --release 21
>
> The results of the compilations will differ: when compiling with JDK 21, the
> mandated java.base dependency will get a version, possibly like
> "21-internal". When
On Sun, 19 Nov 2023 23:36:16 GMT, Joe Wang wrote:
>> Implement the built-in Catalog.
>
> Joe Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> remove J2SE directory; add note explaining how DTDs are resolved
Hi Joe,
Thank you for all o
On Sun, 19 Nov 2023 23:36:16 GMT, Joe Wang wrote:
>> Implement the built-in Catalog.
>
> Joe Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> remove J2SE directory; add note explaining how DTDs are resolved
Build change trivially okay
On Mon, 20 Nov 2023 14:34:51 GMT, Magnus Ihse Bursie wrote:
> Reflow the markdown in building.md so line lengths of 80 is respected,
> wherever possible.
>
> Note that is is correct that the building.html file is unchanged (and indeed
> a sign that only markdown line breaks have been modified
On Mon, 20 Nov 2023 14:34:51 GMT, Magnus Ihse Bursie wrote:
> Reflow the markdown in building.md so line lengths of 80 is respected,
> wherever possible.
>
> Note that is is correct that the building.html file is unchanged (and indeed
> a sign that only markdown line breaks have been modified
Reflow the markdown in building.md so line lengths of 80 is respected, wherever
possible.
Note that is is correct that the building.html file is unchanged (and indeed a
sign that only markdown line breaks have been modified).
-
Commit messages:
- 8320410: Reflow markdown in build
On Fri, 17 Nov 2023 13:06:53 GMT, Magnus Ihse Bursie wrote:
>> Update the build documentation to reflect the fact that non-English locales
>> are only supported on a "best effort" principle, and add instructions how to
>> install the necessary language pack to Visual Studio.
>
> Magnus Ihse Bur
> Update the build documentation to reflect the fact that non-English locales
> are only supported on a "best effort" principle, and add instructions how to
> install the necessary language pack to Visual Studio.
Magnus Ihse Bursie has updated the pull request incrementally with one
additional
On Fri, 17 Nov 2023 18:27:44 GMT, Naoto Sato wrote:
>> Oh, here are lots of news to me.
>>
>> 1) What is the system locale? How do you check which locale is the system
>> locale (as opposed to the user locale), and how to you change it?
>>
>> 2) What is the UTF-8 beta option?
>
> IMHO, Windows
On Mon, 23 Oct 2023 11:43:06 GMT, Matthew Donovan wrote:
>> I am not sure, but shouldn`t the change also adopt the documentation in
>> test/jdk/sun/security/pkcs11/README
>
>> I am not sure, but shouldn`t the change also adopt the documentation in
>> test/jdk/sun/security/pkcs11/README
>
> Goo
20 matches
Mail list logo
