Re: RFR: 8295795: hsdis does not build with binutils 2.39+ [v8]

2023-11-22 Thread Robbin Ehn
On Thu, 23 Nov 2023 07:47:30 GMT, Galder Zamarreño wrote: >> Yes, you are correct, this was not my intention. >> For some reason I mixed up AC_LANG_SOURCE and AC_LANG_PROGRAM. >> >> But nested function are fine, so there is actually no issue with it. > >> But nested function are fine, so there

Re: RFR: 8295795: hsdis does not build with binutils 2.39+ [v8]

2023-11-22 Thread Galder Zamarreño
On Thu, 23 Nov 2023 07:04:28 GMT, Robbin Ehn wrote: > But nested function are fine, so there is actually no issue with it. Is it? The compilation error above says "error: function definition is not allowed here". It seems to me is saying that the compilation fails because of the nested

Re: RFR: 8295795: hsdis does not build with binutils 2.39+ [v8]

2023-11-22 Thread Robbin Ehn
On Thu, 23 Nov 2023 05:01:14 GMT, Galder Zamarreño wrote: >> make/autoconf/lib-hsdis.m4 line 272: >> >>> 270: >>> 271: AC_MSG_CHECKING([Checking binutils API]) >>> 272: AC_COMPILE_IFELSE([AC_LANG_PROGRAM([#include $disasm_header],[[void >>> foo() {init_disassemble_info(0, 0, 0, 0);}]])],

RFR: 8320533: Adjust capstone integration for v6 changes

2023-11-22 Thread Galder Zamarreño
FYI @theRealAph It includes a couple of commits to integrate with Capstone v6 while still working with Capstone v5 and before: * `CAPSTONE_ARCH` for aarch64 is now `CS_ARCH_AARCH64` instead of `CS_ARCH_ARM64`. See [this

Re: RFR: 8295795: hsdis does not build with binutils 2.39+ [v8]

2023-11-22 Thread Galder Zamarreño
On Thu, 23 Nov 2023 04:58:22 GMT, Galder Zamarreño wrote: >> Robbin Ehn has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Added back guard > > make/autoconf/lib-hsdis.m4 line 272: > >> 270: >> 271: AC_MSG_CHECKING([Checking binutils

Re: RFR: 8295795: hsdis does not build with binutils 2.39+ [v8]

2023-11-22 Thread Galder Zamarreño
On Thu, 19 Oct 2023 13:49:21 GMT, Robbin Ehn wrote: >> Hi please consider. >> >> This works with 2.30, 2.34, 2.38, 2.39, 2.40, 2.41 and current master head. >> (tested x64 and some RV) >> >> There are 4 changes in binutils we work around. >> - zstd compressed debug sections >> - libsframe

Compile Errors in OpenJDK 11 with Non-English Characters in Compilation Path

2023-11-22 Thread last last
Hi all, I tried to build a OpenJDK11 fastdebug with paths that include Chinese characters,my build path is "/home/kylin/图片/jdk11u-dev",but i saw some error as followings: Exception in thread "main" java.nio.file.InvalidPathException: Malformed input or input contains unmappable characters:

Re: RFR: 8320515: assert(monitor->object_peek() != nullptr) failed: Owned monitors should not have a dead object

2023-11-22 Thread David Holmes
On Wed, 22 Nov 2023 15:00:29 GMT, Stefan Karlsson wrote: > In the rewrites made for: > [JDK-8318757](https://bugs.openjdk.org/browse/JDK-8318757) `VM_ThreadDump > asserts in interleaved ObjectMonitor::deflate_monitor calls` > > I removed the filtering of *owned ObjectMonitors with dead

Re: RFR: 8312425: [vectorapi] AArch64: Optimize vector math operations with SLEEF [v3]

2023-11-22 Thread Xiaohong Gong
On Tue, 21 Nov 2023 14:13:19 GMT, Magnus Ihse Bursie wrote: >> Yes, it seems weird. But the library we want to built out is `libvmath.so` >> instead of `libsleef.so`. And we not only check the sleef library, but also >> the ARM SVE feature inside it. So using `VMATH` suffix is more reasonable

Re: RFR: 8312425: [vectorapi] AArch64: Optimize vector math operations with SLEEF [v3]

2023-11-22 Thread Xiaohong Gong
On Tue, 21 Nov 2023 14:12:13 GMT, Magnus Ihse Bursie wrote: >> This is just used to print the result of `AC_MSG_CEHCKING[if ARM SVE feature >> is supported]` in configure. > > Ah, now I se what you are trying to do here. First of all, in the detection > part, only set `SVE_FEATURE_SUPPORT`.

Re: RFR: 8320515: assert(monitor->object_peek() != nullptr) failed: Owned monitors should not have a dead object

2023-11-22 Thread David Holmes
On Wed, 22 Nov 2023 15:00:29 GMT, Stefan Karlsson wrote: > Previously, the locked monitors never got unlocked because the ObjectMonitor > iterator never exposed these monitors to the JNI detach code I had not realized that. It explains some confusion in a separate issue I had been looking

Re: RFR: 8312425: [vectorapi] AArch64: Optimize vector math operations with SLEEF [v3]

2023-11-22 Thread Magnus Ihse Bursie
On Wed, 15 Nov 2023 01:32:00 GMT, Xiaohong Gong wrote: >> Currently the vector floating-point math APIs like >> `VectorOperators.SIN/COS/TAN...` are not intrinsified on AArch64 platform, >> which causes large performance gap on AArch64. Note that those APIs are >> optimized by C2 compiler on

Re: RFR: 8312425: [vectorapi] AArch64: Optimize vector math operations with SLEEF [v3]

2023-11-22 Thread Paul Sandoz
On Wed, 22 Nov 2023 09:05:31 GMT, Andrew Haley wrote: > > Have you considered the possibility of copying the sleef source to the > > OpenJDK repository and thereby it becomes part of the build process? I > > don't know how straightforward that is technically and IANAL but I think > > it's

Integrated: 8306055: Add a built-in Catalog to JDK XML module

2023-11-22 Thread Joe Wang
On Fri, 17 Nov 2023 20:22:40 GMT, Joe Wang wrote: > Implement the built-in Catalog. This pull request has now been integrated. Changeset: 93bdc2a6 Author:Joe Wang URL: https://git.openjdk.org/jdk/commit/93bdc2a6db91a95d6ee52ec92080e586c694dad5 Stats: 1647 lines in 50 files

Re: RFR: 8306055: Add a built-in Catalog to JDK XML module [v3]

2023-11-22 Thread Joe Wang
On Wed, 22 Nov 2023 08:58:41 GMT, Alan Bateman wrote: > I'm happy with the addition of the JDK built-in catalog, the inclusion of the > DTD defined by Java SE, and the docs updates. Thanks again, Alan, I really appreciate it! Finally got all pieces together, a nice foundation for the next.

Re: RFR: 8306055: Add a built-in Catalog to JDK XML module [v4]

2023-11-22 Thread Joe Wang
> Implement the built-in Catalog. Joe Wang has updated the pull request incrementally with one additional commit since the last revision: fix whitespace - Changes: - all: https://git.openjdk.org/jdk/pull/16719/files - new:

Re: RFR: 8306055: Add a built-in Catalog to JDK XML module [v3]

2023-11-22 Thread Joe Wang
On Wed, 22 Nov 2023 08:08:39 GMT, Andrey Turbanov wrote: >> Joe Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> add a note; fix alignment > > test/jaxp/javax/xml/jaxp/unittest/common/catalog/CatalogTestBase.java line > 299: > >>

Integrated: JDK-8317799 : AIX PPC64: FFI symbol lookup doesn't find symbols

2023-11-22 Thread suchismith1993
On Mon, 30 Oct 2023 10:54:48 GMT, suchismith1993 wrote: > The math library in AIX specifically, is a static archive. Doing a -lm wont > suffice, because when the symbols are looked up using dlsym or accessing > native code through Java, it will lead to failures. > Hence we had to come up with

RFR: 8320515: assert(monitor->object_peek() != nullptr) failed: Owned monitors should not have a dead object

2023-11-22 Thread Stefan Karlsson
In the rewrites made for: [JDK-8318757](https://bugs.openjdk.org/browse/JDK-8318757) `VM_ThreadDump asserts in interleaved ObjectMonitor::deflate_monitor calls` I removed the filtering of *owned ObjectMonitors with dead objects*. The reasoning was that you should never have an owned

Re: RFR: JDK-8317799 : AIX PPC64: FFI symbol lookup doesn't find symbols [v7]

2023-11-22 Thread suchismith1993
On Wed, 22 Nov 2023 06:50:07 GMT, Jorn Vernee wrote: >> suchismith1993 has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Fix Typos >> - Remove unnecessary includes > > Note that on Windows we also have a lookup mechanism on the Java

Re: RFR: JDK-8317799 : AIX PPC64: FFI symbol lookup doesn't find symbols [v8]

2023-11-22 Thread suchismith1993
> The math library in AIX specifically, is a static archive. Doing a -lm wont > suffice, because when the symbols are looked up using dlsym or accessing > native code through Java, it will lead to failures. > Hence we had to come up with a list of symbols to allow math library symbols > to be

Re: RFR: JDK-8317799 : AIX PPC64: FFI symbol lookup doesn't find symbols [v7]

2023-11-22 Thread Amit Kumar
On Tue, 21 Nov 2023 19:30:30 GMT, suchismith1993 wrote: >> The math library in AIX specifically, is a static archive. Doing a -lm wont >> suffice, because when the symbols are looked up using dlsym or accessing >> native code through Java, it will lead to failures. >> Hence we had to come up

Integrated: 8295343: sun/security/pkcs11 tests fail on Linux RHEL 8.6 and newer

2023-11-22 Thread Matthew Donovan
On Fri, 20 Oct 2023 19:18:47 GMT, Matthew Donovan wrote: > Hello, > > In this PR I removed NSS tests from the ProblemList and updated NssTest to > use Sqlite databases. I also removed code in PKCS11Test.java that falls back > to NSS libraries installed on the test system. The tests can still

Re: RFR: 8320358: GHA: ignore jdk* branches

2023-11-22 Thread intrigus-lgtm
On Tue, 21 Nov 2023 14:42:07 GMT, Kevin Rushforth wrote: > At some point we are likely to use stabilization branches in the mainline jdk > repo rather than a separate repo. In preparation, this PR excludes branches > matching `jdk*`, like we currently do for `master` and `pr/*`. > > A

Re: RFR: JDK-8298405: Support Markdown in Documentation Comments [v5]

2023-11-22 Thread Andrey Turbanov
On Wed, 15 Nov 2023 18:58:43 GMT, Jonathan Gibbons wrote: >> Please review a patch to add support for Markdown syntax in documentation >> comments, as described in the associated JEP. >> >> Notable features: >> >> * support for `///` documentation comments in `JavaTokenizer` >> * new module

Re: RFR: 8306055: Add a built-in Catalog to JDK XML module [v3]

2023-11-22 Thread Alan Bateman
On Mon, 20 Nov 2023 17:46:53 GMT, Joe Wang wrote: >> Implement the built-in Catalog. > > Joe Wang has updated the pull request incrementally with one additional > commit since the last revision: > > add a note; fix alignment I'm happy with the addition of the JDK built-in catalog, the

Re: RFR: 8312425: [vectorapi] AArch64: Optimize vector math operations with SLEEF [v3]

2023-11-22 Thread Andrew Haley
On Wed, 22 Nov 2023 01:52:51 GMT, Xiaohong Gong wrote: > > Have you considered the possibility of copying the sleef source to the > > OpenJDK repository and thereby it becomes part of the build process? I > > don't know how straightforward that is technically and IANAL but I think > > it's

Re: RFR: 8306055: Add a built-in Catalog to JDK XML module [v3]

2023-11-22 Thread Andrey Turbanov
On Mon, 20 Nov 2023 17:46:53 GMT, Joe Wang wrote: >> Implement the built-in Catalog. > > Joe Wang has updated the pull request incrementally with one additional > commit since the last revision: > > add a note; fix alignment